Re: [FFmpeg-devel] [PATCH 3/4] avformat/matroskaenc: Only write useful cropping values

From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 3/4] avformat/matroskaenc: Only write useful cropping values
Date: Mon, 8 Jul 2024 14:55:58 -0300
Message-ID: <0ed62782-2ff9-496b-b576-721e2a670f08@gmail.com> (raw)
In-Reply-To: <AS8P250MB074432A98088AE1C94D0E69F8FDA2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>

On 7/8/2024 2:52 PM, Andreas Rheinhardt wrote:
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>   libavformat/matroskaenc.c | 12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
> index 4b91283119..a98d33abf3 100644
> --- a/libavformat/matroskaenc.c
> +++ b/libavformat/matroskaenc.c
> @@ -1799,10 +1799,14 @@ static int mkv_write_track_video(AVFormatContext *s, MatroskaMuxContext *mkv,
>               return AVERROR(EINVAL);
>           }
>   
> -        ebml_writer_add_uint(&writer, MATROSKA_ID_VIDEOPIXELCROPB, bottom);
> -        ebml_writer_add_uint(&writer, MATROSKA_ID_VIDEOPIXELCROPT, top);
> -        ebml_writer_add_uint(&writer, MATROSKA_ID_VIDEOPIXELCROPL, left);
> -        ebml_writer_add_uint(&writer, MATROSKA_ID_VIDEOPIXELCROPR, right);
> +        if (bottom)
> +            ebml_writer_add_uint(&writer, MATROSKA_ID_VIDEOPIXELCROPB, bottom);
> +        if (top)
> +            ebml_writer_add_uint(&writer, MATROSKA_ID_VIDEOPIXELCROPT, top);
> +        if (left)
> +            ebml_writer_add_uint(&writer, MATROSKA_ID_VIDEOPIXELCROPL, left);
> +        if (right)
> +            ebml_writer_add_uint(&writer, MATROSKA_ID_VIDEOPIXELCROPR, right);
>   
>           cropped_width  -= left + right;
>           cropped_height -= top + bottom;

LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".