[FFmpeg-devel] [PATCH] correct expression of ternary operation.

[FFmpeg-devel] [PATCH] correct expression of ternary operation.

[Helge Klein]

Signed-off-by: Helge Klein <helge_klein@gmx.de>
---
  fftools/ffmpeg_opt.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
index 7f22b22604..11639e7468 100644
--- a/fftools/ffmpeg_opt.c
+++ b/fftools/ffmpeg_opt.c
@@ -228,7 +228,7 @@ static void correct_input_start_times(void)
              if (copy_ts && start_at_zero)
                  ifile->ts_offset = -new_start_time;
              else if (!copy_ts) {
-                abs_start_seek = is->start_time + (ifile->start_time !=
AV_NOPTS_VALUE) ? ifile->start_time : 0;
+                abs_start_seek = is->start_time + ((ifile->start_time
!= AV_NOPTS_VALUE) ? ifile->start_time : 0);
                  ifile->ts_offset = abs_start_seek > new_start_time ?
-abs_start_seek : -new_start_time;
              } else if (copy_ts)
                  ifile->ts_offset = 0;
--
2.31.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] correct expression of ternary operation.

[Leo Izen]

On 5/12/23 06:56, Helge Klein wrote:
> Signed-off-by: Helge Klein <helge_klein@gmx.de>
> ---
>   fftools/ffmpeg_opt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
> index 7f22b22604..11639e7468 100644
> --- a/fftools/ffmpeg_opt.c
> +++ b/fftools/ffmpeg_opt.c
> @@ -228,7 +228,7 @@ static void correct_input_start_times(void)
>               if (copy_ts && start_at_zero)
>                   ifile->ts_offset = -new_start_time;
>               else if (!copy_ts) {
> -                abs_start_seek = is->start_time + (ifile->start_time !=
> AV_NOPTS_VALUE) ? ifile->start_time : 0;
> +                abs_start_seek = is->start_time + ((ifile->start_time
> != AV_NOPTS_VALUE) ? ifile->start_time : 0);
>                   ifile->ts_offset = abs_start_seek > new_start_time ?
> -abs_start_seek : -new_start_time;
>               } else if (copy_ts)
>                   ifile->ts_offset = 0;
> -- 
> 2.31.1
> 

LGTM. Although the parentheses around (ifile->start_tile != 
AV_NOPTS_VALUE) can be removed as well.

- Leo Izen (Traneptora / thebombzen)

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".