From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 778814729C for ; Sun, 3 Sep 2023 18:49:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EF88668C580; Sun, 3 Sep 2023 21:49:36 +0300 (EEST) Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9DC5D68C4A6 for ; Sun, 3 Sep 2023 21:49:29 +0300 (EEST) Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-6bdcbde9676so740132a34.3 for ; Sun, 03 Sep 2023 11:49:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693766967; x=1694371767; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Upee/EqAa2ufSUwVaICkNdenuV5yu4OQ3YUIydGuZyo=; b=sdhaIeHvwWEc/AE6j5vHBunp+8zRgBf1gpaJCFsAOAZXDa9Oo63lz3cY+1zvq7zWCr FO0nUyXzFairX/FZU8Q1I3F5STMC5qs3DN3Xs8mXXaTjbcWzE4Rl0YXFlFPI6rlh3wii Tm+icgaVBlxs+Fkl30I1oPvRxKmoBjM23vthtxgxZZVeDIVJI6bu3PQiz7WgXikQJl1O KqDCcBfLRtEgz/DFitPE805bAl2rz7zvnQ+mkMvQm1OkDwWuK5/nJFVq1Y+63ZS0Yhie Ijhzz7qP0Qwv52EdszG5jmFajCs39kqz8v7VG8Cqh8EAV6bMBG5jnV6JhDIxBipBT6xH fYZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693766967; x=1694371767; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Upee/EqAa2ufSUwVaICkNdenuV5yu4OQ3YUIydGuZyo=; b=lrR+bsOWJzXT2FzkPXI/LMv9Cpt2s+2KnNhFMPhVwYUdMvRmdJF5r2ntH/n8P3ehQu uo7E5xpQJBfaTu1bSGMUF2687InipWEQREAf39b+XHqd+SD/MulklFPZX22+oP3e9MLT OoNW7r5iDJp2o6dtC9L7ZKKs1/ox/mCUuw5TYzg9bf/B+WCQk3upZh+hUkxc1u/yLOVO yE4Hw83iC6UnoIaPlHllxozg/E7j1g99ihmPLSOD1oQQkwl4r1Mwu0O/aX42VZ41Ltlr gMbLA+4LvdB/s1x797JuskgNVruB7UavI3jv256u5PU9SNfbLAGEUAqDYePuIxnAamTf vYeA== X-Gm-Message-State: AOJu0Yztan8VpULbkbuhZAs11NdTJZf5XG6pZYBbfQlgGyR5AtYBHr6f 4LOkimwJJHjjenIpsOqdIK7Oc5Gdu8o= X-Google-Smtp-Source: AGHT+IHT+Nnh52zjj5Ontk4kVRoLjK/VLBm6s7MWOf4+xozqsFvvn3f0TaVk5mZaclXkMrWkdvimCw== X-Received: by 2002:a9d:695a:0:b0:6bd:be5:daa2 with SMTP id p26-20020a9d695a000000b006bd0be5daa2mr9718796oto.33.1693766967586; Sun, 03 Sep 2023 11:49:27 -0700 (PDT) Received: from [192.168.0.10] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id i18-20020a9d6252000000b006b95e17fcc7sm3972128otk.49.2023.09.03.11.49.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Sep 2023 11:49:27 -0700 (PDT) Message-ID: <0df049ca-d41e-cb84-9797-aab9c709cfb7@gmail.com> Date: Sun, 3 Sep 2023 15:49:29 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230903160013.833742-1-aler9.dev@gmail.com> <9f409f1d-12cd-bc1d-3df0-50ee14486881@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/vpcc: fix VP9 metadata in FLV and RTMP X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 9/3/2023 1:45 PM, aler9 wrote: > I looked again at your previous comment and you suggested to explicitly > mention that this patch will affect FLV too, which i did in the title. > > I didn't see any request to change the code. Do you have any suggestion > regarding the code? I see the change in the commit message that i had missed, so nevermind. > > > > Il giorno dom 3 set 2023 alle ore 18:17 James Almer ha > scritto: > >> On 9/3/2023 1:15 PM, aler9 wrote: >>> sorry, to git add what? >> >> You say you integrated my comment, but the contents of the patch are >> exactly the same. >> >>> >>> Il giorno dom 3 set 2023 alle ore 18:02 James Almer >> ha >>> scritto: >>> >>>> On 9/3/2023 1:00 PM, Alessandro Ros wrote: >>>>> I integrated James A. comment and fixed patch format. >>>> >>>> I think you forgot to git add. >>>> >>>>> >>>>> In order to send VP9 tracks with FLV or RTMP, the enhanced RTMP >>>>> specification tells that VPCodecConfigurationRecord, a.k.a. vpcC >>>>> ISO-BMFF box, must be inserted into a metadata message. However, the >>>>> function responsible for generating vpcCs currently returns invalid >>>>> boxes, that are lacking the Version and Flag fields, inherited from >>>>> FullBox. For some reason, both flags were being added manually in >>>>> movenc. This patch fixes the issue. >>>>> >>>>> Signed-off-by: Alessandro Ros >>>>> --- >>>>> libavformat/movenc.c | 3 --- >>>>> libavformat/vpcc.c | 2 ++ >>>>> 2 files changed, 2 insertions(+), 3 deletions(-) >>>>> >>>>> diff --git a/libavformat/movenc.c b/libavformat/movenc.c >>>>> index 7ef6cef46a..696ae5a6c9 100644 >>>>> --- a/libavformat/movenc.c >>>>> +++ b/libavformat/movenc.c >>>>> @@ -1441,10 +1441,7 @@ static int mov_write_vpcc_tag(AVFormatContext >> *s, >>>> AVIOContext *pb, MOVTrack *tra >>>>> >>>>> avio_wb32(pb, 0); >>>>> ffio_wfourcc(pb, "vpcC"); >>>>> - avio_w8(pb, 1); /* version */ >>>>> - avio_wb24(pb, 0); /* flags */ >>>>> ff_isom_write_vpcc(s, pb, track->vos_data, track->vos_len, >>>> track->par); >>>>> - >>>>> return update_size(pb, pos); >>>>> } >>>>> >>>>> diff --git a/libavformat/vpcc.c b/libavformat/vpcc.c >>>>> index ea66959abf..256407dd6d 100644 >>>>> --- a/libavformat/vpcc.c >>>>> +++ b/libavformat/vpcc.c >>>>> @@ -208,6 +208,8 @@ int ff_isom_write_vpcc(AVFormatContext *s, >>>> AVIOContext *pb, >>>>> if (ret < 0) >>>>> return ret; >>>>> >>>>> + avio_w8(pb, 1); /* version */ >>>>> + avio_wb24(pb, 0); /* flags */ >>>>> avio_w8(pb, vpcc.profile); >>>>> avio_w8(pb, vpcc.level); >>>>> avio_w8(pb, (vpcc.bitdepth << 4) | (vpcc.chroma_subsampling << >> 1) >>>> | vpcc.full_range_flag); Will apply soon unless someone objects. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".