[FFmpeg-devel] [PATCH] track id could be zore

[FFmpeg-devel] [PATCH] track id could be zore

[=?gb18030?B?tdu9rS1WSUk=?=]

Signed-off-by: yunfei.li <1195878682@qq.com&gt;
---
&nbsp;libavformat/mov.c | 2 --
&nbsp;1 file changed, 2 deletions(-)


diff --git a/libavformat/mov.c b/libavformat/mov.c
index 6ee6ed0950..3b0c328e6a 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -4916,8 +4916,6 @@ static int mov_read_tfhd(MOVContext *c, AVIOContext *pb, MOVAtom atom)
&nbsp; &nbsp; &nbsp;flags = avio_rb24(pb);
&nbsp;
&nbsp; &nbsp; &nbsp;track_id = avio_rb32(pb);
-&nbsp; &nbsp; if (!track_id)
-&nbsp; &nbsp; &nbsp; &nbsp; return AVERROR_INVALIDDATA;
&nbsp; &nbsp; &nbsp;for (i = 0; i < c-&gt;trex_count; i++)
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;if (c-&gt;trex_data[i].track_id == track_id) {
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;trex = &amp;c-&gt;trex_data[i];
--&nbsp;
2.35.1.windows.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] track id could be zore

[Derek Buitenhuis]

On 8/12/2022 8:26 AM, 帝江-VII wrote:
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 6ee6ed0950..3b0c328e6a 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -4916,8 +4916,6 @@ static int mov_read_tfhd(MOVContext *c, AVIOContext *pb, MOVAtom atom)
>      flags = avio_rb24(pb);
>  
>      track_id = avio_rb32(pb);
> -    if (!track_id)
> -        return AVERROR_INVALIDDATA;


Bad patch formatting, aside, no, it cannot. Zero is not a
valid track ID.

- Derek
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".