Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Derek Buitenhuis <derek.buitenhuis@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] track id could be zore
Date: Fri, 12 Aug 2022 16:00:19 +0100
Message-ID: <0dc3f187-f873-3ac0-814a-c1a165785e5b@gmail.com> (raw)
In-Reply-To: <tencent_549B16B09A750FDF6E57851F128DEDB5BE07@qq.com>

On 8/12/2022 8:26 AM, 帝江-VII wrote:
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 6ee6ed0950..3b0c328e6a 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -4916,8 +4916,6 @@ static int mov_read_tfhd(MOVContext *c, AVIOContext *pb, MOVAtom atom)
> &nbsp; &nbsp; &nbsp;flags = avio_rb24(pb);
> &nbsp;
> &nbsp; &nbsp; &nbsp;track_id = avio_rb32(pb);
> -&nbsp; &nbsp; if (!track_id)
> -&nbsp; &nbsp; &nbsp; &nbsp; return AVERROR_INVALIDDATA;


Bad patch formatting, aside, no, it cannot. Zero is not a
valid track ID.

- Derek
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2022-08-12 15:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-12  7:26 =?gb18030?B?tdu9rS1WSUk=?=
2022-08-12 15:00 ` Derek Buitenhuis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0dc3f187-f873-3ac0-814a-c1a165785e5b@gmail.com \
    --to=derek.buitenhuis@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git