From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B064B45B74 for ; Fri, 24 Mar 2023 11:50:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 67C2C68C771; Fri, 24 Mar 2023 13:50:43 +0200 (EET) Received: from mail-oo1-f45.google.com (mail-oo1-f45.google.com [209.85.161.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DEBA968C75B for ; Fri, 24 Mar 2023 13:50:36 +0200 (EET) Received: by mail-oo1-f45.google.com with SMTP id n7-20020a4ae1c7000000b0053b61145406so231960oot.11 for ; Fri, 24 Mar 2023 04:50:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679658635; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vBeVFfCRusIN7cq+dKyhXQHm1q/vQXe7Dms0DtkEKc0=; b=QmBdY/TyF5lVS3Yf9kjoeQRJhCUhNwR8SSRbuDnxM9rBLsotDzxwb1B76d16KVPHy+ gqbcX10Y9C28i66QoNK0lI+e1elCW/+3bBiATbQ5i5wodsIovN/YH+zdeCaotoOemiuO XihsMZnDNoDoAfF5+aH+Q7rCDQWY0wLk6y7zm5Ey1QsQCnfecvDoHmJG0MO1bYpG8q3V n9Vbe23lGY+qop1I56EK8rQKimpIAmP5aY0sTkQLqSsmRjoQXzryVlp4WVqwisEW2LYt TwMwnS+GP5UCqFpbGT8XOzhanZOGv55H8VRsFlUCsczF2QHVOroCOzn5r28w1RSVoCEA 7qfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679658635; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vBeVFfCRusIN7cq+dKyhXQHm1q/vQXe7Dms0DtkEKc0=; b=I4DRbvoD7KIfe7s3oKUD3DhV+kuVRtWJF6m1gJwbCAdd9YFC9m4vr9LSej1nPSr0+t iIEvOidg0ZjaQsexX+AFdatXU/VlTfv+sLzkh+9X6XfWTcAeYIqMDIUPjCHDEeo0Zmct 4ohl9IinuXQ/7hBjIdsAtUIu5wj+c5zn6YqvK1XoT35h42j0wMSaluq8otT3Eus5wo6Y +g3pmMlOxNNNqMBoeB+AH/kRfSIRduwEs/FllOWs+442kOT/dQy2W7jUclqRMCm7mkB8 jXvuAR8CC4ScMZPuttJ4wN4mzV4Thh3LU5lIuQdvdmrIJpE5z2f6lWpG2GJIbvghYnAG Xrag== X-Gm-Message-State: AO0yUKWOl6VmZb7k7ZtguVnlTZ949WUjwpM3puIygfy2Sa7yRlpNYvn+ yYnQvuRTE4hdyEQ9xxHL+d4vvJCkImE= X-Google-Smtp-Source: AK7set+3GXENZMEf+bXchJJfWU2G/cOwGJhh56dbwbrtA6MQnNcwfeVuyzhUXlAdcHWyeIKwW/G3yg== X-Received: by 2002:a4a:49cc:0:b0:525:5c24:fa55 with SMTP id z195-20020a4a49cc000000b005255c24fa55mr1450371ooa.2.1679658633638; Fri, 24 Mar 2023 04:50:33 -0700 (PDT) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id y45-20020a4a9830000000b0053bb063121asm187505ooi.9.2023.03.24.04.50.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Mar 2023 04:50:33 -0700 (PDT) Message-ID: <0d1d14c8-b41d-b88d-8a74-e11f7c455bae@gmail.com> Date: Fri, 24 Mar 2023 08:50:40 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230321170637.10907-6-jamrial@gmail.com> <20230321180001.65412-1-jamrial@gmail.com> <167965834125.27013.4504786416238930490@lain.khirnov.net> From: James Almer In-Reply-To: <167965834125.27013.4504786416238930490@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH v2 6/7] avformat/matroskaenc: support writing Dynamic HDR10+ packet side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/24/2023 8:45 AM, Anton Khirnov wrote: > Quoting James Almer (2023-03-21 19:00:01) >> @@ -3095,6 +3153,12 @@ after_cues: >> avio_seek(mkv->track.bc, track->blockadditionmapping_offset, SEEK_SET); >> >> put_ebml_uint(mkv->track.bc, MATROSKA_ID_TRACKMAXBLKADDID, track->max_blockaddid); >> + if (track->max_blockaddid == 4) { // HDR10+ > > Maybe this magic 4 deserves a name too? Is has no name. See https://www.matroska.org/technical/codec_specs.html#itu-t35-metadata It only defines a name for the BlockAddIDType, which i used, and constricts the BlockAddIDValue to be used for it to 4. It's not necessarily HDR10+ (i can remove that comment if it makes it look like it should be named), it's potentially any ITU-T T35 payload of which we only care about HDR10+, so i can't name it that. It's simply 4. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".