Re: [FFmpeg-devel] [PATCH v2 6/7] avformat/matroskaenc: support writing Dynamic HDR10+ packet side data

From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v2 6/7] avformat/matroskaenc: support writing Dynamic HDR10+ packet side data
Date: Fri, 24 Mar 2023 08:50:40 -0300
Message-ID: <0d1d14c8-b41d-b88d-8a74-e11f7c455bae@gmail.com> (raw)
In-Reply-To: <167965834125.27013.4504786416238930490@lain.khirnov.net>

On 3/24/2023 8:45 AM, Anton Khirnov wrote:
> Quoting James Almer (2023-03-21 19:00:01)
>> @@ -3095,6 +3153,12 @@ after_cues:
>>               avio_seek(mkv->track.bc, track->blockadditionmapping_offset, SEEK_SET);
>>   
>>               put_ebml_uint(mkv->track.bc, MATROSKA_ID_TRACKMAXBLKADDID, track->max_blockaddid);
>> +            if (track->max_blockaddid == 4) { // HDR10+
> 
> Maybe this magic 4 deserves a name too?

Is has no name. See 
https://www.matroska.org/technical/codec_specs.html#itu-t35-metadata

It only defines a name for the BlockAddIDType, which i used, and 
constricts the BlockAddIDValue to be used for it to 4.
It's not necessarily HDR10+ (i can remove that comment if it makes it 
look like it should be named), it's potentially any ITU-T T35 payload of 
which we only care about HDR10+, so i can't name it that. It's simply 4.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".