From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7203042DEB for ; Wed, 7 Sep 2022 13:12:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C10D868BB82; Wed, 7 Sep 2022 16:12:55 +0300 (EEST) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EDA3868BB74 for ; Wed, 7 Sep 2022 16:12:48 +0300 (EEST) Received: by mail-wr1-f50.google.com with SMTP id e16so1061313wrx.7 for ; Wed, 07 Sep 2022 06:12:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date; bh=WJi8p6HwnqZQ9MS9Kw8s/PnjqVqNujNDM4i2RzJh33c=; b=lWdxg30tNBcb7AlEz75tL3hs5W+2myVwi8VVVp+YchrRS0hixvRiK/Z2ZAWXV03YKB /B+GSBytehl832/3t+wm4+oCoI/9Oj8YqUVr9mMueeybjcBvJoDyydXXY2W4vBZbLAE+ nxkV02OdGlCxAKQKiPeKrLYjC31D0/0otCKztHdeuycq/5U2UOxLrOHsfqkqPHGKB7EF 2fpql57K8dLLsdI4ppWe5SaZn+S+4baaCGmztxR4kF6UkaCUoiVJYM5Dm9sFU6N1qQ8u hnbvvxRiSikMkX4Uab/pkg60VGipyr3yOOO1murM+ZwxS0f8DyUql5qSfB0hJkHQza0a fvRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date; bh=WJi8p6HwnqZQ9MS9Kw8s/PnjqVqNujNDM4i2RzJh33c=; b=IzxFnMDiGWTGGsHCBfcX8xoYDbnk1tifr7TrEFyLukpCxEsefCxvHDax+EJ7m2LQUf nAH0odXXpipHqHno2YcdKqaDJu+DJQKO0M/Oezftlp9YZ7g9w/QYM59bI3pTsr/PNZ6G o2Trp+9iY5TawOmg7+7eW7HYmtosaUZ2UmJMJNN53mu2egYAehiWP1LQacFCio3lTo2W HkEO+231ADLfn1AV1N3PKrfggksldqvhU73jBuQgLIvlYTW5+R7JNA62y1iYZ/2AOo1Y ZHQNlo1tRg2LRVA4fc9zipMjVj3GnSmxqxArInIX3YEx6mw70VxgZdyid+FsyZ3SZFkH FOZA== X-Gm-Message-State: ACgBeo3HJXsipGqu0RYtknOfdUHW4M3mAGGjnEFWfVk0ZZMNz7VqB5aA eDEjQ9vT577YzySqmYJeNM89jKSkSvY= X-Google-Smtp-Source: AA6agR4L5DOl+T+OvJlrNnmcc45RO9Nd2hyKAtyf8houlr6rdTUBY4QUVT65a8axy5B80KU+rbNS1A== X-Received: by 2002:a05:6000:1189:b0:228:62c7:7e6c with SMTP id g9-20020a056000118900b0022862c77e6cmr2210422wrx.716.1662556367518; Wed, 07 Sep 2022 06:12:47 -0700 (PDT) Received: from [192.168.1.106] ([149.12.10.163]) by smtp.googlemail.com with ESMTPSA id bs30-20020a056000071e00b002287513f169sm12150705wrb.55.2022.09.07.06.12.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Sep 2022 06:12:46 -0700 (PDT) Message-ID: <0c396bde-b983-9722-2aa0-bf5c4eec77c3@gmail.com> Date: Wed, 7 Sep 2022 14:12:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 To: ffmpeg-devel@ffmpeg.org References: <20220417172658.GN3529341@pb2> <20220906214704.704687-1-izadi@google.com> From: Derek Buitenhuis In-Reply-To: <20220906214704.704687-1-izadi@google.com> Subject: Re: [FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 9/6/2022 10:47 PM, Mohammad Izadi wrote: > + if (side_data && side_data_size > 0) > + ff_write_dynamic_hdr10_plus_to_full_itu_t_t35((AVDynamicHDRPlus*)side_data, &hdr10_plus_itu_t_t35, &hdr10_plus_itu_t_t35_size); You can't use ff_-prefixed functions across library boundaries. It nees to be either public (av*) or avpriv. I suspect people won't want it to be avpriv. Personally, I think having serialization as a public API is useful, but YMMV. Mostly because I was just writing my own serialization to make use of the exported side data :P. - Derek _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".