From: Derek Buitenhuis <derek.buitenhuis@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska.
Date: Wed, 7 Sep 2022 14:12:46 +0100
Message-ID: <0c396bde-b983-9722-2aa0-bf5c4eec77c3@gmail.com> (raw)
In-Reply-To: <20220906214704.704687-1-izadi@google.com>
On 9/6/2022 10:47 PM, Mohammad Izadi wrote:
> + if (side_data && side_data_size > 0)
> + ff_write_dynamic_hdr10_plus_to_full_itu_t_t35((AVDynamicHDRPlus*)side_data, &hdr10_plus_itu_t_t35, &hdr10_plus_itu_t_t35_size);
You can't use ff_-prefixed functions across library boundaries.
It nees to be either public (av*) or avpriv. I suspect people won't want it to
be avpriv.
Personally, I think having serialization as a public API is useful, but YMMV. Mostly
because I was just writing my own serialization to make use of the exported side data :P.
- Derek
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-09-07 13:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220417172658.GN3529341@pb2>
2022-09-06 21:47 ` Mohammad Izadi
2022-09-06 22:29 ` Michael Niedermayer
2022-09-07 13:12 ` Derek Buitenhuis [this message]
2022-09-08 0:07 ` Mohammad Izadi
2022-09-08 1:22 ` Mohammad Izadi
2022-10-26 0:16 ` Andreas Rheinhardt
2022-09-08 16:31 ` Michael Niedermayer
2022-09-08 17:03 ` Mohammad Izadi
2022-10-25 23:38 ` Mohammad Izadi
2022-10-26 20:17 ` Michael Niedermayer
[not found] <20210818205538.GF4067@pb2>
2022-03-30 23:22 ` Mohammad Izadi
2022-04-17 17:15 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c396bde-b983-9722-2aa0-bf5c4eec77c3@gmail.com \
--to=derek.buitenhuis@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git