From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E40E445609 for ; Tue, 7 Feb 2023 19:18:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 514D368BC2E; Tue, 7 Feb 2023 21:18:07 +0200 (EET) Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1D01E68067F for ; Tue, 7 Feb 2023 21:18:00 +0200 (EET) Received: by mail-il1-f175.google.com with SMTP id w2so2757285ilg.8 for ; Tue, 07 Feb 2023 11:17:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y5yTlJ8pPcUzTL39uXzcxknjDTnbo9rfBg969n/IR7k=; b=nJrAPtBgFtJ4O18QODF/Vs6WZ8MJQRjG+Jd8PyUbvrgVZHJxA7isy9nmt6OAV8GlrA P+SS2gRF4UWm18mG31gUUawZdvUwULatwOl/R8qxS5ptFm/JcjmJJHx5mctFZroDpzZY bQ3xeivB9oGF1MHkPhQ2J9302/HqKlad6ir0r5ia8o2c5PA5cdQBXbl/4ull36jgLi5x LPTSH2pbsuRw0EU5nHIUk+/IjObt0QoNiaJ2t+ldAxN3GHmAzazfxkVCOFJQnDJKVKXe rX9+WjbcZpj11L8y3S+D02DFRoHzhHc5t4VAnk6sAK9C9DzfQed4VccO8Qyje8Nyfbyg Rjlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y5yTlJ8pPcUzTL39uXzcxknjDTnbo9rfBg969n/IR7k=; b=luJDH/OyGSmMekB52jOHTKP8Bfh5QlwrTb8R57JZzCA0ETR8WNP6cyhxsoX2emXibO v/oxcdrgvvqBWzOKLhLffOE35vvfbveN41lGybd0uMd28Iu8MfSij0TJyA/Gm6cXr+ey T1XA5DXmCFex/ObcQhoRDTFkJpMIkKjGOrWlnA81Z8WctjUhDYJ/MGUnoOUeLTjI3lQH alw741hrinozNjadQGt8IMn+KYr5tgpE3nYamtSLi8cWlhtkLOV08iGiGIbz8EQtemOy cjSzz/uRRuoJtty8+7qNeI6QCGE3jEmJb3YaXDChNXz3fZ/D9lLXhCkxEA+MkRpoWshy qvxw== X-Gm-Message-State: AO0yUKUPPkb2aktJDoZ3B6tNA5QKaWPHmG8FbccmwoptET/LG2kDbZJa wGhTvVJ8DCMNLm+V3HiA8lUW8uR3ZeH6bQ== X-Google-Smtp-Source: AK7set+GA9IDqzjgD6WgUs69ajEyvax4mF/T8EFp0H1F1V2AGNJ8Eg8d0kX+t81G9guNavkN8DZiSg== X-Received: by 2002:a92:907:0:b0:313:c42c:d34 with SMTP id y7-20020a920907000000b00313c42c0d34mr3698806ilg.3.1675797478221; Tue, 07 Feb 2023 11:17:58 -0800 (PST) Received: from [192.168.1.35] (c-98-224-219-15.hsd1.mi.comcast.net. [98.224.219.15]) by smtp.gmail.com with ESMTPSA id n20-20020a056638121400b003acde48bdc3sm4546168jas.111.2023.02.07.11.17.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Feb 2023 11:17:57 -0800 (PST) Message-ID: <0bf64cd1-dcfd-ce5e-1aba-a0aa47253600@gmail.com> Date: Tue, 7 Feb 2023 14:17:57 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US-large To: FFmpeg Development References: <20230202150938.22297-1-leo.izen@gmail.com> <20230202150938.22297-2-leo.izen@gmail.com> From: Leo Izen In-Reply-To: <20230202150938.22297-2-leo.izen@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/pngenc: avoid writing cICP when inappropriate X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/2/23 10:09, Leo Izen wrote: > We parse the fallback cHRM on decode and correctly determine that we > have BT.709 primaries, but unknown TRC. This causes us to write cICP > where we shouldn't. Primaries without transfer can be handled entirely > by cHRM, so we should only write cICP if we actually know the transfer > function. > > Additionally, we should avoid writing cICP if there's an ICC profile > because the spec says decoders must prioritize cICP over the ICC > profile. > Andreas has an issue with one of the other patches, but as this first one is just a fix I'll apply it soon if there's no objections. - Leo Izen (thebombzen) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".