From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 1FA734FB45 for ; Thu, 26 Jun 2025 22:51:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id D174968E696; Fri, 27 Jun 2025 01:51:02 +0300 (EEST) Received: from sender-op-o19.zoho.eu (sender-op-o19.zoho.eu [136.143.169.19]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 5DB4A68E4F8 for ; Fri, 27 Jun 2025 01:50:55 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; t=1750978253; cv=none; d=zohomail.eu; s=zohoarc; b=jj6WEYWAzfPerOfq5QHKH2gAIKhOqOQNEkrdd6SSt686rWwP2/Jv/mAytOtv3nfF0mIEdSb7WcPsh5UQvcTwZxVLE9h1qVY1CZuHNN/DRaEu0VoZkWk664Ub2DnoAFp5FOcf/cwBZNcx7z4qQr7pncSVJho6kJT2fU0Clq9q0Eo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1750978253; h=Content-Type:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Cq6UASAqQS8P5zEPSNxaeCE8z5EyvB7ZZ8uVjjpRng4=; b=JG36p2arZqdZ/4Uk6WdFL7vBjfm9XSyAN/UEP/YLOSW5FU0TUvlJXTtOigBY8bblj5scAKGT4vfJMlB49DRN9u+1fL/3C73/InVDx2ni/+x3rnrWLHG8ceSbjHOU9vkMWle/dYlNFcJMuqPQggk/6IGj0QyXErzXri7nqi7HC0k= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=frankplowman.com; spf=pass smtp.mailfrom=post@frankplowman.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1750978253; s=zmail; d=frankplowman.com; i=post@frankplowman.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Message-Id:Reply-To:Cc; bh=Cq6UASAqQS8P5zEPSNxaeCE8z5EyvB7ZZ8uVjjpRng4=; b=PVot95yy9z8MR+cNEH7UetUQWnAN9ZbLQllJCdjK54I2vAbqmI5nHW3f7hcyoUyP ViBZdj2/6Pk8U75xqqz/l25VYdCqPc4zftnV3HQ2ATy0Crpn0Vrj6Gk53M9SD+OW4Rf SK9gBBmxTatmOCJWW2+RxRwCP8T/tM2uDTvyTznc= Received: by mx.zoho.eu with SMTPS id 1750978251714126.32564702964544; Fri, 27 Jun 2025 00:50:51 +0200 (CEST) Message-ID: <0ba7d6fa-7b81-41b7-ba54-711c4c4bdac2@frankplowman.com> Date: Fri, 27 Jun 2025 07:50:48 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: ffmpeg-devel@ffmpeg.org References: <20250626214929.22563-1-epirat07@gmail.com> From: Frank Plowman In-Reply-To: <20250626214929.22563-1-epirat07@gmail.com> X-Zoho-Virus-Status: 1 X-Zoho-Virus-Status: 1 X-Zoho-AV-Stamp: zmail-av-1.4.2/250.972.80 X-ZohoMailClient: External Subject: Re: [FFmpeg-devel] [PATCH] avcodec/vvc/refs: remove dead code X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0240451989909566398==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0240451989909566398== Content-Language: en-GB Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------UDIuuaI7aN12tEBbib03liRy" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------UDIuuaI7aN12tEBbib03liRy Content-Type: multipart/mixed; boundary="------------c0IcOxlQHZr9Ay5I0AVWGxnv"; protected-headers="v1" From: Frank Plowman To: ffmpeg-devel@ffmpeg.org Message-ID: <0ba7d6fa-7b81-41b7-ba54-711c4c4bdac2@frankplowman.com> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/vvc/refs: remove dead code References: <20250626214929.22563-1-epirat07@gmail.com> In-Reply-To: <20250626214929.22563-1-epirat07@gmail.com> --------------c0IcOxlQHZr9Ay5I0AVWGxnv Content-Type: multipart/mixed; boundary="------------mlEOotG7PvaSGkvNLyBDVQ7A" --------------mlEOotG7PvaSGkvNLyBDVQ7A Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 27/06/2025 22:49, Marvin Scholz wrote: > The ret value is already checked earlier, making this condition > impossible to ever happen. >=20 > Fix CID 1648350 > --- > libavcodec/vvc/refs.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/libavcodec/vvc/refs.c b/libavcodec/vvc/refs.c > index 79967b77d3..e52cc0c10d 100644 > --- a/libavcodec/vvc/refs.c > +++ b/libavcodec/vvc/refs.c > @@ -310,8 +310,6 @@ int ff_vvc_output_frame(VVCContext *s, VVCFrameCont= ext *fc, AVFrame *out, const > ff_vvc_unref_frame(fc, frame, VVC_FRAME_FLAG_OUTPUT | = VVC_FRAME_FLAG_BUMPING); > else > ff_vvc_unref_frame(fc, frame, VVC_FRAME_FLAG_OUTPUT); > - if (ret < 0) > - return ret; > =20 > av_log(s->avctx, AV_LOG_DEBUG, > "Output frame with POC %d.\n", frame->poc); I agree there shouldn't be two checks on ret here. I am not sure this is the right one to remove however. Perhaps it is better to remove the first check and only check ret after having unreferenced the source frame, as was the behaviour prior to a8d949bd96364892903bedbbc2eef11b712e5500 ? I'm not certain, but it looks to me as though that commit might have introduced a memory leak: if av_frame_ref fails, then the source frame is never unreferenced and its data never freed. --=20 Thanks, Frank --------------mlEOotG7PvaSGkvNLyBDVQ7A Content-Type: application/pgp-keys; name="OpenPGP_0x03A84C6A098F2C6B.asc" Content-Disposition: attachment; filename="OpenPGP_0x03A84C6A098F2C6B.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEaDsehBYJKwYBBAHaRw8BAQdAtPY6tq5662mjGsrl9wixeTHtvaO/qPBio/aX SmF+pjnNJUZyYW5rIFBsb3dtYW4gPHBvc3RAZnJhbmtwbG93bWFuLmNvbT7ClgQT FgoAPgIbAQIXgAUJAeEzrBYhBDTiSNa330dpcMczBAOoTGoJjyxrBQJoOyIVBQsJ CAcCBhUKCQgLAgQWAgMBAh4BAAoJEAOoTGoJjyxrMhUBAKT3f80IXiufxCSU1rve Xp5BKwvNbY6szRdR/m21m9GAAQCGhR6t64PlMspXLtwWq9o1vjKzjWH+Bgw+UybQ CG2zDM4zBGg7HsQWCSsGAQQB2kcPAQEHQPmGNV50IFIJBy9F60ZIxe5my91pL/Sl LUWq9Z5DHBsYwsA1BBgWCgAmFiEENOJI1rffR2lwxzMEA6hMagmPLGsFAmg7HsQC GwIFCQHhM4AAgQkQA6hMagmPLGt2IAQZFgoAHRYhBEh0l9eKWUIIcnmv1LvizNAX Sd6KBQJoOx7EAAoJELvizNAXSd6KtkEBAP0jS/nBlqaVJq0iNeNDk+PnKkNBmC9p i4SuwFD71nQfAP9eWO32RXbRoIwvbrdsalWxWYmqSOdIdQE51qGMsJUuAjtIAQDA 6o6O2o2pHnWWdSqKs7Zkp4BImBD+kztmzA0Du3vJeQD/TR+qrBCXaG1FCDKn9c+Q XQNtHTxI9c6dCywjkQljOAzOOARoOyM7EgorBgEEAZdVAQUBAQdAKS1xy5312Agk deedJEXplopXco5pyANBz/edWeb7zEkDAQgHwn4EGBYKACYWIQQ04kjWt99HaXDH MwQDqExqCY8sawUCaDsjOwIbDAUJAeEzgAAKCRADqExqCY8saxvgAP9zskNI1Sti DXM4RFMoJb1aQ5TPToQZSSkGhw7JyMbLpgD/VCG7BOFjKgJGtXYEb5zpmRzNzdEB QkLsgE/vAD9GXQs=3D =3DReZ+ -----END PGP PUBLIC KEY BLOCK----- --------------mlEOotG7PvaSGkvNLyBDVQ7A-- --------------c0IcOxlQHZr9Ay5I0AVWGxnv-- --------------UDIuuaI7aN12tEBbib03liRy Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQRIdJfXillCCHJ5r9S74szQF0neigUCaF3OyAUDAAAAAAAKCRC74szQF0neiqot AP9iQQZe0QDiItFrAFeUtay4uORzCmQYdmPHf/AA3NyI3QEA4uWkLBmX7ejjUWpgz/LJWPbNdIZM BZysY48czFGWHgE= =zlsO -----END PGP SIGNATURE----- --------------UDIuuaI7aN12tEBbib03liRy-- --===============0240451989909566398== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0240451989909566398==--