From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 2E87248B34
	for <ffmpegdev@gitmailbox.com>; Wed,  3 Jan 2024 17:04:52 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B7BA668CBD1;
	Wed,  3 Jan 2024 19:04:49 +0200 (EET)
Received: from mailout12.t-online.de (mailout12.t-online.de [194.25.134.22])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8BA1568AC21
 for <ffmpeg-devel@ffmpeg.org>; Wed,  3 Jan 2024 19:04:42 +0200 (EET)
Received: from fwd70.aul.t-online.de (fwd70.aul.t-online.de [10.223.144.96])
 by mailout12.t-online.de (Postfix) with SMTP id 0EC612317D
 for <ffmpeg-devel@ffmpeg.org>; Wed,  3 Jan 2024 18:04:42 +0100 (CET)
Received: from [192.168.178.21] ([91.60.179.66]) by fwd70.t-online.de
 with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted)
 esmtp id 1rL4fV-0CqtjV0; Wed, 3 Jan 2024 18:04:37 +0100
To: ffmpeg-devel@ffmpeg.org
References: <ZZWH5w8BVTYSQ5qC@mariano>
From: Michael Koch <astroelectronic@t-online.de>
Message-ID: <0ba345a6-f5e9-0ac9-4f86-af85596ea08e@t-online.de>
Date: Wed, 3 Jan 2024 18:04:33 +0100
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <ZZWH5w8BVTYSQ5qC@mariano>
X-TOI-EXPURGATEID: 150726::1704301477-32FFA937-1BDC9CF9/0/0 CLEAN NORMAL
X-TOI-MSGID: d40e706a-20fc-4af6-9841-7d00796c1a21
Subject: Re: [FFmpeg-devel] [PATCH 2/2] doc/utils/eval: clarify meaning of
 random* seed value
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/0ba345a6-f5e9-0ac9-4f86-af85596ea08e@t-online.de/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On one hand, it's good that the 10 variables for ld() and st() are 
initialized with zero.
But on the other hand, zero is obviously the worst possible seed value 
for the random generator.

For example, make a 1000x1000 image with red color, and then fill one 
pixel at a random position with yellow color. Surprise surprise, the 
pixel is in the top left corner. That's not what a user expects from a 
random generator. It took me some time to figure out what's the problem, 
and how to set a better seed value.

Michael

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".