From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 41F9B4E1E8 for ; Sat, 7 Jun 2025 16:23:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 5682468C037; Sat, 7 Jun 2025 19:23:37 +0300 (EEST) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 458FA68BCE2 for ; Sat, 7 Jun 2025 19:23:30 +0300 (EEST) Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-450ce671a08so19186585e9.3 for ; Sat, 07 Jun 2025 09:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749313409; x=1749918209; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DgjpoOMdcOg/k3ig3tquWatvMXCiV/ORJ6CE9ja5lnQ=; b=NmJ3a7TGThR9dxvnnDUYBWo4xmL+WMakscdk0466CP/Jcj+henesyFlSVe9JX65Wt9 QuCJFu+n8jpDw2Ilm4Pgr1IteuibcL6y6evKB4NynpFcQLxe0seaO2lLs+tIt2q7yC3v z/qU2cvo7FY6H3fPV2y1FAUDomI06hkV5ypa89OgY4zqKSSmJvIDm4BRkwrTQa9yDWip lXz9YqCtdEwe/MWc/o9OZMkRkuPQyJRhvgwAZt/bY7rAHRJzuKK7nv5bBp4KVXx8nPPO WkQb2WkVWrQGYJ7ucHUdqw7o2ZCPnt0C0XduoiAIyJDs9C7CYnVMUJH0pMoEg9aZHtIV I/+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749313409; x=1749918209; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DgjpoOMdcOg/k3ig3tquWatvMXCiV/ORJ6CE9ja5lnQ=; b=S0mtAoBX7+9qRvfeXJNVMB1tofg8Ktmo5iiFnqHSN6sQve2MttUUq2/eVwSHeaNIUB m87FI7KOxP8nBvfZlcxpIxGcA4uvqS4wVLFbqvct7lKwpMXbvcPFY9UuDQgjcB2oXb1s 95Ls8xh4xdQQSN+8yRRA0CXKORkmk1fwpo2rWGQYKY6H6hPV0gYY/vje7G/P/BB0uc1R BxjhLyusQZFOtk0XXtRt2hdgn6OLcY6LIbUejZInMYfxq6xQt1N90CCH4yi+c4XnskGm MgJGXShk4mZrKntAqei8j2Yl1b0GF827/vySSQY7qVVAmCWagdD+5xT7KN3vARfuXPsl FMyg== X-Gm-Message-State: AOJu0YwkYC/0zzVHT/0Jh+yTy94FSf3qvvOQP9C24vajja7QAyU6VqJZ KHITZmteOcUHaiHNWkxXSj8ss6qAuApbYGk6WuoujabzB1ZmviPoDejYuVpvCA2o X-Gm-Gg: ASbGncu8B9QDwccCXSB272nOl+HsoTjOUXp/kzr0OwVkG+9GNk6AnRm4OF+Q1TqBYU6 A9ZtsAq4j/pfBEOskkRwyrTZEEoi94iOJnJa8H+G5s4w7KjZjpfT4TOW7YPrDTBkxrUYP2B2EiR Y3f3UGqD3YgJeorxuGhQzw1uzWjtTcrkPJ7x19ndIKWznAa7delUZW7TX9fEUf2eRHGGz7ffyNa e8/Qffs4IZm1XexeJij7s2AKKV9yg02UM90aD66HK2ghHJ8shtxAXDlTjR/FtWKnxBzMqHAPfCj BjWr4pA1TBNvvcs9+abDrWt453trIfLcRsbEMyy9gUHdSogzI/+oniB9QRJWkoKfeNi0fJc1B1M NTIJsN/19YnHst94v4O88dJw= X-Google-Smtp-Source: AGHT+IEqzgs4zUSDX3N+Y/v9PqEaxceFrh30l4ov0kK4avh5gcPghuxmU2TLSvfWFMSLPsZ9flNwGw== X-Received: by 2002:a05:600c:3b95:b0:450:d30e:ff96 with SMTP id 5b1f17b1804b1-452012b66afmr75332995e9.0.1749313408470; Sat, 07 Jun 2025 09:23:28 -0700 (PDT) Received: from [192.168.1.106] (33bf1e4c.skybroadband.com. [51.191.30.76]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-45213759fb2sm61030645e9.38.2025.06.07.09.23.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Jun 2025 09:23:27 -0700 (PDT) Message-ID: <0b9b3229-e3e7-46c3-9348-93415aae1a78@gmail.com> Date: Sat, 7 Jun 2025 17:23:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: ffmpeg-devel@ffmpeg.org References: <20250606231220.88037-1-michael@niedermayer.cc> From: Derek Buitenhuis In-Reply-To: <20250606231220.88037-1-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH] avformat/dhav: Do not evaluate avio_size() multiple times X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/7/2025 12:12 AM, Michael Niedermayer wrote: > Code like FFMIN(MAX_DURATION_BUFFER_SIZE, avio_size(s->pb)) is not safe > as FFMIN() is a macro and avio_size() is thus evaluated multiple > times > > CC: Justin Ruggles > Signed-off-by: Michael Niedermayer > --- > libavformat/dhav.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) LGTM. I don't think it is "not safe", just unexpected, though. - Derek _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".