From: Derek Buitenhuis <derek.buitenhuis-at-gmail.com@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avformat/dhav: Do not evaluate avio_size() multiple times
Date: Sat, 7 Jun 2025 17:23:26 +0100
Message-ID: <0b9b3229-e3e7-46c3-9348-93415aae1a78@gmail.com> (raw)
In-Reply-To: <20250606231220.88037-1-michael@niedermayer.cc>
On 6/7/2025 12:12 AM, Michael Niedermayer wrote:
> Code like FFMIN(MAX_DURATION_BUFFER_SIZE, avio_size(s->pb)) is not safe
> as FFMIN() is a macro and avio_size() is thus evaluated multiple
> times
>
> CC: Justin Ruggles <justinr@vimeo.com>
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> libavformat/dhav.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
LGTM.
I don't think it is "not safe", just unexpected, though.
- Derek
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-06-07 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 23:12 Michael Niedermayer
2025-06-06 23:21 ` Kieran Kunhya via ffmpeg-devel
2025-06-06 23:51 ` Michael Niedermayer
2025-06-07 16:23 ` Derek Buitenhuis [this message]
2025-06-07 17:38 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b9b3229-e3e7-46c3-9348-93415aae1a78@gmail.com \
--to=derek.buitenhuis-at-gmail.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git