From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3688D494B2 for ; Sun, 11 Feb 2024 22:38:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 842A668D0F2; Mon, 12 Feb 2024 00:38:40 +0200 (EET) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9E84368CA65 for ; Mon, 12 Feb 2024 00:38:34 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id C94BDE9F38 for ; Sun, 11 Feb 2024 23:38:33 +0100 (CET) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MRyp4F-m0eiu for ; Sun, 11 Feb 2024 23:38:30 +0100 (CET) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id C4090E9E60 for ; Sun, 11 Feb 2024 23:38:29 +0100 (CET) Date: Sun, 11 Feb 2024 23:38:29 +0100 (CET) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <170749145587.8914.1907905647574802862@lain.khirnov.net> Message-ID: <0b996495-fa12-c244-186a-821c183f247b@passwd.hu> References: <666763e4-561f-498c-85b0-e5b3c183436f@gmail.com> <20240204192812.28129-1-cus@passwd.hu> <20240204192812.28129-2-cus@passwd.hu> <170749145587.8914.1907905647574802862@lain.khirnov.net> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2 4/5] avutil/channel_layout: add av_channel_layout_retype() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 9 Feb 2024, Anton Khirnov wrote: > Quoting Marton Balint (2024-02-04 20:28:11) >> +/** >> + * Change the AVChannelOrder of a channel layout. >> + * >> + * Change of AVChannelOrder can be either lossless or lossy. In case of a >> + * lossless conversion all the channel designations and the associated channel >> + * names (if any) are kept. On a lossy conversion the channel names and channel >> + * designations might be lost depending on the capabilities of the desired >> + * AVChannelOrder. Note that some conversions are simply not possible in which >> + * case this function returns AVERROR(ENOSYS). >> + * >> + * The following conversions are supported: >> + * >> + * Any -> Custom : Always possible, always lossless. >> + * Any -> Unspecified: Always possible, lossless if channel designations >> + * are all unknown and channel names are not used, lossy otherwise. >> + * Custom -> Ambisonic : Possible if it contains ambisonic channels with >> + * optional non-diegetic channels in the end. Lossy if the channels have >> + * custom names, lossless otherwise. >> + * Custom -> Native : Possible if it contains native channels in native >> + * order. Lossy if the channels have custom names, lossless otherwise. >> + * >> + * On error this function keeps the original channel layout untouched. >> + * >> + * @param channel_layout channel layout which will be changed >> + * @param order the desired channel layout order >> + * @param flags a combination of AV_CHANNEL_LAYOUT_RETYPE_FLAG_* constants >> + * @return 0 if the conversion was successful and lossless or if the channel >> + * layout was already in the desired order >> + * 1 if the conversion was successful but lossy > > You could say 'positive number' instead of 1, which leaves us wiggle > room to use other numbers in the future in a backwards compatible way. > > Looks ok otherwise. Ok, thanks, will apply the series with that change. Regards, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".