From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E97B444B67 for ; Wed, 7 Dec 2022 05:22:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BCA9968BD13; Wed, 7 Dec 2022 07:22:23 +0200 (EET) Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7D6E068BC07 for ; Wed, 7 Dec 2022 07:22:16 +0200 (EET) Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4NRlyn208nz9sPr for ; Wed, 7 Dec 2022 06:22:09 +0100 (CET) Message-ID: <0b6b09be-15a1-b09e-d602-57bfbe891330@gyani.pro> Date: Wed, 7 Dec 2022 10:51:52 +0530 MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org References: <20221207024333.906063-1-haihao.xiang@intel.com> Content-Language: en-US From: Gyan Doshi In-Reply-To: <20221207024333.906063-1-haihao.xiang@intel.com> X-Rspamd-Queue-Id: 4NRlyn208nz9sPr Subject: Re: [FFmpeg-devel] [PATCH] lavfi/vf_scale_qsv: remove PI, PHI and E X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2022-12-07 08:13 am, Xiang, Haihao wrote: > From: Haihao Xiang > > PI, PHI and E are defined in libavutil/eval.c, and user may use these > constants for scale_qsv filter, so we needn't re-define these variables > in vf_scale_qsv.c LGTM. > > Signed-off-by: Haihao Xiang > --- > libavfilter/vf_scale_qsv.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/libavfilter/vf_scale_qsv.c b/libavfilter/vf_scale_qsv.c > index 758e730f78..fa37e95429 100644 > --- a/libavfilter/vf_scale_qsv.c > +++ b/libavfilter/vf_scale_qsv.c > @@ -44,9 +44,6 @@ > #include "video.h" > > static const char *const var_names[] = { > - "PI", > - "PHI", > - "E", > "in_w", "iw", > "in_h", "ih", > "out_w", "ow", > @@ -57,9 +54,6 @@ static const char *const var_names[] = { > }; > > enum var_name { > - VAR_PI, > - VAR_PHI, > - VAR_E, > VAR_IN_W, VAR_IW, > VAR_IN_H, VAR_IH, > VAR_OUT_W, VAR_OW, > @@ -470,9 +464,6 @@ static int qsvscale_config_props(AVFilterLink *outlink) > char *expr; > int ret; > > - var_values[VAR_PI] = M_PI; > - var_values[VAR_PHI] = M_PHI; > - var_values[VAR_E] = M_E; > var_values[VAR_IN_W] = var_values[VAR_IW] = inlink->w; > var_values[VAR_IN_H] = var_values[VAR_IH] = inlink->h; > var_values[VAR_OUT_W] = var_values[VAR_OW] = NAN; _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".