From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E88854805E for <ffmpegdev@gitmailbox.com>; Sun, 10 Dec 2023 04:01:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E663F68D0D5; Sun, 10 Dec 2023 06:01:20 +0200 (EET) Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CD01568CF9C for <ffmpeg-devel@ffmpeg.org>; Sun, 10 Dec 2023 06:01:13 +0200 (EET) Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4SnrlW2knFz9sWC for <ffmpeg-devel@ffmpeg.org>; Sun, 10 Dec 2023 05:01:11 +0100 (CET) Message-ID: <0b5d19cb-ce45-461a-a91d-93b79a873d2f@gyani.pro> Date: Sun, 10 Dec 2023 09:31:09 +0530 MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org References: <20231208073543.1907-1-ffmpeg@gyani.pro> <ZXUHSVs7YFPTqf3r@mariano> Content-Language: en-US From: Gyan Doshi <ffmpeg@gyani.pro> In-Reply-To: <ZXUHSVs7YFPTqf3r@mariano> Subject: Re: [FFmpeg-devel] [PATCH] avfilter/select: initialize prev_selected_n to NAN X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/0b5d19cb-ce45-461a-a91d-93b79a873d2f@gyani.pro/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> On 2023-12-10 06:03 am, Stefano Sabatini wrote: > On date Friday 2023-12-08 13:05:43 +0530, Gyan Doshi wrote: >> As per the doc, prev_selected_n should be NAN at the start. >> However, this was never set. >> --- >> libavfilter/f_select.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavfilter/f_select.c b/libavfilter/f_select.c >> index 47e36f0014..109dae403a 100644 >> --- a/libavfilter/f_select.c >> +++ b/libavfilter/f_select.c >> @@ -230,6 +230,7 @@ static int config_input(AVFilterLink *inlink) >> >> select->var_values[VAR_N] = 0.0; >> select->var_values[VAR_SELECTED_N] = 0.0; >> + select->var_values[VAR_PREV_SELECTED_N] = NAN; > Should be good but move it closer to the other VAR_PREV_* definitions. Done and pushed as b9fd3e7a88b326f719bd3c47d0e0cc5a435de428 Regards, Gyan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".