Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Tomas Härdin" <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] Add SMC vsynth tests
Date: Sun, 02 Jul 2023 18:39:05 +0200
Message-ID: <0aa39ebb82a58cfd61df43d192d06f59f4e2a46b.camel@haerdin.se> (raw)
In-Reply-To: <e7480867f8c347355b7498db980259b83dddf5ad.camel@haerdin.se>

[-- Attachment #1: Type: text/plain, Size: 1546 bytes --]

sön 2023-07-02 klockan 18:36 +0200 skrev Tomas Härdin:
> sön 2023-07-02 klockan 12:49 -0300 skrev James Almer:
> > On 7/2/2023 12:28 PM, Tomas Härdin wrote:
> > > 
> > > ---
> > >  tests/fate/vcodec.mak            | 3 +++
> > >  tests/ref/vsynth/vsynth1-smc     | 4 ++++
> > >  tests/ref/vsynth/vsynth2-smc     | 4 ++++
> > >  tests/ref/vsynth/vsynth3-smc     | 4 ++++
> > >  tests/ref/vsynth/vsynth_lena-smc | 4 ++++
> > >  5 files changed, 19 insertions(+)
> > >  create mode 100644 tests/ref/vsynth/vsynth1-smc
> > >  create mode 100644 tests/ref/vsynth/vsynth2-smc
> > >  create mode 100644 tests/ref/vsynth/vsynth3-smc
> > >  create mode 100644 tests/ref/vsynth/vsynth_lena-smc
> > > 
> > > diff --git a/tests/fate/vcodec.mak b/tests/fate/vcodec.mak
> > > index ef8904613a..833dde86ab 100644
> > > --- a/tests/fate/vcodec.mak
> > > +++ b/tests/fate/vcodec.mak
> > > @@ -404,6 +404,9 @@ FATE_VCODEC-$(call ENCDEC, RV20, RM)    +=
> > > rv20
> > >  fate-vsynth%-rv20:               ENCOPTS = -qscale 10
> > >  fate-vsynth%-rv20:               FMT     = rm
> > >  
> > > +FATE_VCODEC_SCALE-$(call ENCDEC, SMC, MOV) += smc
> > > +fate-vsynth%-smc:                CODEC   = smc
> > 
> > Missing a FMT = mp4 line (or mov if smc is supported in it).
> 
> It already says MOV in the call, and mp4 doesn't support SMC

Oh wait the MOV is just for deps I guess, not the actual format output.
Updated patch attached

/Tomas

[-- Attachment #2: 0001-Add-SMC-vsynth-tests.patch --]
[-- Type: text/x-patch, Size: 3140 bytes --]

From 9cb9b994a162670fbe88fa70fef38c7dd93e19c3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= <git@haerdin.se>
Date: Sun, 2 Jul 2023 16:58:11 +0200
Subject: [PATCH] Add SMC vsynth tests

---
 tests/fate/vcodec.mak            | 4 ++++
 tests/ref/vsynth/vsynth1-smc     | 4 ++++
 tests/ref/vsynth/vsynth2-smc     | 4 ++++
 tests/ref/vsynth/vsynth3-smc     | 4 ++++
 tests/ref/vsynth/vsynth_lena-smc | 4 ++++
 5 files changed, 20 insertions(+)
 create mode 100644 tests/ref/vsynth/vsynth1-smc
 create mode 100644 tests/ref/vsynth/vsynth2-smc
 create mode 100644 tests/ref/vsynth/vsynth3-smc
 create mode 100644 tests/ref/vsynth/vsynth_lena-smc

diff --git a/tests/fate/vcodec.mak b/tests/fate/vcodec.mak
index ef8904613a..2839e54de8 100644
--- a/tests/fate/vcodec.mak
+++ b/tests/fate/vcodec.mak
@@ -404,6 +404,10 @@ FATE_VCODEC-$(call ENCDEC, RV20, RM)    += rv20
 fate-vsynth%-rv20:               ENCOPTS = -qscale 10
 fate-vsynth%-rv20:               FMT     = rm
 
+FATE_VCODEC_SCALE-$(call ENCDEC, SMC, MOV) += smc
+fate-vsynth%-smc:                CODEC   = smc
+fate-vsynth%-smc:                FMT     = mov
+
 FATE_VCODEC_SCALE-$(call ENCDEC, SNOW, AVI) += snow snow-hpel
 fate-vsynth%-snow:               ENCOPTS = -qscale 2 -flags +qpel \
                                            -motion_est iter -dia_size 2      \
diff --git a/tests/ref/vsynth/vsynth1-smc b/tests/ref/vsynth/vsynth1-smc
new file mode 100644
index 0000000000..09f4bd4ce1
--- /dev/null
+++ b/tests/ref/vsynth/vsynth1-smc
@@ -0,0 +1,4 @@
+b92226742d745515732a5e7b8a03e7b7 *tests/data/fate/vsynth1-smc.mov
+4613320 tests/data/fate/vsynth1-smc.mov
+f142ee03bf9f37bb2e1902fe32366bbf *tests/data/fate/vsynth1-smc.out.rawvideo
+stddev:    8.69 PSNR: 29.34 MAXDIFF:   64 bytes:  7603200/  7603200
diff --git a/tests/ref/vsynth/vsynth2-smc b/tests/ref/vsynth/vsynth2-smc
new file mode 100644
index 0000000000..3ce6478e56
--- /dev/null
+++ b/tests/ref/vsynth/vsynth2-smc
@@ -0,0 +1,4 @@
+6e97e428fb20e96a5b8fc8a21f427504 *tests/data/fate/vsynth2-smc.mov
+3475261 tests/data/fate/vsynth2-smc.mov
+df26a524cad8ebf0cf5ba4376c5f115f *tests/data/fate/vsynth2-smc.out.rawvideo
+stddev:    7.57 PSNR: 30.54 MAXDIFF:   35 bytes:  7603200/  7603200
diff --git a/tests/ref/vsynth/vsynth3-smc b/tests/ref/vsynth/vsynth3-smc
new file mode 100644
index 0000000000..ed9efd92e2
--- /dev/null
+++ b/tests/ref/vsynth/vsynth3-smc
@@ -0,0 +1,4 @@
+e4eb9909095e02577b59004e209ad8ec *tests/data/fate/vsynth3-smc.mov
+65521 tests/data/fate/vsynth3-smc.mov
+fa6042492a3116c1ae9a32b487caa677 *tests/data/fate/vsynth3-smc.out.rawvideo
+stddev:    8.88 PSNR: 29.16 MAXDIFF:   51 bytes:    86700/    86700
diff --git a/tests/ref/vsynth/vsynth_lena-smc b/tests/ref/vsynth/vsynth_lena-smc
new file mode 100644
index 0000000000..2f9f5c1e87
--- /dev/null
+++ b/tests/ref/vsynth/vsynth_lena-smc
@@ -0,0 +1,4 @@
+037fa90a1ac659ff4dca22fb375dc7e1 *tests/data/fate/vsynth_lena-smc.mov
+3502732 tests/data/fate/vsynth_lena-smc.mov
+db453693ceae6f65c173dd716ee2662e *tests/data/fate/vsynth_lena-smc.out.rawvideo
+stddev:    8.07 PSNR: 29.99 MAXDIFF:   32 bytes:  7603200/  7603200
-- 
2.39.2


[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-07-02 16:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-02 15:28 Tomas Härdin
2023-07-02 15:49 ` James Almer
2023-07-02 16:36   ` Tomas Härdin
2023-07-02 16:39     ` Tomas Härdin [this message]
2023-07-02 18:57       ` Paul B Mahol
2023-07-02 19:17         ` Tomas Härdin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0aa39ebb82a58cfd61df43d192d06f59f4e2a46b.camel@haerdin.se \
    --to=git@haerdin.se \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git