From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 564114521C for ; Tue, 14 Feb 2023 12:51:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9AFF268BE58; Tue, 14 Feb 2023 14:51:48 +0200 (EET) Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E8CD068B851 for ; Tue, 14 Feb 2023 14:51:41 +0200 (EET) Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4PGLgb22ZKz9slt for ; Tue, 14 Feb 2023 13:51:39 +0100 (CET) Message-ID: <0a6a12ae-c903-cbe9-5503-1299bbb66201@gyani.pro> Date: Tue, 14 Feb 2023 18:21:24 +0530 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230211110251.6726-1-ffmpeg@gyani.pro> <167636912532.10789.15401506923531612364@lain.khirnov.net> From: Gyan Doshi In-Reply-To: <167636912532.10789.15401506923531612364@lain.khirnov.net> X-Rspamd-Queue-Id: 4PGLgb22ZKz9slt Subject: Re: [FFmpeg-devel] [PATCH] avformat/flvenc: allow to write qualifying metadata as number X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2023-02-14 03:35 pm, Anton Khirnov wrote: > Quoting Gyan Doshi (2023-02-11 12:02:51) >> The FLV format can store metadata as numbers which are used and handled >> by many streaming platforms. >> >> Now, metadata values can be sent as AMF Number type if >> 1) tag key starts with "num_" >> 2) value is scanned and can be represented as a double. >> >> Written tag will have "num_" prefix removed if written as AMF Number. > Using the normal metadata dict for structured data seems hacky to me. > Wouldn't it be better to add a private dict-type muxer option for this? The numerical metadata, like other string meta in FLV can change during streaming, so it will be reloaded and refreshed. Once you suggested to shift the loading metadata from file + reload options to fftools, this was the way to identify such metadata, since format contexts and AVStream only support one AVDictionary and entries will have to be commingled And this isn't really structured data. We are re-encoding how some of it is stored. It is still inputted by the user as strings. The prefix is a cheap hack to clearly identify such keys. (The other option would be add AVDictionary value 'types' and all associated signalling and tooling, which seems useful in the long run but overkill for this.) Regards, Gyan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".