From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 97CC6451F6 for ; Thu, 12 Jan 2023 04:53:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7F32D6801F2; Thu, 12 Jan 2023 06:53:21 +0200 (EET) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4795D68BD2C for ; Thu, 12 Jan 2023 06:53:14 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673499199; x=1705035199; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=5401A9YrCRYHRGXxB7RcfiKozFnyap335ZsjROKXhj0=; b=isNKRrj7KAiNUhzVUzFwHWl5cZY/LmuA4DOlN3sFQrHz29w5mezSJWY4 sZ6R0Ql4kPL1CaIivi2tAar+iD9RTjBCHYb9kOrImZQlJoox4FW8wODbF bxq9Pjtd8vIcl7JWDljIqVOVCQgX4zDsI2sM2ASfvQA2dSPdHs2ISvJWR Mz9rY6TA5+uiSCDh4kU0NRiff1ekNqxaE05pkLSerGcsowGRF+UhrP4Em swAqjrFP8ZezHv9brbkmaIHtRmVpKAPw67nWvFjj/F120BFbVfliHy7Lu VuF5eDBHM0A0jzO+0civZHbeXLpx/FPHK2hvI1uziNhlw0SeCkcw/de6I g==; X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="385923654" X-IronPort-AV: E=Sophos;i="5.96,319,1665471600"; d="scan'208";a="385923654" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2023 20:53:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="726179833" X-IronPort-AV: E=Sophos;i="5.96,319,1665471600"; d="scan'208";a="726179833" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga004.fm.intel.com with ESMTP; 11 Jan 2023 20:53:11 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 11 Jan 2023 20:53:11 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 11 Jan 2023 20:53:10 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 11 Jan 2023 20:53:10 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 11 Jan 2023 20:53:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PGXLXJ+gWBl0z+t4LypAgbPK0qhL/rehRRt2OZ+jjjqUIpmqaJteX5JXZeN19jJIKHLLXUgaSWiMK8hkZ2m2bhqNk2TZQnURuPOeYMfPgDsDwau329e4iKZf8FDsVLuN3upC7L9ldvAq3nLUxc5UmslW0yN7gj567fgiq0vHa5duTEEKPwteGZ5Ct/PI5QmS5r+pxgWpjHjQPghyiZJGtYAfCNhzIHy3xOKEcb70AV3HVdyzuTkVfl1lfV7pMrilGm3lLR9rX4CAhcOFh6htdHS5qvwiRtTDy+2B0YfMikkzVZ+2M9SxCC5oTMLD1zzcouZMjLpCprYIhW4XMJ8fXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5401A9YrCRYHRGXxB7RcfiKozFnyap335ZsjROKXhj0=; b=IXqYV3tRSq6Kbep3Y332++freHzl8WMx6LNI5Ic7x4DUEOhCgdm1vadQOLzIPG/irhLQQAtYMH1f1uVZo5M9svrF6BI8IeuwE6h6b/1Q0LJxX3YlFn4o4de04mPUffOznXOBCQgvCIjgDi7Mwqwv2ULo6zTxQcu4QcWsj4+NdZF9QRtDROSYaH/Xzd5/SOcylxaVGpu+2brOuGLsIj0ewovE+Eg/5XW8DpJ0wOsMVPXUYwRBPhWsf37jYil3ZUdgjvHPo+UIzBOGmQtzrPH3fbBHNp/1yRzqFahktmSr1Hav/6b8yY8guDbcifzgdqZu02411Lf/bpfq0KCR3t87+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by SA2PR11MB4827.namprd11.prod.outlook.com (2603:10b6:806:11f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 04:53:03 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::e3ef:177c:4008:7ee9]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::e3ef:177c:4008:7ee9%4]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 04:53:03 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH 5/8] lavfi/vf_vpp_qsv: add has_passthrough flag in VPPContext Thread-Index: AQHZJj7VZZ0u2R+uQUWYFjGp4LNMkK6aNv6A Date: Thu, 12 Jan 2023 04:53:03 +0000 Message-ID: <0a27e58c5c94e56a69f28d101ef57abc373a141e.camel@intel.com> References: <20230109071210.1829699-1-haihao.xiang@intel.com> <20230109071210.1829699-5-haihao.xiang@intel.com> In-Reply-To: Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5515:EE_|SA2PR11MB4827:EE_ x-ms-office365-filtering-correlation-id: 6f2105b9-c76d-4b89-3f3f-08daf458e33b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0bq/pn6dd/1vvFNLx1elVgmJI23G1kQfRdKESoYgairQXcN5CHc4DSZQSe/wC/lAChMmp7j+v8kmmxHL2MuyaKFjscmp6N/k5w4Ed1wyaGqufXSRUtTe3iWCGgjD0q4S5BBmrqCgWIb/ixuruwu1aHoHgOSVFRcUV4lExLT8K2pfUKChD1IzI3G2YzNdtuNxvbtbakS85YBiRrAn8rI7as4iDXUVOK3ljcuag2afla4w74w11olqUPEW+VwFzOocetVj5kgKmi0sbGU4S3BWk4urzsCAe7ty0v7Wpd+uiz77jklgeN/SiVeojHYS0jWoDblMee9FS7IZU7G4mgYDRCHBm+KLIqL7BkpODL84UnPP8f3rCvASaI7I2kkvaOK7Lx7RHK31mEe1dLDIYlKnEeuWa45M76XQYpi2ef/q4RpQ3J3P+jLRyxvroFgBkyB51z/6JmgO+E1BOWRKksgBqquJ4ej8oxP3/vh2d9aPVl1euJksR36RmVvfE2a+wCttvC64M+jsWRSTGqi0GiyQigHhvaZHztEezRC0z20OezotxqKMLmy/qEk7vaJrSG5W4ooTQx1JRq7z+stOWsnGgGrbwTu+atPhJ3EYHmkELueNj9UV5V3HxKI8LXuDzRpbOx+B1wzwnKELKLfRp15rmQN1Fe5AaVFbEzXlqDwjSYAV7iJFOEZp8gfmMDcEsnSRue0H5p8DK0hSWpbLEXgYNFSXsWp0gOlq6q8PnOCnvZQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(39860400002)(136003)(366004)(376002)(451199015)(6506007)(38100700002)(122000001)(82960400001)(2906002)(66899015)(478600001)(966005)(6486002)(2616005)(316002)(26005)(6512007)(186003)(5660300002)(71200400001)(86362001)(8936002)(83380400001)(36756003)(38070700005)(41300700001)(64756008)(91956017)(6916009)(8676002)(76116006)(66946007)(66556008)(66476007)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?U0poZkh2OXVnTjNWKzQyRkFxSExWVlU4aXJUL0F0azlFOHNaT0MvT3ZsSi85?= =?utf-8?B?WHk1aUJER1Y1SU1Id2dURkZCVVhWVGlNOUE3NG9yU1cyUXJQNjlXdHEvMUxy?= =?utf-8?B?TnFaTElzTmF4Z3FWR28zMnZ0WW5vbWNKWTJ6QktiVUd3UXErNEhBSUdNUGdB?= =?utf-8?B?aDdMaHVBTVRzUUFuZTJadjFsMm1OS2dYMnhsQXI3WW13K2hBTmdKczhwaU0r?= =?utf-8?B?ckF2M3RHMENBUkVKRCtrREwrcnI0RFZKMUYzQ0VuNE9CeHpLZDBvdEdneXp3?= =?utf-8?B?RzJheWFub292TENKR1c1Mk1tZ1VuaVNKV3o1cnQrVWdrYXlDb2ZpQUVnOTlP?= =?utf-8?B?RnhVSXlaMkZLSkZNdVVkS3B1RTVDTm5YT29ZWjRHeG9tbW9LZHI5UHQ3TWRi?= =?utf-8?B?eGQ5MFREVE85aGFIcHNJZFVqSXF3N1M2ZU9jTkY0Tk0xVHQ2c0tNdENLV3Fu?= =?utf-8?B?MC9yS0xJT2tERTRvOEVpMlNqdGxzdzF1ZVpaejhOWlAxVmIzeVVvYnJVYzhM?= =?utf-8?B?SVB2S1lrZzkyUGFwa2RrMzZIQmM1dDdkN3UyMXlabnpwT1d0U0V0clBwY2o4?= =?utf-8?B?b2RtQ2pKZ2wyc0pGQllBem5jVWhCSUJGZU9maUs3cGhZQzNRMkIrL25HS0Fx?= =?utf-8?B?S3Y5R21iNEprMEVjeEtLM2xSQkJENGxOUm9admhVR1RiZGJRNDhwYjNvZTlu?= =?utf-8?B?WWVLMlJNdkRNRUFpV3BtdHJYN29GZmdzSlpSRTlGSFNxNVNBUE1QZWlkUXJh?= =?utf-8?B?d3VvNVorZkJZQU9XempmVWlHNy9QOWkvUENyT1hDZ2tlNlgySFd0dWlGR3Fs?= =?utf-8?B?ZVpya25pU3NNdEFZS05sYlU3dGEwc2tvck1jb1h5dzZ0ZWxid1F0Q3NwOTMw?= =?utf-8?B?aHJTTWVSUzNyZkhWcENvTTVSV0JXODNLWUhLVVBpdEh4REVFUVpZazlqNEFC?= =?utf-8?B?TXpRSnpJUEVxYXpmSjUxM1BvUWNFZ3ZicWdyaHVrQ2ljRWlJMTF4T0p6eGNp?= =?utf-8?B?NVZCMkVuMjlTclA1MFhyOFhUWGR1QmZ3Sks4anpJVC9QQ3FyaE5XZDJ6Y1Qv?= =?utf-8?B?NjVDbW4yYi91YXd3dGN2VHZSTlE1OGplLy80SFRpa051UG41OGdJYUcrTWFx?= =?utf-8?B?VW1hUklUK2NTbUkycnVZUGM5YW9VVGNZZzBtMzdxWXZhaklIdTc3aHJVRkJ6?= =?utf-8?B?eHg4SStEMjZPam5qd25tN2krQndILzFCM2ErOHVqNExzTlVCY3NNaUczdU5X?= =?utf-8?B?Vk1RVEVqUi9FaUhqTjhUdEpaczhsbFRMWjUwdnB2bWY3NGZpY2ljRzFOYjRC?= =?utf-8?B?MGhuelNlS1NXTG05aDlIK3NxMStZeU1QbVdHV0JQV0M1L1VLQjJIWWNMSURK?= =?utf-8?B?bVZzbk0wZTQ3RWtlb0hsM3Zzc0M2aWZyamhuL0lLMFFhbGVnVXhPQitkZmFr?= =?utf-8?B?TFVJZHJFTWpUQkJ0RjM4a01JK3YwL0tWYyswY0E1dWNkKzBhY2Npek9KYTJN?= =?utf-8?B?TnlwVm1SK3lhTDA5R3cwcS9YZEZzMFlmRHpLdGZCZ0laaWxPOTZONlJUdWRV?= =?utf-8?B?RDJwTDFqVjhwYUlGallWeGRueFZPRHFvREsyYWxNb1o4NVgyb1g5eWQwMkh6?= =?utf-8?B?cG1Xc2RTNzM0YkY4ZTBmS2JaVVVlSGhIdHNmaG4ydlRDVm1RNXF0TXBRbXdw?= =?utf-8?B?QVlCbU1kTk9KUHRUQ2JZLytEYnhTUCtIUzFtNUx3MnNReGkvek95NWZkU0sx?= =?utf-8?B?a285S1dwV2c1bzFsbVhkNmhkUnZ5M2tQZzN0c1Q1MDBRdHQ3aldJV3JqRDNy?= =?utf-8?B?UEx5ZXJQSmxZOG05TnRLMEc4TCtSblBHZXdyM2ppTzJTendFSUY5cXpkdHo1?= =?utf-8?B?ZTRTOEMzeDRHdXE0czNuVG12T3h1L2x1cjNXdGtkQm51QWdxYmVzRmtpK3Np?= =?utf-8?B?QjYxckFIQUtpMm5jMmNJZTFnNlg2bjNKRDdYY2gxTnIrRk0rbkFDc3ZOZTYy?= =?utf-8?B?R3oxTGxCZlJIaDJWQ3g0UW0vcnZIK25OV21rQUgzdmVwYlRGM2g1dnVPQzhp?= =?utf-8?B?ek81eXJxN3JkNWRNNDdpYUhKM2ZLZXk4Njk4OVFOTmFtYmI3Z2EzQTBSd1Bo?= =?utf-8?B?YmR6OVc0NXpZT3hMZ040bk91WTVJb2R5Zjh1R2luaWRWZjJPQUM3NkZsZGh3?= =?utf-8?B?a2c9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f2105b9-c76d-4b89-3f3f-08daf458e33b X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 04:53:03.2644 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9SPGfIXLNhn/Ii2i5Qyfd08QhNOLXkDNQABzLfrs39qOmXaplzfcUobHa/Q3U6KbK5FSm1UvUs6J+og4r9Tikw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4827 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH 5/8] lavfi/vf_vpp_qsv: add has_passthrough flag in VPPContext X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Do, 2023-01-12 at 05:31 +0100, Andreas Rheinhardt wrote: > Xiang, Haihao: > > From: Haihao Xiang > > > > QSV filters may set this flag in preinit callback to turn on / off pass > > through mode > > > > This is in preparation for reusing the code for other QSV filters. E.g. > > scale_qsv filter doesn't support pass through mode. > > > > Signed-off-by: Haihao Xiang > > --- > > libavfilter/vf_vpp_qsv.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c > > index 2a7b06fa33..b04307b644 100644 > > --- a/libavfilter/vf_vpp_qsv.c > > +++ b/libavfilter/vf_vpp_qsv.c > > @@ -102,6 +102,7 @@ typedef struct VPPContext{ > > > > int async_depth; > > int eof; > > + int has_passthrough; /* apply pass through mode if possible */ > > } VPPContext; > > > > static const AVOption options[] = { > > @@ -269,6 +270,8 @@ static av_cold int vpp_preinit(AVFilterContext *ctx) > > vpp->contrast = 1.0; > > vpp->transpose = -1; > > > > + vpp->has_passthrough = 1; > > + > > return 0; > > } > > > > @@ -552,7 +555,8 @@ static int config_output(AVFilterLink *outlink) > > > > if (vpp->use_frc || vpp->use_crop || vpp->deinterlace || vpp->denoise > > || > > vpp->detail || vpp->procamp || vpp->rotate || vpp->hflip || > > - inlink->w != outlink->w || inlink->h != outlink->h || in_format != > > vpp->out_format) > > + inlink->w != outlink->w || inlink->h != outlink->h || in_format != > > vpp->out_format || > > + !vpp->has_passthrough) > > return ff_qsvvpp_create(ctx, &vpp->qsv, ¶m); > > else { > > av_log(ctx, AV_LOG_VERBOSE, "qsv vpp pass through mode.\n"); > > I don't get how this patch either. In the current patchset, > has_passthrough is always 1 (after the preinit callback) for the vpp_qsv > filter. The code here is only used by said filter and no other filter at > all, so has_passthrough is always 1 in config_output(), i.e. this whole > change is pointless. I'll reuse the above code for scale_qsv filter where pass through is not supported (a qsv session is always created in scale_qsv filter). Thanks Haihao > > - Andreas > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".