From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EB66240BDE for ; Sat, 5 Feb 2022 05:57:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4042B68B32A; Sat, 5 Feb 2022 07:57:26 +0200 (EET) Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 441AA68B1F7 for ; Sat, 5 Feb 2022 07:57:19 +0200 (EET) Received: by mail-qv1-f48.google.com with SMTP id k4so7120163qvt.6 for ; Fri, 04 Feb 2022 21:57:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=vr6ODdtcucu9HkHykYuYfSBjyxYF/Kb1GwJJVXv8whA=; b=OiqFXTTY752LtJEYB73tbs8jOIq7fa4O3VtUAeynoU4yMryghtjjtez7L3K/YYDtRf 3MCP2/zIkeCKE8Me2+AIyLfsFRyXAk1KSev5NjedfHhBPyp18Dw+lrExoUjNaRfJYu2d vOdRQ4tTAvQbpRTrNSrMPC5cElKmVVYC9i3C5ZGAt844gU+FyBzutCnweefSdJpk0bY2 fipjJxEOAr+H00G3cj98631VeGJk4EPDm8EdITC3bwnmk2ZhTYmhgf9L3+PuspMCtAGO A5U46sFkFQlE3/YeIXpaVwrBeeA4zmdrIjb3PysqepnqxI5tTKnc/wz5nPbfTyy1BjxO C2bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=vr6ODdtcucu9HkHykYuYfSBjyxYF/Kb1GwJJVXv8whA=; b=x6k192g4Aca4PY7BToBRo9QT4XQPsYHgjxym7Gh993Odk8syzv+Oa1QHjmwBpBsBnK JCWoM34JmOqaDWCqFdNNfSKweUCyQomdNdHuwm8UCHUibVtMY5a6s7dsxXlw5TwmstHx lgXEBxgu/HxkYNbW81eChtw8oXGpIlWn0/FYXJRKvnkSuIUnZsZI4zmdjtdE32ofBNje zXjuOB3BxQo7yJsaogTqpFnqdSlQXCLPGaacQqFV/LJdT/C3uecds7UWGtoZllm8RCdT EF50nm672RbwLfJdoGxMDjOFne9xXJIUPLiIGkg/8nKdR5j/8sU5mF3TDnEK/VyZ3sYy S0+A== X-Gm-Message-State: AOAM530hEyVVZz7dEzRYNTUGuQuBMYVsmayVMFqJwnczKZYQ/mR1L91i ljoVNOOwfF+VQOmreAop+JDnnx9zpk+6SQ== X-Google-Smtp-Source: ABdhPJzJr7gPzoGwWP6bVCurcYkALk1BB6p55zZXPaZXC7i1xTtTd3Z0zW5U3uDtt6G40qMJBxmv6Q== X-Received: by 2002:a05:6214:c85:: with SMTP id r5mr4293108qvr.123.1644040637713; Fri, 04 Feb 2022 21:57:17 -0800 (PST) Received: from [192.168.1.64] ([151.200.235.219]) by smtp.gmail.com with ESMTPSA id v73sm2029169qkb.51.2022.02.04.21.57.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Feb 2022 21:57:17 -0800 (PST) Message-ID: <0a20e9a5-b675-b2c3-e090-9f5e01ae97d4@gmail.com> Date: Sat, 5 Feb 2022 00:57:16 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220201212056.29712-1-scott.the.elm@gmail.com> <20220203184450.5491-1-scott.the.elm@gmail.com> <20220203184450.5491-2-scott.the.elm@gmail.com> From: Scott Theisen In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v2 01/13] avcodec/internal.h: create avpriv_start_code_is_valid() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/5/22 00:42, Andreas Rheinhardt wrote: > a) We use the avpriv prefix for things that should be exported from one > library to be used in other libraries, but not for public use. Therefore > the avpriv prefix is inappropriate here as this function is static. And > it makes a very long name. So since this is static av_always_inline, it should just be start_code_is_valid()? > b) internal.h is the wrong header for this: There are more start codes > than 00 00 01. That's why I sent the patch to move > avpriv_find_start_code() to libavcodec/startcode.h. I only put it there because that is where avpriv_find_start_code() is declared, so I knew it was already included. Should I move the definition and declaration of avpriv_find_start_code() to startcode.(c|h)? > c) I am not sure that the new code is equivalent to the old one in all > instances: mpeg12dec.c checks for "start_code > 0x1ff" to mean "no valid > start code", yet if the buffer ended with anything in the range > 0x00-0xff it would be considered a start code before this patch and now > it would no longer be a start code. I don't think this is a bad change, > though, but it should be noted in the commit message. I'll have to look at them all again and I'll add that to the commit message. -Scott _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".