From: "Rémi Denis-Courmont" <remi@remlab.net>
To: FFmpeg development discussions and patches
<ffmpeg-devel@ffmpeg.org>,
Michael Niedermayer <michael@niedermayer.cc>
Subject: Re: [FFmpeg-devel] [PATCH 2/5] avcodec/dstdec: Check for overflow in build_filter()
Date: Sun, 11 Sep 2022 09:51:15 +0200
Message-ID: <0F896A11-EFBB-4635-A65E-285C45817BDB@remlab.net> (raw)
In-Reply-To: <20220910223046.5135-2-michael@niedermayer.cc>
Hi,
Down-casting to a signed type (here, int16_t) is implementation-defined. And while normal compilers do the expected thing, with modulo-2^n complement, sanitizers tend to dislike it.
AFAIK, the clean solution is via an union whence you assign the uint16_t member, and then read the int16_t member. Fortunately, GCC and LLVM are able to optimise that construct back to a single sign-extension.
Br,
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-09-11 7:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-10 22:30 [FFmpeg-devel] [PATCH 1/5] avcodec/apedec: Fix integer overflow in filter_3800() Michael Niedermayer
2022-09-10 22:30 ` [FFmpeg-devel] [PATCH 2/5] avcodec/dstdec: Check for overflow in build_filter() Michael Niedermayer
2022-09-11 7:51 ` Rémi Denis-Courmont [this message]
2022-09-11 8:21 ` Andreas Rheinhardt
2022-09-10 22:30 ` [FFmpeg-devel] [PATCH 3/5] avcodec/exr: Check preview psize Michael Niedermayer
2022-09-16 17:52 ` Michael Niedermayer
2022-09-10 22:30 ` [FFmpeg-devel] [PATCH 4/5] avcodec/mobiclip: Check quantizer for overflow Michael Niedermayer
2022-09-16 17:55 ` Michael Niedermayer
2022-09-10 22:30 ` [FFmpeg-devel] [PATCH 5/5] avcodec/tta: Check 24bit scaling " Michael Niedermayer
2022-09-16 17:56 ` Michael Niedermayer
2022-09-16 17:57 ` [FFmpeg-devel] [PATCH 1/5] avcodec/apedec: Fix integer overflow in filter_3800() Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0F896A11-EFBB-4635-A65E-285C45817BDB@remlab.net \
--to=remi@remlab.net \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=michael@niedermayer.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git