[FFmpeg-devel] [PATCH 2/2] avformat/whip: Constify arguments in is_rtp_rtcp/is_rtcp

[FFmpeg-devel] [PATCH 2/2] avformat/whip: Constify arguments in is_rtp_rtcp/is_rtcp

[Zhao Zhili]

From: Zhao Zhili <zhilizhao@tencent.com>

Fix warning of -Wincompatible-pointer-types-discards-qualifiers.
---
 libavformat/whip.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavformat/whip.c b/libavformat/whip.c
index 0671e23635..710f24fc5a 100644
--- a/libavformat/whip.c
+++ b/libavformat/whip.c
@@ -1115,13 +1115,13 @@ static int ice_is_binding_response(uint8_t *b, int size)
  * The RTCP packet header is similar to RTP,
  * see https://www.rfc-editor.org/rfc/rfc3550#section-6.4.1
  */
-static int media_is_rtp_rtcp(uint8_t *b, int size)
+static int media_is_rtp_rtcp(const uint8_t *b, int size)
 {
     return size >= WHIP_RTP_HEADER_SIZE && (b[0] & 0xC0) == 0x80;
 }
 
 /* Whether the packet is RTCP. */
-static int media_is_rtcp(uint8_t *b, int size)
+static int media_is_rtcp(const uint8_t *b, int size)
 {
     return size >= WHIP_RTP_HEADER_SIZE && b[1] >= WHIP_RTCP_PT_START && b[1] <= WHIP_RTCP_PT_END;
 }
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] avformat/whip: Constify arguments in is_rtp_rtcp/is_rtcp

[Jack Lau]

> On Jun 5, 2025, at 17:41, Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org> wrote:
> 
> From: Zhao Zhili <zhilizhao@tencent.com>
> 
> Fix warning of -Wincompatible-pointer-types-discards-qualifiers.
> ---
> libavformat/whip.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavformat/whip.c b/libavformat/whip.c
> index 0671e23635..710f24fc5a 100644
> --- a/libavformat/whip.c
> +++ b/libavformat/whip.c
> @@ -1115,13 +1115,13 @@ static int ice_is_binding_response(uint8_t *b, int size)
>  * The RTCP packet header is similar to RTP,
>  * see https://www.rfc-editor.org/rfc/rfc3550#section-6.4.1
>  */
> -static int media_is_rtp_rtcp(uint8_t *b, int size)
> +static int media_is_rtp_rtcp(const uint8_t *b, int size)
> {
>     return size >= WHIP_RTP_HEADER_SIZE && (b[0] & 0xC0) == 0x80;
> }
> 
> /* Whether the packet is RTCP. */
> -static int media_is_rtcp(uint8_t *b, int size)
> +static int media_is_rtcp(const uint8_t *b, int size)
> {
>     return size >= WHIP_RTP_HEADER_SIZE && b[1] >= WHIP_RTCP_PT_START && b[1] <= WHIP_RTCP_PT_END;
> }
> -- 
> 2.25.1
LGTM

Thanks
Jack
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".