From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4C17F4980D for ; Mon, 19 Feb 2024 22:19:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2BEB568D430; Tue, 20 Feb 2024 00:19:46 +0200 (EET) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D396C68CBF7 for ; Tue, 20 Feb 2024 00:19:39 +0200 (EET) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6e3bdea186cso689643b3a.3 for ; Mon, 19 Feb 2024 14:19:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708381177; x=1708985977; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Q57X3tMIP0AF6Ns8UIAODPKvpdQCvJptiABrzDzmU10=; b=UF7eZfnt3cszQXkHEl9Y/H6Ub9ehnoGCF1QF5JXzkPP95jOxARg3acDGPewe0j8cA+ 60PFmq36lMr/+UHRlMAqF2PY3Q9iG8l5dPpUKLAnONmGjixasftqt9j5HwsjH/37k6S6 Zktiy8bOSSqRJm5U/E390QxDMBobuETKJsEhw+sWTnR3r0q2EZsMC6ueBdV/wMUMJKKV /zu9PM4mjqD8wBHcXy7/nEjiGn0vTVBvMZRd+0zqBAt8msb9b4dcP5dklB6i9GiHa8CS KVoIvJK5MEwDdZxJBLoLtplRn2VMxIQsfyHxc+3XUzIzDisRzw7gpVKMTVHIlpIcHl3T idJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708381177; x=1708985977; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q57X3tMIP0AF6Ns8UIAODPKvpdQCvJptiABrzDzmU10=; b=nk2VWLU1RjqO/I0sCj7TeTZ95oFoz78/sD7LVBA/o6ZMSn4BlTWgnHgITZUUXCIkY2 YG1v8RxPeFtW9cl4XNkRlhG3vC9O3Ca3F7lJkdola6AFpCzkUDVlI2VKoa1BqMeK6Ylo M1YkHJEDnVygg9tXFozIxF1fljJ6NVJwFWntEAjLaktkO0ZO5t+W9fZppXTRkNMDeSh4 QtA35lMqT0frOrjF54i3uS0mGGxir8HXSUAphGRdyuBuRLn7ksNQ/XN77lVF7XtcReOt vjnakOkbJ8kL4/sGdQn8NE/kxun/9QLVPoEdiaE4+HvWN9takUi6/aqcl0El3+fjeVbJ J6tg== X-Gm-Message-State: AOJu0YwkJgkOQa1IySYIkCwMuA3/TfmLUBS898NhbEa34KmBA2I59prE OsSpf8JrDYXIwKHrOcRP6bzCet5+40idAk7IEvmjHshsDwE/9pmLdrzWG2YV X-Google-Smtp-Source: AGHT+IGb6dc/S5LVhmsrcpGWKFKpCuKzS/nG6CXIIQ0Jbyh90XIwQECVjMONxzsCtDcaB8nyUwGrFA== X-Received: by 2002:a05:6a20:7a28:b0:19e:a9fe:7461 with SMTP id t40-20020a056a207a2800b0019ea9fe7461mr9063273pzh.33.1708381177220; Mon, 19 Feb 2024 14:19:37 -0800 (PST) Received: from [192.168.0.16] ([190.194.169.124]) by smtp.gmail.com with ESMTPSA id q13-20020a056a00088d00b006e05c801748sm5322736pfj.199.2024.02.19.14.19.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Feb 2024 14:19:36 -0800 (PST) Message-ID: <098b325e-e41e-4ca3-ab9d-fdc928021742@gmail.com> Date: Mon, 19 Feb 2024 19:19:40 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/5] avformat/iamf_writer: Don't leak on error when adding ParamDefinition X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/19/2024 6:51 PM, Andreas Rheinhardt wrote: > Fix this by postponing the allocation. > Fixes Coverity issue #1559545. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/iamf_writer.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c > index 1a360dee2f..897b06310f 100644 > --- a/libavformat/iamf_writer.c > +++ b/libavformat/iamf_writer.c > @@ -138,10 +138,6 @@ static IAMFParamDefinition *add_param_definition(IAMFContext *iamf, AVIAMFParamD > > iamf->param_definitions = tmp; > > - param_definition = av_mallocz(sizeof(*param_definition)); > - if (!param_definition) > - return NULL; > - > if (audio_element) > codec_config = iamf->codec_configs[audio_element->codec_config_id]; > > @@ -160,6 +156,10 @@ static IAMFParamDefinition *add_param_definition(IAMFContext *iamf, AVIAMFParamD > param->constant_subblock_duration = codec_config->nb_samples; > } > > + param_definition = av_mallocz(sizeof(*param_definition)); > + if (!param_definition) > + return NULL; > + > param_definition->mode = !!param->duration; > param_definition->param = param; > param_definition->audio_element = audio_element; LGTM _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".