From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C94524A533 for ; Fri, 29 Mar 2024 15:34:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7049868D742; Fri, 29 Mar 2024 17:33:56 +0200 (EET) Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1ECCB68D732 for ; Fri, 29 Mar 2024 17:33:50 +0200 (EET) Received: by mail-oo1-f49.google.com with SMTP id 006d021491bc7-5a4f9f94e77so1264186eaf.3 for ; Fri, 29 Mar 2024 08:33:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711726428; x=1712331228; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=gObXYgPFtfinj4IcG2ZDuYgjtf79Nqi7kO3+ghEfJiI=; b=YLI+39F7vOgnmlYrVJELFrm4HxyWvM3rAH77IQfUQEPn6kcIBQjuFUDVCQSfD9NUOO 8X5PU+l0+IIFbFDW6R+eLslk6fRETOq29eUM/ZD8ijiNw/dJIRuj8o53EdyC5nDXz1zd kfisDPHYbZ7jo5CI46w26k/Twm5JwAwWtHk0KW/TQ8pvtQu0hkr8i44i05gjnnEbp4Ul Z2KOXic9YiynFeDtBSXnzz2oEqAXBum+krpMgzWN1wdmgGOwzmx9VZx23xW+UV2cJ65f 5dLwTOtdiwSMq+inZ4+HXXWvvnaicZpaSUo4PwSU6AulShy5sJExm+vFaH5bZVK1yPFL 00Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711726428; x=1712331228; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gObXYgPFtfinj4IcG2ZDuYgjtf79Nqi7kO3+ghEfJiI=; b=f6C6DXe4g2P5084olyWPIj2H4/3dBFZio7e7USRoyX1kXKNTsoHjX1w5oygL3KCmFE ExMa7kpPmlPVBem7NsisS1CX9B9guiXbHay+dKnMBhDXczGDOVB5ljDCEs0CpId4lnKd KlzEZXQPeRpoigO7UyEG4TBTcRa+rYK56K/xHNzoW+alhYtEnyT6PG8PWdu5mb//ueI3 BVTm+yC24NhpoWcVE+RI5x24nzzUU2ekRhZY8rjpzUG2IzcBPmgJmahHrrrb8kAOvMac dDMzXL6OsjbUy58iJ8QDHnxhEJWmZXNXqXy4qLuYKwUlT3vsEx8PDWgU89H6m0xH2ec+ HkSg== X-Forwarded-Encrypted: i=1; AJvYcCViNPNM3QR2uiaRqg7mJ2gvPjuxHaCa/SsXLgfZZUEnl1+nBniRiWSUIV4xXJWON1x8roOeUFxzcX26GL1/5hrR4C9agCyvDQ== X-Gm-Message-State: AOJu0Yxcu8eKrg1MWmbzVJVXg3aisAxbLXB2MvTBP1+dLzzS7HyMsVBQ uXxY46Va8a0XF3oc1N9wL6Vk/ksOY+2dGl6trSbAaya6IerKG/NVIU35AuXv X-Google-Smtp-Source: AGHT+IG35tOq2B7qgC5rz5VpJRHTqPz73Ke83Xh9Q7pj+cGhPImgxwKsG11bX8q54eC728hscfKcNg== X-Received: by 2002:a05:6358:4291:b0:17b:b559:2ba3 with SMTP id s17-20020a056358429100b0017bb5592ba3mr2939655rwc.11.1711726428394; Fri, 29 Mar 2024 08:33:48 -0700 (PDT) Received: from [192.168.0.15] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id fm26-20020a056a002f9a00b006e5360f1cffsm3159673pfb.180.2024.03.29.08.33.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Mar 2024 08:33:47 -0700 (PDT) Message-ID: <0986c014-2236-4028-9393-a0cd518e8450@gmail.com> Date: Fri, 29 Mar 2024 12:33:53 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: tong1.wu@intel.com, ffmpeg-devel@ffmpeg.org References: <20240329153120.1210-1-tong1.wu@intel.com> Content-Language: en-US From: James Almer In-Reply-To: <20240329153120.1210-1-tong1.wu@intel.com> Subject: Re: [FFmpeg-devel] [PATCH v3] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/29/2024 12:31 PM, tong1.wu@intel.com wrote: > From: Tong Wu > > HEVCHdrParams* receives a pointer which points to a dynamically > allocated memory block. It causes the memcmp always returning 1. > Add a function to do the comparision. A condition is also added to > avoid malloc(0). > > Reviewed-by: James Almer > Signed-off-by: Tong Wu > --- > libavcodec/hevc_ps.c | 19 +++++++++++++++---- > libavcodec/hevc_ps.h | 4 +++- > 2 files changed, 18 insertions(+), 5 deletions(-) LGTM. Will apply. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".