Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Dave Rice via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Jerome Martinez <jerome@mediaarea.net>, Dave Rice <dave@dericed.com>
Subject: [FFmpeg-devel] Re: [PATCH 0/7] matroska: support of timecode
Date: Thu, 11 Sep 2025 11:52:42 -0400
Message-ID: <0972F0D6-8D2F-423A-A0ED-32CC0610074D@dericed.com> (raw)
In-Reply-To: <d65a0f50-3766-4539-b140-55d7ac12810d@mediaarea.net>


> On Sep 9, 2025, at 8:37 AM, Jerome Martinez via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
> 
> This patch series adds support of timecode in Matroska files, specs are at:
> https://github.com/ietf-wg-cellar/matroska-specification/blob/master/cellar-codec/block_additional_mappings/smpte-st12-1-timecode.md
> 
> As ST 12-1 support was already partially implemented, using 32 bits rather than 64 bits (binary groups were not stored), the ST 12-1 side data format was changed from 32 bits to 64 bits rather than introducing another ST  12-1 side data internal "format", this may break code using it but not in the main repo (I found nothing using it in the main repo), is it fine?
> If we keep internally 32 bits for ST 12-1, any non zero timecode binary group stored in MKVs would be trashed.
> 
> The first 3 patches refactor BlockAddition support in MKV encoder in order to have it more versatile
> The 2 next patches adapt decklink_dec for writing 64 bit timecodes in side data rather than 32 bit timecodes
> The last 2 patches adds timecode support in Matroska

Tested with a decklink input with `./ffmpeg -y -f decklink -timecode_format rp188any -audio_input embedded -video_input sdi -format_code ntsc -i "UltraStudio 4K Mini" -c copy -t 1 output6.mkv`. Output includes the timecode values stored in Block Additionals. This is great!

Also noting that the timecode side data only seems to travel with streamcopy. If I switch the `-c ffv1` the side data is lost.

Kind Regards,
Dave

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

      parent reply	other threads:[~2025-09-11 15:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09 12:37 [FFmpeg-devel] " Jerome Martinez via ffmpeg-devel
2025-09-09 12:38 ` [FFmpeg-devel] [PATCH 1/7] matroskaenc: remove unused MaxBlockAdditionID Jerome Martinez via ffmpeg-devel
2025-09-09 12:39 ` [FFmpeg-devel] [PATCH 2/7] matroskaenc: reserve_video_track_space option Jerome Martinez via ffmpeg-devel
2025-09-09 12:39 ` [FFmpeg-devel] [PATCH 3/7] matroskaenc: increase default for reserved bytes in video Jerome Martinez via ffmpeg-devel
2025-09-09 12:40 ` [FFmpeg-devel] [PATCH 4/7] 32-bit timecode to 64-bit RFC 5484 timecode functions Jerome Martinez via ffmpeg-devel
2025-09-09 12:41 ` [FFmpeg-devel] [PATCH 5/7] decklink_dec: store timecode in 64-bit RFC 5484 format Jerome Martinez via ffmpeg-devel
2025-09-09 12:41 ` [FFmpeg-devel] [PATCH 6/7] matroskadec: read timecode in BlockAddition Jerome Martinez via ffmpeg-devel
2025-09-09 12:41 ` [FFmpeg-devel] [PATCH 7/7] matroskaenc: write " Jerome Martinez via ffmpeg-devel
2025-09-11 15:52 ` Dave Rice via ffmpeg-devel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0972F0D6-8D2F-423A-A0ED-32CC0610074D@dericed.com \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=dave@dericed.com \
    --cc=jerome@mediaarea.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git