From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9E63742894 for ; Tue, 5 Apr 2022 13:57:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 85FFD68B181; Tue, 5 Apr 2022 16:57:32 +0300 (EEST) Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 272EB6881B1 for ; Tue, 5 Apr 2022 16:57:26 +0300 (EEST) Received: by mail-oi1-f176.google.com with SMTP id w127so13451881oig.10 for ; Tue, 05 Apr 2022 06:57:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=i/eTSFhI85v0ySjAKbbCwnXy1+wpjnkr0ympTi4JPFM=; b=UjkV+eu9WKaR2fSOnqbgh9xbNH7eZwmy/HmtpTmasvg/fjGGqrESeUtvDPlM4YcTqT YiOKG0rUpk9JuIzLsgJsQKuSU6PQyXy5y231/SCpmY087q/6059NIzbDnNQcbSWd/srK jwAlHCvdJEaNnXX46SMEdU2XIEXDEaKYVJtzC9snK/D0bVDs4iluPfgJIBKhtcOutgvV 1I+duBL8JMv42YO8IwL8EnOSqhbaf3PDDemWkIcruh+ImPrkucgMnn8PXwGEiR9hA4iX wfBhZ9+09nhtzZgntUp3ZGsYsOGEUiyl5NesYmrzmRp+aSMlG9nw0Bgb3YTRFpqiEg+Z PFDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=i/eTSFhI85v0ySjAKbbCwnXy1+wpjnkr0ympTi4JPFM=; b=ZMYxDpaoTVMgPLKzbx4ZmwGGLChHLB4tQhGYJAOBe//Ou8dAR7Qbab3cDdKy0B8Tiy rtY5ztLlatumeZBaTCMT44Pi/a78B5IfckrltclmbfR/iffQ0GRnsYI81T0Ja+BSjRvI hl2LqDFsVHyNRYVSInrOxoRry05bSPssOybtjNdl9ruqpv9tlnHjwkDXaw4cUOlo5r0H pMO/aA4ermf6KuR8tRBm3VkT/w+NFlnRw7s5zklyjBcZcYTnNQlWi9eskluAF3fjFhXB NtBqzCGC1w4wH/GvStVgGFaCV9ZimbvPtszjy7K4RkZ1yQxfv0uI+LvayjJIEyp+tK3d D3PA== X-Gm-Message-State: AOAM530p7VFfSFONQQjL76SUjcr+pTAFAf0yuB3Dbkyc6TkCoG+t2l5f EY5nF41HD5xLdGB7WARAeYzIMreIUUMIRA== X-Google-Smtp-Source: ABdhPJx45HpCC2WQsfsdjaAMjL3sftZRkY9wqjaysY6WrD9sls1krur9gDIVnMnwBwDtMEpE4zQCLw== X-Received: by 2002:a05:6808:14cf:b0:2d9:dcc6:8792 with SMTP id f15-20020a05680814cf00b002d9dcc68792mr1528468oiw.219.1649167043108; Tue, 05 Apr 2022 06:57:23 -0700 (PDT) Received: from [192.168.0.12] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id m5-20020a056870194500b000d9a0818925sm5295850oak.25.2022.04.05.06.57.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Apr 2022 06:57:22 -0700 (PDT) Message-ID: <093841fd-5360-1f93-309d-f9cdf1643613@gmail.com> Date: Tue, 5 Apr 2022 10:57:26 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220324172524.1191986-1-danilchap@google.com> <164915298959.21047.64072881760748019@lain.red.khirnov.net> <20220405121539.1773869-1-danilchap@google.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: return quantizer parameter for an encoded frame X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/5/2022 10:55 AM, Lynne wrote: > 5 Apr 2022, 14:15 by danilchap-at-google.com@ffmpeg.org: > >> --- >> libavcodec/libvpxenc.c | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c >> index dff1d06b0e..0705863450 100644 >> --- a/libavcodec/libvpxenc.c >> +++ b/libavcodec/libvpxenc.c >> @@ -1250,6 +1250,8 @@ static int storeframe(AVCodecContext *avctx, struct FrameListData *cx_frame, >> int ret = ff_get_encode_buffer(avctx, pkt, cx_frame->sz, 0); >> uint8_t *side_data; >> int pict_type; >> + int quality; >> + VPxContext *ctx = avctx->priv_data; >> >> if (ret < 0) >> return ret; >> @@ -1264,7 +1266,12 @@ static int storeframe(AVCodecContext *avctx, struct FrameListData *cx_frame, >> pict_type = AV_PICTURE_TYPE_P; >> } >> >> - ff_side_data_set_encoder_stats(pkt, 0, cx_frame->sse + 1, >> + ret = vpx_codec_control(&ctx->encoder, VP8E_GET_LAST_QUANTIZER_64, &quality); >> + if (ret != VPX_CODEC_OK) { >> + quality = 0; >> + } >> > > Fix the coding style. You could just say to remove the brackets for one line statements. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".