From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1E147400D4 for ; Sun, 19 Dec 2021 17:09:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3A150688132; Sun, 19 Dec 2021 19:09:45 +0200 (EET) Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 26B93688132 for ; Sun, 19 Dec 2021 19:09:38 +0200 (EET) Received: by mail-qt1-f171.google.com with SMTP id p19so7723764qtw.12 for ; Sun, 19 Dec 2021 09:09:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=jymlqJunPI0/tSEvuMUmyNy4QNpCLcrMdiyArm1lmSw=; b=CNDb9Kl8EkzF3gEaDlUBsh4nyNw2+VQL38AOn38zppoN5MmfZrGf1ZOkP1kEha3Rnx QNK+YGJDtFGxR/+gQmf4fg5jW7qGz7yOcR9bMMKdVxF17pNGpu7d0ELk8JAW7h1MV+cd r9nUCNXdkUnvkWUVMGv1aTtB7nlOeOTT9xJaqOqbv+qgSa6TuY/EOH2HBj8NIBwHhumK hNuhPmsqbNGH5bjiXJb5qyNoICyjT1fCZ6rjsSHJIxOBT+pALonzaIG9pfy2Jet6Ct49 NPgr5WrphA/IXwYQwyAnzEZ7yRRQHRX97onm2jYrA6EUZui4JU/jBm1AxvalPTf+VM/e C/Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=jymlqJunPI0/tSEvuMUmyNy4QNpCLcrMdiyArm1lmSw=; b=i1IZeyktr45ECIWBSTQ0rUDRzKxAthcmqEbSrsFqlGXG8UZppQZkb8qdMw3VKxoWWV Y1jta4k0eC3EqVBAjIYwJ+RIXrmMsGct+tCON7XeEwpT0vYZ8MY03WQ0XLWBz70zGtK1 0tPc4IummRRHXSZqNSujn/B0MJdR4e4CDBANxckEjhSxL2bGSPaGheNgY9svepQ2aMRR VlM1QrqYQToBHTBKuysHSI41HKr5vixpCtSK4Ujb6HoGiYK69m9YEut3Bg9upxJ1eooB FB9zR1JAYQRg4IPWU9ir96blsV4Jy8aCXgZwV1/2t2zi07cmd5dpp536wQ9+4lsQy0tr 6U7A== X-Gm-Message-State: AOAM5306ZRxVoKDVzNTJz/w7f2Q0m7UsKrz852JENEwVWTf72ENRhqu4 Qp58n3POrQDeSPj1vRytAlY5DqzaYYg= X-Google-Smtp-Source: ABdhPJy5UBFcHyYfAsSNhs56K1At3cUeZyPLqvsOnmRcxBUA3a3d9qf7iZGA6wZwLn1Y9e27U77AcQ== X-Received: by 2002:a05:622a:164b:: with SMTP id y11mr9517712qtj.621.1639933776412; Sun, 19 Dec 2021 09:09:36 -0800 (PST) Received: from [192.168.1.55] ([191.83.210.83]) by smtp.gmail.com with ESMTPSA id i23sm9391189qkl.101.2021.12.19.09.09.35 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Dec 2021 09:09:35 -0800 (PST) Message-ID: <08de8d98-1b78-07c4-3b07-c4619635c610@gmail.com> Date: Sun, 19 Dec 2021 14:09:33 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20211217200418.68942-1-ffmpeg@tmm1.net> <20211217200418.68942-3-ffmpeg@tmm1.net> From: James Almer In-Reply-To: <20211217200418.68942-3-ffmpeg@tmm1.net> Subject: Re: [FFmpeg-devel] [PATCH v4 3/5] avutil: add obj-c helpers into header-only include X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 12/17/2021 5:04 PM, Aman Karmani wrote: > From: Aman Karmani > > Reviewed-by: Ridley Combs > Signed-off-by: Aman Karmani > --- > libavutil/objc.h | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 libavutil/objc.h > > diff --git a/libavutil/objc.h b/libavutil/objc.h > new file mode 100644 > index 0000000000..0db993f716 > --- /dev/null > +++ b/libavutil/objc.h > @@ -0,0 +1,32 @@ > +/* > + * This file is part of FFmpeg. > + * > + * FFmpeg is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * FFmpeg is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with FFmpeg; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA > + */ > + > +#ifndef AVUTIL_OBJC_H > +#define AVUTIL_OBJC_H > + > +#include > + > +static inline void ff_objc_release(NSObject **obj) > +{ > + if (*obj) { > + [*obj release]; > + *obj = nil; > + } > +} > + > +#endif /* AVUTIL_OBJC_H */ This breaks checkheaders. It should be added to SKIPHEADERS with the corresponding check. Also, why is this in lavu if it's ultimately only used in lavfi? And does it need to be a separate header at all? It's apparently not even C. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".