From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 980CC461F3 for ; Fri, 9 Jun 2023 02:44:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9A8E268C2F5; Fri, 9 Jun 2023 05:44:32 +0300 (EEST) Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 19ECC68BE7B for ; Fri, 9 Jun 2023 05:44:26 +0300 (EEST) Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-1a2c9f087f0so303251fac.3 for ; Thu, 08 Jun 2023 19:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686278664; x=1688870664; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=wRgEzEAeMk8HUeWDGwdEMVx3xln6FCVzlGYM065fEe4=; b=DQ8vFbZBkQAy6WTmMdyH0NUUnBbEET+ddbZfpoRg6blI2uWbLFNSSwv9AAK46i094U Ih35jC/hxTlNLIuxjN0+M9bGixXAkEZWe13dONMdA+dTTr06j3NrNWRL1WfqGpPySYRU zERYDGnt7h4/aFyAD0zL5k5xtaKdfB2YJAAawdmdg8xNqOejSlJHOaznX4yleEur7y/k rtjDgpEaETKchpmBbwMCnGIeB5cWxmUxoBpdO8PQUxa29AbIMtQB/UqxI/4olmp9pDPz 1DEh7M6b+oHmnXr9VDCygWUbiuBTKxi3VX32YqTF/IAXwsHRBheI66PyMFELDWiqpKt2 AMXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686278664; x=1688870664; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wRgEzEAeMk8HUeWDGwdEMVx3xln6FCVzlGYM065fEe4=; b=U71wV3AUtr+R3Uz95keOsBTp2JKUZknu7vO7D6xz4GLHP9Tu7JGfPCOFOwAnQso3Yk IEJ02DHQaRiY9UO7v6VdcqDUbv0ZfbH8RzruN3BNomzbo+7DMMduOXZiHeRUMs4KfB8X 9JgHpAjCnbfzGJ+PkZHbE45BDxEW0fLxaiLwIOVqCzZTBeR3j6slIXuVMIgeD6nEtymM IOnhzAN/GGiML+ISPBa0Xj0ztqJFnOStN12OEXydaqduuZe0OM7D09beyxNgU9mWj0xz B1uTSK8wih7LnIZV+S0q87egQNPF/Edoebn6Y7pzItaPZ8lQrWTFGNnUY291VwK34RFN NnPw== X-Gm-Message-State: AC+VfDygyMbT8znWcN5smaGzV24PyQUar9as3IhwPISVB12ZSkC9a/8r LPr4Dph9J5DyUbW6QrgzJ8RfqMblBQM= X-Google-Smtp-Source: ACHHUZ5eVG2/S4Rh3dT0keE4Hjne5zqzGWvr7ya5faiV3m5x6cmcZufS4Mk84iL5Cy4k0Y5jpax+OQ== X-Received: by 2002:a05:6870:73c4:b0:18e:db44:b81b with SMTP id a4-20020a05687073c400b0018edb44b81bmr219568oan.46.1686278664039; Thu, 08 Jun 2023 19:44:24 -0700 (PDT) Received: from [192.168.0.12] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id l22-20020a05687014d600b0019e6f81740fsm1594791oab.30.2023.06.08.19.44.23 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jun 2023 19:44:23 -0700 (PDT) Message-ID: <08c957d8-5cae-384f-a345-a0174d06677e@gmail.com> Date: Thu, 8 Jun 2023 23:44:38 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 To: ffmpeg-devel@ffmpeg.org References: <20230608142637.45033-1-leo.izen@gmail.com> <20230608142637.45033-5-leo.izen@gmail.com> <168627796328.3843.8714735093481005983@lain.khirnov.net> Content-Language: en-US From: James Almer In-Reply-To: <168627796328.3843.8714735093481005983@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 4/5] avformat/jpegxl_probe: inline various ret < 0 checks X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/8/2023 11:32 PM, Anton Khirnov wrote: > Quoting Leo Izen (2023-06-08 16:26:36) >> Inlines some ret < 0 checks to look like: >> if ((ret = func()) < 0) >> return ret; >> >> which clarifies code slightly. > > FWIW I find this variant less readable. > But it's your code, so up to you. Agree. It's both less readable and more prone to mistakes. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".