From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id EA8474E67E for ; Mon, 5 May 2025 20:59:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E704668B926; Mon, 5 May 2025 23:59:51 +0300 (EEST) Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8B085687A17 for ; Mon, 5 May 2025 23:59:45 +0300 (EEST) Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43cebe06e9eso30636855e9.3 for ; Mon, 05 May 2025 13:59:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20230601.gappssmtp.com; s=20230601; t=1746478785; x=1747083585; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2jWUfET0sWOEOmslgRkB7lsBF+gol/4OWDRKdYdR8Gw=; b=m5fxWrz2acFVquaXFALi7FyOz2Khf8EYJ97Gd1zy5WRVMtehVy2s+7LL0ANSOenALA MCRRa4sA75YG/cR0n3mnVSkSez7cyAMv6v7cGBCSgxwnOovRQusmltgD4tfIo1qpUUaU bF/sLiupFKCdkD9xdqhXeEhB4AiWZjOb6asrIfQphYYzNGkVz9th3oePW2TMXqrBDwF4 RzXTsA1m+p+yT8RKGR23Ui8oOL0wYF2VCZKeWIBPY+yHScwmRRRYz0lRIA83Lzo16wrp X/rCCpUIBoVdls37fbzUzLflwsM6AkpK9GluapEhNvdWguDS985XvXbJGsOkYA9HWmFy cPcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746478785; x=1747083585; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2jWUfET0sWOEOmslgRkB7lsBF+gol/4OWDRKdYdR8Gw=; b=NzQX/sIA8eDPnDarORYW+uRdj1qS3rTuyzXhhn7cnQSuA1c4/VtS1sqgL9uJJ4n9Zw AYP3zuPqNodmc5Tn5g0BkfkSq3L237vKuo/OO/rnZcO2A+MilYKvyU9LRXHxPyf/t5kZ 6Bw1mBH92Sk2eMZSmHHnDuNnVpV2WMRvJlmb5aj+o1qUlYHX6L8uOwXS9DxPNZT4xbr1 u2mC3AXV5AQRRxuhYCsHLOoNuGYAUCNHGIV4rqfecZNLjsdnZJizQV7RjgQW6Lr9ve+v L/fALYVTl5uC7OVK/qCYiB+y5ajJYSdnEMnqLhW32iCJ094WyTuD1u73w2QUv1xj5S5E 97yQ== X-Gm-Message-State: AOJu0YyUXEZCVZQ5mmnYg5xrgzxDYWBJlLWI8fzoK/Cez7cBr7edlfch 1naX2IjjEH/Es0OuTFMN6lBpsnWwPhTr9pAIPJXWImO2fmJNA82bNh1ywgXk+y7bEaWkW4drp1Z /L/XqiA== X-Gm-Gg: ASbGncuobNoUw9hYBMwujcFif2qx4ykcNytlIjGn0V6K4gO1MgSJzGEur/go/0e1SH6 ytHOLygyc4Bvlj6bGS4PwsLqmRpY9n1lCRPZy7FIeKthOcg7bKmLPWW4GQ1E4IcngX67u4QAu/b gT9vzQfqHd27nApo3AVOdMtou9rDf/zkAAeLDofAHw8D5BTKJ38W9/FeBTSgr4ZYZ9mn81590VW Q166ITHXox8gzsaOkC+YahlH+RkwGmBYNbJyl7+whX7qiNJ2B65B5dKHdZHmxFs9JF4pWKYpssq pMVvrx5jThSebzeaXQXPkCCL9n6UP6cjEjeIzbuxgFHaBxLG5yi6ODMID+hhuBbmnXGZNNEKw/h zaMJDkn4zek0+wQ== X-Google-Smtp-Source: AGHT+IFYoo7mR9g5O1VUjh4JCQEfZsAHNbgg97ky7P26p0sO15mlNTrJH+IiD4e1aqW+LnnvOBKU8g== X-Received: by 2002:a05:600c:8212:b0:43c:fae1:5151 with SMTP id 5b1f17b1804b1-441d0531289mr4179055e9.25.1746478784920; Mon, 05 May 2025 13:59:44 -0700 (PDT) Received: from [192.168.0.15] (cpc92320-cmbg19-2-0-cust719.5-4.cable.virginm.net. [82.13.66.208]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a099ae7c49sm11550023f8f.52.2025.05.05.13.59.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 May 2025 13:59:44 -0700 (PDT) Message-ID: <08b053c9-9f5a-4601-91af-1cdfc83e9f67@jkqxz.net> Date: Mon, 5 May 2025 21:59:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20250505171300.2737-1-jamrial@gmail.com> From: Mark Thompson In-Reply-To: <20250505171300.2737-1-jamrial@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] tests/fate/cbs: add tests for APV X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 05/05/2025 18:13, James Almer wrote: > Ensure bitexact passthrough using the apv_metadata bsf. > > Signed-off-by: James Almer > --- > tests/fate/cbs.mak | 11 +++++++++++ > tests/ref/fate/cbs-apv-profile_422-10 | 1 + > 2 files changed, 12 insertions(+) > create mode 100644 tests/ref/fate/cbs-apv-profile_422-10 > > diff --git a/tests/fate/cbs.mak b/tests/fate/cbs.mak > index dfd9e7d93c..729a559327 100644 > --- a/tests/fate/cbs.mak > +++ b/tests/fate/cbs.mak > @@ -25,6 +25,17 @@ FATE_CBS_$(1)_DISCARD += fate-cbs-$(1)-discard-$(2) > fate-cbs-$(1)-discard-$(2): CMD = md5 -i $(TARGET_SAMPLES)/$(3) -c:v copy -y -bsf:v filter_units=discard=$(2) -f $(4) > endef > > +# APV read/write > + > +FATE_CBS_APV_SAMPLES = \ > + profile_422-10.apv > + > +$(foreach N,$(FATE_CBS_APV_SAMPLES),$(eval $(call FATE_CBS_TEST,apv,$(basename $(N)),apv,apv/$(N),apv))) > + > +FATE_CBS_APV-$(call FATE_CBS_DEPS, APV, APV, APV, APV, APV) = $(FATE_CBS_apv) > +FATE_SAMPLES_AVCONV += $(FATE_CBS_APV-yes) > +fate-cbs-apv: $(FATE_CBS_APV-yes) > + > # AV1 read/write > > FATE_CBS_AV1_CONFORMANCE_SAMPLES = \ > diff --git a/tests/ref/fate/cbs-apv-profile_422-10 b/tests/ref/fate/cbs-apv-profile_422-10 > new file mode 100644 > index 0000000000..897520f5f1 > --- /dev/null > +++ b/tests/ref/fate/cbs-apv-profile_422-10 > @@ -0,0 +1 @@ > +646c61e4e96b83146da8140c4c2a68b6 Add fate-cbs-apv as a dep of fate-cbs at the top of the file as well. Test LGTM. We should add some more once we have samples with better feature coverage (multiple frames, AU info, more metadata), but this is good for what we have now. Thanks, - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".