From: Dmitriy Kovalenko <dmtr.kovalenko@outlook.com>
To: "Martin Storsjö" <martin@martin.st>
Cc: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v4 2/2] swscale: Neon rgb_to_yuv_half process 32 pixels at a time
Date: Sat, 31 May 2025 08:59:32 +0000
Message-ID: <08EEF812-1A74-44BC-AD80-7202FEB282E8@outlook.com> (raw)
In-Reply-To: <f2f88646-2c10-f2d-645d-21fe1438208a@martin.st>
Great. I send another version with the reverted change for the asr register change. What is the correct process to reply for the inline changes then? Inline email answer or cover letter?
> On May 30, 2025, at 11:10, Martin Storsjö <martin@martin.st> wrote:
>
> On Fri, 30 May 2025, Dmitriy Kovalenko wrote:
>
>> === Feedback response ===
>
> FWIW, the procedure is to respond to inline comments by replying to the mails where those comments were made. When they're included here, they end up as part of your suggested commit message.
>
> Anyway, now this time, these patches do seem to work properly. There's still the unnecessary changes from w to x register names in patch 1/2, but other than that I no longer see strong blockers in the two patches.
>
> I'll give the patches a second proper review at a later time.
>
> // Martin
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-05-31 8:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250530084042.33204-1-dmtr.kovalenko@outlook.com>
2025-05-30 8:40 ` Dmitriy Kovalenko
2025-05-30 9:10 ` Martin Storsjö
2025-05-31 8:59 ` Dmitriy Kovalenko [this message]
2025-05-31 10:03 ` Martin Storsjö
2025-05-31 10:43 ` Christopher Snowhill
2025-05-31 10:49 ` Dmitriy Kovalenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08EEF812-1A74-44BC-AD80-7202FEB282E8@outlook.com \
--to=dmtr.kovalenko@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=martin@martin.st \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git