From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1BCA3463C8 for ; Sat, 15 Jul 2023 19:54:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2AD3C68C647; Sat, 15 Jul 2023 22:54:21 +0300 (EEST) Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 29D4A68C205 for ; Sat, 15 Jul 2023 22:54:15 +0300 (EEST) Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-993a37b79e2so433220366b.1 for ; Sat, 15 Jul 2023 12:54:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689450854; x=1692042854; h=mime-version:references:in-reply-to:message-id:date:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=EHt5ZsTHanhkmPD5TTuh0LaQ+IzAwFM6sHoQKDiOzxE=; b=o5XjHG5+M/OusfjggFB2hOouEoEWkBmnIr6Kgc3n58LARHbGazUwruiut7yMOq1zPU Hdit/hRyCkd5AVh+u97QSKSPt5PaWw2pkiwl147cox3f+4ObXz6D0K7zGWwiS0ye1aZw MOvCS6EsuzHFhZe9fSD/pdhiU7Ev/+ppPduH8f0DEiwUVfWXkUVJNKLfzFj7Pv7cpHsZ vRjDi1+lJDwM0Q1XAj7pPUUNRfSm7RooqFDNeHbf1mboYwMLPla27vHsWCjpjK0vZky3 WUMdHZwemoq8nuG9/d7ttaI7ZOQcBDiuJoD5ijx3xVk3rqWt+efbdGOGPFExFEl87145 9fIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689450854; x=1692042854; h=mime-version:references:in-reply-to:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EHt5ZsTHanhkmPD5TTuh0LaQ+IzAwFM6sHoQKDiOzxE=; b=YuGEaR4O+6rzhjUsPXqsQcDJmkkafKUo5UMK8XC1SddGaEfAqxVYitSgqaRpZP6y7R dHLpQTPXchtKjPPmKf/QNEvBmcz62uUCbx2ETzexfUGsGb6qCVDRDgJslhEeHK8tYAFv qPuMleg/JuroSKIHALl58eSTuZZOmkVSTX/zexIhhbHh0DL5y5VrsdjSc8I1C+8Q5xx2 6Cxtm3TBM+lBnxRwXSuFo5bfVOOPs4XrE8AdQCZwagsvogelFL6DKyQdVL4ToMvJEDOW Il3zrbf0+KWQntttSkXMcPnQOooNM00sDwmfzOIPMSUdxZUQaVL0NADoTXvl6wea6RFi brjA== X-Gm-Message-State: ABy/qLYB2aA0e9liAf/TlRjy3cUiyDjmzAMIFjQ9acI1SUq0nz0/7Pl8 ErNCoZGy6gJ/DrUIR0umUHxfHhvpV+xJHw== X-Google-Smtp-Source: APBJJlFpHTwpv/3CvTv+Rf2kLp106t2aTIuSPEv02nDDYqdCJ7a1u1VjWGh9dh1txINrLHejKvpeCA== X-Received: by 2002:a17:907:3e8a:b0:989:1a52:72b5 with SMTP id hs10-20020a1709073e8a00b009891a5272b5mr9089122ejc.45.1689450854332; Sat, 15 Jul 2023 12:54:14 -0700 (PDT) Received: from [192.168.1.202] (adsl-dyn93.78-98-186.t-com.sk. [78.98.186.93]) by smtp.gmail.com with ESMTPSA id lz15-20020a170906fb0f00b009944e912849sm2478066ejb.199.2023.07.15.12.54.13 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Jul 2023 12:54:13 -0700 (PDT) From: Marvin Scholz To: FFmpeg development discussions and patches Date: Sat, 15 Jul 2023 21:54:13 +0200 X-Mailer: MailMate (1.14r5964) Message-ID: <08860546-3228-4E6F-833D-787B47EE94CD@gmail.com> In-Reply-To: <20230715193603.22215-1-pkoshevoy@gmail.com> References: <20230715193603.22215-1-pkoshevoy@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavc/audiotoolbox: fix build failure on osx 10.5 (v3) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 15 Jul 2023, at 21:36, Pavel Koshevoy wrote: > --- > libavcodec/audiotoolboxdec.c | 2 ++ > libavcodec/audiotoolboxenc.c | 4 ++++ > 2 files changed, 6 insertions(+) > > diff --git a/libavcodec/audiotoolboxdec.c b/libavcodec/audiotoolboxdec.c > index 82babe3d31..5456f916cf 100644 > --- a/libavcodec/audiotoolboxdec.c > +++ b/libavcodec/audiotoolboxdec.c > @@ -71,10 +71,12 @@ static UInt32 ffat_get_format_id(enum AVCodecID codec, int profile) > return kAudioFormatAMR; > case AV_CODEC_ID_EAC3: > return kAudioFormatEnhancedAC3; > +#if MAC_OS_X_VERSION_MIN_REQUIRED >= 1060 > case AV_CODEC_ID_GSM_MS: > return kAudioFormatMicrosoftGSM; > case AV_CODEC_ID_ILBC: > return kAudioFormatiLBC; > +#endif > case AV_CODEC_ID_MP1: > return kAudioFormatMPEGLayer1; > case AV_CODEC_ID_MP2: > diff --git a/libavcodec/audiotoolboxenc.c b/libavcodec/audiotoolboxenc.c > index 1ccfda4d20..46aca4c7ff 100644 > --- a/libavcodec/audiotoolboxenc.c > +++ b/libavcodec/audiotoolboxenc.c > @@ -69,15 +69,19 @@ static UInt32 ffat_get_format_id(enum AVCodecID codec, int profile) > return kAudioFormatMPEG4AAC_HE_V2; > case FF_PROFILE_AAC_LD: > return kAudioFormatMPEG4AAC_LD; > +#if MAC_OS_X_VERSION_MIN_REQUIRED >= 1060 > case FF_PROFILE_AAC_ELD: > return kAudioFormatMPEG4AAC_ELD; > +#endif > } > case AV_CODEC_ID_ADPCM_IMA_QT: > return kAudioFormatAppleIMA4; > case AV_CODEC_ID_ALAC: > return kAudioFormatAppleLossless; > +#if MAC_OS_X_VERSION_MIN_REQUIRED >= 1060 > case AV_CODEC_ID_ILBC: > return kAudioFormatiLBC; > +#endif > case AV_CODEC_ID_PCM_ALAW: > return kAudioFormatALaw; > case AV_CODEC_ID_PCM_MULAW: > -- > 2.35.3 Thanks, LGTM from my side though I can not push it as I have no commit access, so someone else has to do that. > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".