From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 84C674339A for ; Thu, 9 Jun 2022 07:50:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0707368B6F6; Thu, 9 Jun 2022 10:50:48 +0300 (EEST) Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 57B1568B270 for ; Thu, 9 Jun 2022 10:50:40 +0300 (EEST) Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4LJbqd5zvTz9srf for ; Thu, 9 Jun 2022 09:50:37 +0200 (CEST) Message-ID: <085f0277-e678-4d20-f2bf-fbf55ed959d8@gyani.pro> Date: Thu, 9 Jun 2022 13:20:25 +0530 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220424183514.986374-1-vigneshv@google.com> From: Gyan Doshi In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2022-06-08 10:51 pm, Vignesh Venkatasubramanian wrote: > On Thu, Jun 2, 2022 at 1:35 PM James Zern wrote: >> On Wed, Jun 1, 2022 at 1:38 PM Vignesh Venkatasubramanian >> wrote: >>> On Wed, Jun 1, 2022 at 10:30 AM James Zern wrote: >>>> On Sun, Apr 24, 2022 at 11:35 AM Vignesh Venkatasubramanian >>>> wrote: >>>>> Update the still AVIF parser to only read the primary item. With this >>>>> patch, AVIF still images with exif/icc/alpha channel will no longer >>>>> fail to parse. >>>>> >>>>> For example, this patch enables parsing of files in: >>>>> https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Microsoft >>>>> >>>> Can some of the failing files or similar ones be added to fate? >>> There are no fate tests for AVIF parsing as of now. I was thinking >>> about adding some for the muxing. But i am not sure what can be done >>> here for the parsing. >>> >> Thanks. Are there any for general mov/mp4 parsing that could be >> extended? This looks good otherwise. > From what i see, most of the mov tests only seem to be for muxing. I'm > not entirely certain about how to add a test for AVIF parsing. If > anybody has an idea, i'd be open to adding it. Basic test would use the framemd5 muxer to compare demuxed packets with a reference. See fate-ffmpeg-streamloop Regards, Gyan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".