Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

[Gyan Doshi <ffmpeg@gyani.pro>]

On 2022-06-08 10:51 pm, Vignesh Venkatasubramanian wrote:
> On Thu, Jun 2, 2022 at 1:35 PM James Zern <jzern@google.com> wrote:
>> On Wed, Jun 1, 2022 at 1:38 PM Vignesh Venkatasubramanian
>> <vigneshv@google.com> wrote:
>>> On Wed, Jun 1, 2022 at 10:30 AM James Zern <jzern@google.com> wrote:
>>>> On Sun, Apr 24, 2022 at 11:35 AM Vignesh Venkatasubramanian
>>>> <vigneshv-at-google.com@ffmpeg.org> wrote:
>>>>> Update the still AVIF parser to only read the primary item. With this
>>>>> patch, AVIF still images with exif/icc/alpha channel will no longer
>>>>> fail to parse.
>>>>>
>>>>> For example, this patch enables parsing of files in:
>>>>> https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Microsoft
>>>>>
>>>> Can some of the failing files or similar ones be added to fate?
>>> There are no fate tests for AVIF parsing as of now. I was thinking
>>> about adding some for the muxing. But i am not sure what can be done
>>> here for the parsing.
>>>
>> Thanks. Are there any for general mov/mp4 parsing that could be
>> extended? This looks good otherwise.
>  From what i see, most of the mov tests only seem to be for muxing. I'm
> not entirely certain about how to add a test for AVIF parsing. If
> anybody has an idea, i'd be open to adding it.

Basic test would use the framemd5 muxer to compare demuxed packets with 
a reference.
See fate-ffmpeg-streamloop

Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".