From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8324E41016 for ; Sat, 12 Feb 2022 11:58:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4BD7668B213; Sat, 12 Feb 2022 13:58:22 +0200 (EET) Received: from mail.acc.umu.se (mail.acc.umu.se [130.239.18.156]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 333B668AEAF for ; Sat, 12 Feb 2022 13:58:15 +0200 (EET) Received: from localhost (localhost.localdomain [127.0.0.1]) by amavisd-new (Postfix) with ESMTP id C8F4944B91 for ; Sat, 12 Feb 2022 12:58:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=acc.umu.se; s=mail1; t=1644667093; bh=Lwq/0mf3HudH5K3TgOBmN/pfyzRB7SUzIxEaQ6rCr90=; h=Subject:From:To:Date:In-Reply-To:References:From; b=umQ0K/GBefFnh282JN2yrdXXFiaw6qd41gTNHiWaavIziGyh5GqWR98Z5C5y1wpRe l8NtnGCtoqQah/hFZg6lMQP2f0I58fl1lZZNMZsPLAnpjrtJFK8xAt0Wu60cK8ARo5 eomUO1pl8Uf6U/lARcOVRyg+PfJZP63SQGk2RE+ria8rNMCNXYpX3LZyc7khrmILdd 0ZAS2190eb5Y+4cCxIBS6fYT38A7svu4Tte0hW1csKwyA0+PZx4NiuG/gggvzG+A6A KTt6Ugt72bTqN2uJsWX3c/caXVUUT2Z+wb2Ogj0pPeE8Hoq0OcQMbm1pFkYSVS/X0V d0WmSok14bM5Q== Received: from debian.lan (unknown [IPv6:2a00:66c0:a::72c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: tjoppen) by mail.acc.umu.se (Postfix) with ESMTPSA id 5317744B90 for ; Sat, 12 Feb 2022 12:58:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=acc.umu.se; s=mail1; t=1644667093; bh=Lwq/0mf3HudH5K3TgOBmN/pfyzRB7SUzIxEaQ6rCr90=; h=Subject:From:To:Date:In-Reply-To:References:From; b=umQ0K/GBefFnh282JN2yrdXXFiaw6qd41gTNHiWaavIziGyh5GqWR98Z5C5y1wpRe l8NtnGCtoqQah/hFZg6lMQP2f0I58fl1lZZNMZsPLAnpjrtJFK8xAt0Wu60cK8ARo5 eomUO1pl8Uf6U/lARcOVRyg+PfJZP63SQGk2RE+ria8rNMCNXYpX3LZyc7khrmILdd 0ZAS2190eb5Y+4cCxIBS6fYT38A7svu4Tte0hW1csKwyA0+PZx4NiuG/gggvzG+A6A KTt6Ugt72bTqN2uJsWX3c/caXVUUT2Z+wb2Ogj0pPeE8Hoq0OcQMbm1pFkYSVS/X0V d0WmSok14bM5Q== Message-ID: <082d3be259f0e24332ef3641813e696844411433.camel@acc.umu.se> From: Tomas =?ISO-8859-1?Q?H=E4rdin?= To: FFmpeg development discussions and patches Date: Sat, 12 Feb 2022 12:58:12 +0100 In-Reply-To: References: <20220203172950.21458-1-markg85@gmail.com> <20220203172950.21458-2-markg85@gmail.com> <89a4c9e177b6cb12426a9d9ae507508ea0e9a178.camel@acc.umu.se> <48388080f40903739bea322f1197dee9a5f30c95.camel@acc.umu.se> User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v4 1/1] avformat: Add IPFS protocol support. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: ons 2022-02-09 klockan 18:36 +0100 skrev Mark Gaiser: > > > Thank you so much for all the valuable feedback! It's much > appreciated :) > > I'll fix all the still open issues and send another patch mail > somewhere > later this week. > Question though, as this seems to be heading towards the final patch > version. How do you prefer to see the next patch round? > > 1. As it's done currently. You don't see what's different. > 2. As a 1/2 and 2/2 patch where 2/2 would be the a diff on top of 1/2 > with > the review feedback applied. > > Either is fine with me. > But I fear that a split patch mail (so 1/2 with the code as is right > now > and 2/2 with the feedback changes) could potentially waste people's > time if > they comment on something that is fixed in the feedback patch. Submit patches as you want them in the source tree. Writing patches to patches not yet committed makes little sense. /Tomas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".