From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v3 1/2] checkasm: add test for fdct
Date: Mon, 13 May 2024 13:49:02 -0300
Message-ID: <0811659f-6875-4d42-aa68-9a8599af962d@gmail.com> (raw)
In-Reply-To: <5480543.FAvSztlbtb@basile.remlab.net>
On 5/6/2024 2:49 PM, Rémi Denis-Courmont wrote:
> Le maanantaina 6. toukokuuta 2024, 20.18.11 EEST Ramiro Polla a écrit :
>> I'll send a similar patch to fix checkasm/idctdsp after this is merged.
>
> The idctdsp test does not actually test the iDCT, but only the trivial-ish
> add/put helpers, so it does not care about the context. You're welcome to fix
> it anyway of course.
I personally find it ugly how we're storing a whole AVCodecContext on
stack in these tests just to pass two ints to an init function.
Maybe we can make said values be input parameters for these instead of a
pointer to avctx.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-05-13 16:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 18:01 [FFmpeg-devel] [PATCH v3 0/2] lavc/aarch64/fdct: add neon-optimized fdct for aarch64 Ramiro Polla
2024-04-17 18:01 ` [FFmpeg-devel] [PATCH v3 1/2] checkasm: add test for fdct Ramiro Polla
2024-05-02 18:04 ` Rémi Denis-Courmont
2024-05-06 17:18 ` Ramiro Polla
2024-05-06 17:49 ` Rémi Denis-Courmont
2024-05-13 16:49 ` James Almer [this message]
2024-05-13 19:14 ` Ramiro Polla
2024-04-17 18:01 ` [FFmpeg-devel] [PATCH v3 2/2] lavc/aarch64/fdct: add neon-optimized fdct for aarch64 Ramiro Polla
2024-04-17 20:49 ` [FFmpeg-devel] [PATCH v3 0/2] " Martin Storsjö
2024-05-13 12:55 ` Ramiro Polla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0811659f-6875-4d42-aa68-9a8599af962d@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git