From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1C5F6456D1 for ; Sat, 18 Feb 2023 13:32:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4087B68BE1A; Sat, 18 Feb 2023 15:32:41 +0200 (EET) Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9CCA068BCE7 for ; Sat, 18 Feb 2023 15:32:35 +0200 (EET) Received: by mail-oi1-f179.google.com with SMTP id bd2so916676oib.1 for ; Sat, 18 Feb 2023 05:32:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=x6C5Xx54RZRfWiOk0YA3h9VsTbg1exh3F2bW70EJ89o=; b=W4maRiJeuaxX2C3MoDDaJfVEBgfCtZdAS5jhPfKZCCY9Ry3QUKJ3ubduNZBtDnO+hm UeVzqt7cuKHI2UeM+kOpEXZ+mcP4VrX0yrFfMYFY9AZ1LTy7yLy12RGZtFTnKYIuj5ab PGeidtRfe/xGhSD1CL9fJ65ooMK72pgEVJm0LgbTu0bGHT6BNdqXO7kZRv7kdT8aeb+e gKat/kMpUCU6C+ev4dXmDkV8SC/rgLPV1iGI3X2nLDs1NrXuG2nu0BQJJJ+2t33RuTBY hA+QcFNSotKBdj35zVyVDMLI1wM2BaMmTpMMfE49vkVKPsHZCSObDNC14YJHE45RGuGz PmnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=x6C5Xx54RZRfWiOk0YA3h9VsTbg1exh3F2bW70EJ89o=; b=Ppap4LcP6u+m4gRdwxESthe++z63eHSgOGR/6cLAlfAAbHWu1tJwsaE/yOZhPZU/cR M6xTPBy5jEu6IYsUY2uIqE1gEr4aaWWAxf7O4/vnEU566HktONyCFPgdmGGamRmhV0zd KEUBBpLF8VywXf7SoOYUQXtCYNYvr2hjFQqFx1Wp/Aur8iwdBt62hGKPKmqoUSIakiuJ PusPDcyABfF1Gkta65nrlEx3R85bQlTdrvIOjjMM72h7G9Yk4JsJ9nt7r3LYnYmd4doh RH7gy1DpqeaAFhxDzcr+8mgZ3q0St4lG2JGZxr3LNq19pc6Hn3zor9ga7cDF7vd12pr9 vfbw== X-Gm-Message-State: AO0yUKVT5g0bjgEawp4cznOLWklA7mg5m6/90/jmT7q00dRTGAOEZ1MF HWUVT0lj6Iu9L84kLoXw6d927h1Ejlo= X-Google-Smtp-Source: AK7set/1SCed7N4oBPKfJWxMtBi62Ab7IdaczBBamEOInXXoDISMAP1TnIP4waof2IpxeiGDch/acg== X-Received: by 2002:a05:6808:2d0:b0:37a:fa7d:972e with SMTP id a16-20020a05680802d000b0037afa7d972emr1695402oid.41.1676727152799; Sat, 18 Feb 2023 05:32:32 -0800 (PST) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id e28-20020a0568301e5c00b0066b9a6bf3bcsm3032993otj.12.2023.02.18.05.32.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Feb 2023 05:32:32 -0800 (PST) Message-ID: <077fbbad-3629-c057-1d5d-d59fece7eed9@gmail.com> Date: Sat, 18 Feb 2023 10:32:54 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <66307ef3-b214-47f6-6d4e-fbcc439f2004@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] lavc: deprecate avcodec_dct, av_fft, av_dct, av_rdft and av_mdct X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/18/2023 9:49 AM, Lynne wrote: > Feb 17, 2023, 19:45 by dev@lynne.ee: > >> Feb 17, 2023, 18:08 by jamrial@gmail.com: >> >>> On 2/17/2023 1:54 PM, Lynne wrote: >>> >>>> This reverts commit 26cb36f35746fe6ef53688b119852bfa6d555f62. >>>> >>>> All filters and all codecs (except wmavoice) have been ported for the >>>> lavu/tx API. >>>> >>>> The noise should be minimal. >>>> >>> >>> It isn't. I'm getting more than two thousand lines of warnings after applying this patch from >>> >>> libavfilter/vf_spp.c >>> libavfilter/x86/vf_spp.c >>> libavcodec/asvenc.c >>> libavcodec/avdct.c >>> libavcodec/avfft.c >>> libavcodec/dct.c >>> libavcodec/fdctdsp.c >>> libavcodec/fft_float.c >>> libavcodec/fft_init_table.c >>> libavcodec/idctdsp.c >>> libavcodec/jfdctfst.c >>> libavcodec/jfdctint.c >>> libavcodec/jrevdct.c >>> libavcodec/mpegaudiodsp.c >>> libavcodec/mpegvideo_enc.c >>> libavcodec/rdft.c >>> libavcodec/wmavoice.c >>> libavcodec/x86/dct_init.c >>> libavcodec/x86/fft_init.c >>> libavcodec/x86/mpegvideoenc.c >>> >>> It's not just wmavoice, there's also mpeg and jpeg stuff, and one filter. For the actual fft/dct/rdft/mdct source files, you should use the deprecation warning pragmas to silence them, but the other modules need to be ported. >>> This patch is also missing the schedule FF_API deprecation wrapper. >>> >> >> Is the noise acceptable if I just deprecate the functions? >> It wasn't before, but it should be much less now. >> > > Version 2 attached. > Deprecates only the init functions (which must always be used, therefore > the entire API is deprecated). You should deprecate all the functions, not just the init ones, even if the rest depend on them. And add a "@deprecated use AVTXContext from libavutil/tx.h" line or similar in the doxy for at least the init or alloc functions to point library users to the replacement API. > Included FF_API defines, and bumped minor. > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".