From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6E61543CC8 for ; Sat, 4 Feb 2023 10:04:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E7FD868BE0E; Sat, 4 Feb 2023 12:04:43 +0200 (EET) Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1AD2168BD34 for ; Sat, 4 Feb 2023 12:04:37 +0200 (EET) Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4P87RQ4H8Qz9syQ for ; Sat, 4 Feb 2023 11:04:34 +0100 (CET) Message-ID: <07058d2f-ae00-ba51-02df-f1c1708ada15@gyani.pro> Date: Sat, 4 Feb 2023 15:34:20 +0530 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230202180642.3479-1-ffmpeg@gyani.pro> <4039d916-a926-de54-7346-ea20c40c6043@gyani.pro> From: Gyan Doshi In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avformat/tee: signal EOF if no more output is to be published. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2023-02-03 02:02 pm, Marton Balint wrote: > > > Any av_interleaved_write_frame() negative return value is an error, > ffmpeg should abort. It seems that there is a clash of error codes in > sync_queue_process which returns AVERROR_EOF to signal sq_send EOF > return, but that clashes with the AVERROR_EOF of > av_interleaved_write_frame(), so the error condition is lost. New patch sent. Note that the behaviour since 2d924b3a630 is to terminate only that muxer's thread, which I haven't changed. I think this is preferable to runtime abortion. Regards, Gyan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".