Re: [FFmpeg-devel] [PATCH v3 5/5] lavc: implement a Vulkan-based VC-2 encoder Implements a Vulkan based dirac encoder. Supports Haar and Legall wavelets and should work with all wavelet depths.

From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v3 5/5] lavc: implement a Vulkan-based VC-2 encoder Implements a Vulkan based dirac encoder. Supports Haar and Legall wavelets and should work with all wavelet depths.
Date: Thu, 17 Apr 2025 22:19:10 -0300
Message-ID: <06e3c498-0178-47f6-8224-fae3a1f46119@gmail.com> (raw)
In-Reply-To: <ecffacc5-958d-47f2-939d-7822fc7c51db@lynne.ee>

[-- Attachment #1.1.1: Type: text/plain, Size: 2007 bytes --]

On 4/17/2025 10:11 PM, Lynne wrote:
> On 18/04/2025 01:55, IndecisiveTurtle wrote:
>> From: IndecisiveTurtle <geoster3d@gmail.com>
>>
>> Performance wise, encoding a 1080p 1-minute video is performed in 
>> about 2.5 minutes with the cpu encoder running on my Ryzen 5 4600H, 
>> while it takes about 30 seconds on my NVIDIA GTX 1650
>>
>> Haar shader has a subgroup optimized variant that applies when 
>> configured wavelet depth allows it
>> ---
>>   configure                                    |   1 +
>>   libavcodec/Makefile                          |   3 +
>>   libavcodec/allcodecs.c                       |   1 +
>>   libavcodec/vc2enc_vulkan.c                   | 959 +++++++++++++++++++
>>   libavcodec/vulkan/vc2_dwt_haar.comp          |  82 ++
>>   libavcodec/vulkan/vc2_dwt_haar_subgroup.comp |  75 ++
>>   libavcodec/vulkan/vc2_dwt_hor_legall.comp    |  82 ++
>>   libavcodec/vulkan/vc2_dwt_upload.comp        |  96 ++
>>   libavcodec/vulkan/vc2_dwt_ver_legall.comp    |  78 ++
>>   libavcodec/vulkan/vc2_encode.comp            | 169 ++++
>>   libavcodec/vulkan/vc2_slice_sizes.comp       | 170 ++++
>>   11 files changed, 1716 insertions(+)
>>   create mode 100644 libavcodec/vc2enc_vulkan.c
>>   create mode 100644 libavcodec/vulkan/vc2_dwt_haar.comp
>>   create mode 100644 libavcodec/vulkan/vc2_dwt_haar_subgroup.comp
>>   create mode 100644 libavcodec/vulkan/vc2_dwt_hor_legall.comp
>>   create mode 100644 libavcodec/vulkan/vc2_dwt_upload.comp
>>   create mode 100644 libavcodec/vulkan/vc2_dwt_ver_legall.comp
>>   create mode 100644 libavcodec/vulkan/vc2_encode.comp
>>   create mode 100644 libavcodec/vulkan/vc2_slice_sizes.comp
> 
> LGTM.
> Planning to push this tomorrow unless there are objections.

This set was sent today, so please wait a couple days before pushing it.

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".