From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id DE6E94BD46 for <ffmpegdev@gitmailbox.com>; Fri, 4 Apr 2025 12:44:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4A2A468A93D; Fri, 4 Apr 2025 15:44:17 +0300 (EEST) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 76406687C3D for <ffmpeg-devel@ffmpeg.org>; Fri, 4 Apr 2025 15:44:11 +0300 (EEST) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-43cf3192f3bso19926235e9.1 for <ffmpeg-devel@ffmpeg.org>; Fri, 04 Apr 2025 05:44:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743770650; x=1744375450; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4yYLyF0qqTgElIgWu727R0GtYQlbxD/0CgnEZlWmht4=; b=mHfaDvf78Bx6JXamgnN7ggaMdboK4Ed8Zwhr4w1SylyvMGC8kJXnMnzeOnx4bw5Aqj NXIOkkQLFipfe+oiEXEKWiUV5TPufAd8phK7kkTthxbNoZS7H64spCSuBR5W7oC3SGzi +7eIOge2Z+iHk9Rv5lHtWmK18onoRB5IUgnesvZ3y9rcuzW3jmC7URL1XVNFVwcH1uto uYf08G7Vyy43wvNP1mIwbd2ImjPO5aFnzZv087CHulORXIYfES0BI5ZVyKx1CLLVd/z1 MBFvyrpOnYixfD4JnyuG80lW+exNARsLfZr6ihI4au16YZiYIh2WWo2uTTQ1QI6vmSaF tXMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743770650; x=1744375450; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4yYLyF0qqTgElIgWu727R0GtYQlbxD/0CgnEZlWmht4=; b=itdL/c+caiKAcDOyg69JYuLy3uVOdZ32Hg1KCrYoSgAXYSSAVYfPM06JgOnoMzoWM2 R/zdz551ltpXwwKd0tj4G/9Xyqr+FJji1nhieBa4IfU4E7TtQ3dln8G1EZNrXaNjR1lb fW+oCCCbOBvExVH395ina6g28DhV1olMUgjIkMY+lfBU3KVTkuvtdprU+fRNVD/+8XQo 4eFek9/cMV5fy1W7tJ9OGPjyPoNgynQRybJwOa4Q+GhRiNSG2eiDOSYht4rA/q6GcBcU 8j+oHLI6OZFgSUSD4XJri/DbUgQHacF+aRm7fWiJ/QNSk2OTdyog8POhwmxGZKVsEccW HCdA== X-Gm-Message-State: AOJu0YwQfcJXIYShSAVf2j1v6pG4JM0dMW2y/zcyf43mf3fJQf+iL0b3 ol9aa4xd3KhY8c4ZZiNqg7fDIQrQe75T7vUOmoCwWbs11UBg7afQLRWpzQ== X-Gm-Gg: ASbGncsSBifvtc9hrvNk/i951xLpQKlEFXpSM9C92SUvLx8vca1GJ8w0pDR0wiYpdK3 WFZq3+CNUEe7dDdfq7vQrJ/ODPNyAU8p3oFXthjDvz0lI6V+H2P3CJgZcWFU9SB3GbjHRTrD6y+ 6/ujSZvFIqB8rzbWFI1aq9wbiOpXwcy2sVIJnxPM/YSVTSLQ5KBLhfmn9V6NI3jSJQ6QiEGDXUh Emc4+pSK30JyxZpYAkVZA8IRkgnhxYIN+Uk+l4ovS1pYdTMMlP1pfJXRUnmKq+t0kC0t8cE/bHh 8SgWJ+zWORNoDY2AHe38CsDIWcFD3KlhHnFXRXXzha6eCV2jNoHqPd3G3Khvrpt6Y2kkQC+/06a vcfybWxFsI6fKH9UrmzsY5iqJWnc= X-Google-Smtp-Source: AGHT+IFgzJaJSmgSnFY/5BhSMGFWwYY4Ti1oKagYFWzSRSh6HGYYx1wTqUN6K2eRfPll2WeqlJ4Jow== X-Received: by 2002:a05:600c:198d:b0:43c:fe15:41c9 with SMTP id 5b1f17b1804b1-43ed0bf6378mr25642325e9.9.1743770649741; Fri, 04 Apr 2025 05:44:09 -0700 (PDT) Received: from [192.168.1.106] (33bf1e4c.skybroadband.com. [51.191.30.76]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-43ec342827fsm45805725e9.6.2025.04.04.05.44.08 for <ffmpeg-devel@ffmpeg.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Apr 2025 05:44:08 -0700 (PDT) Message-ID: <06be9fc2-db5c-44f9-893c-e174290afe47@gmail.com> Date: Fri, 4 Apr 2025 13:44:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: ffmpeg-devel@ffmpeg.org References: <20250324155737.83118-1-derek.buitenhuis@gmail.com> <AS8P250MB074461A9D25440982D7FE0028FA12@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> From: Derek Buitenhuis <derek.buitenhuis@gmail.com> In-Reply-To: <AS8P250MB074461A9D25440982D7FE0028FA12@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> Subject: Re: [FFmpeg-devel] [PATCH] avformat/dhav: fix backward scanning for get_duration and optimize seeking X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/06be9fc2-db5c-44f9-893c-e174290afe47@gmail.com/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> On 3/27/2025 6:18 PM, Andreas Rheinhardt wrote: > You read into a buffer just to ignore the read data? Why don't you just > rewrite the loop below to inspect the data directly? While looking into this, I noticed that this demuxer also does something similar for the first packet which is not bounded (may scan the whole file)... which is pretty bad. This really made me ask: Why on earth are we doing this anyway? We don't do this in any other demuxer, and it is a very badly behaved way to act, even if we're not over a network. That is, can we just remove these hacks? Also, I noticed this demuxer has a bunch of what appears to be debug stuff left over that is dead code. In general, it seems pretty bad. - Derek _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".