From: Derek Buitenhuis <derek.buitenhuis@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avformat/dhav: fix backward scanning for get_duration and optimize seeking
Date: Fri, 4 Apr 2025 13:44:07 +0100
Message-ID: <06be9fc2-db5c-44f9-893c-e174290afe47@gmail.com> (raw)
In-Reply-To: <AS8P250MB074461A9D25440982D7FE0028FA12@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
On 3/27/2025 6:18 PM, Andreas Rheinhardt wrote:
> You read into a buffer just to ignore the read data? Why don't you just
> rewrite the loop below to inspect the data directly?
While looking into this, I noticed that this demuxer also does something
similar for the first packet which is not bounded (may scan the whole file)...
which is pretty bad.
This really made me ask: Why on earth are we doing this anyway? We don't
do this in any other demuxer, and it is a very badly behaved way to act,
even if we're not over a network.
That is, can we just remove these hacks?
Also, I noticed this demuxer has a bunch of what appears to be debug stuff
left over that is dead code. In general, it seems pretty bad.
- Derek
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-04-04 12:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 15:57 Derek Buitenhuis
2025-03-27 14:04 ` Derek Buitenhuis
2025-03-27 18:18 ` Andreas Rheinhardt
2025-04-04 12:44 ` Derek Buitenhuis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06be9fc2-db5c-44f9-893c-e174290afe47@gmail.com \
--to=derek.buitenhuis@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git