From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4615D42B37 for ; Mon, 25 Apr 2022 22:45:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6A64F68B2C8; Tue, 26 Apr 2022 01:45:56 +0300 (EEST) Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6A1CA68AF9F for ; Tue, 26 Apr 2022 01:45:50 +0300 (EEST) Received: by mail-ot1-f49.google.com with SMTP id k29-20020a056830243d00b006040caa0988so11852631ots.6 for ; Mon, 25 Apr 2022 15:45:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:content-language:to :references:from:subject:in-reply-to:content-transfer-encoding; bh=fBK0VLWZkOdgREu+7ksG4uXh/ZQSdiLrjzZ5i3s8Cks=; b=MTDvwtKAFhNGiSJ7z3F5fyMEBcB1Z+RPKES43EypZeg7LnRzdqHSnTvLVYMyu80dSs XslGKqWiOi2fTxTH16r2xnJkTyW10CtBduDRNwihFjaud0cMO5qFZWbhPgKNeKbYXhus njAQ9JcLQn4/mqNmq/wkGNKiyAX2mOq5gDl67a/gKMDHeMGaB9bTZStceCg2WPNIKS7s DL1L6OtZHHzyM2yOvcVKuBL/hGxA3FLpHz8C6bMnldbXKZIX5IKAeEKWj2duLrMOA5Kp uFspfM5XIDNdManG4NUYBWMZKGcMYi4JzhlmEkiLprxQS1FjTvLHpRgOPiHxEpx4qRtP WTaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:references:from:subject:in-reply-to :content-transfer-encoding; bh=fBK0VLWZkOdgREu+7ksG4uXh/ZQSdiLrjzZ5i3s8Cks=; b=iF2Au6W7duFvsHnbxXdF5IRMIQitw26kiI3Xp/AoEzbqEsqDlqqIeiSEMdRSDJraY5 i8BzBwjDTLea5jwf8cH8IMKt2OyVhuvOZNCK5j+5j13v3XoaOw5Biahe8YaFPg6JoQul QoadG/vIunPb2LCpXNiX4d5b76ECs5W3IR2LOBaLbZFgsY8k99cSBqYErLd0lAPqw/q2 kcAMeEmfxP0pMQuoTD29KADB4JTZlnfekkq2+YcjOJ27/3vSBihAXGMS+3CGvX6uP5m4 cdzJaYGNQ1wtEPe+Zc0qEqpCJ8H6VvzIQzVmDjiwH1pes61iCVGp/AXXgOv2khS/0v0o W99g== X-Gm-Message-State: AOAM532BBEF80opLzHHsNlDU66o/wOqQ2NNU+yY+KAiOMOpJOSMNSwop l5Ecubrmg0EUQbmq75eh9SUdLIC7BA0= X-Google-Smtp-Source: ABdhPJy+UZwnvE4w/GLAp/e3xZOOiYv1S/U85VXt5TEgDjIY7ufOntNtwigvIjSxO5CxsyXOXY9p0w== X-Received: by 2002:a05:6830:10d:b0:605:4ff9:902f with SMTP id i13-20020a056830010d00b006054ff9902fmr7372265otp.359.1650926748441; Mon, 25 Apr 2022 15:45:48 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id ec4-20020a0568708c0400b000e2b873f013sm190830oab.0.2022.04.25.15.45.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 15:45:47 -0700 (PDT) Message-ID: <06bcde10-68a6-ce5d-c9c4-5fe02fd9d145@gmail.com> Date: Mon, 25 Apr 2022 19:45:47 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220425223719.432161-1-ccom@randomderp.com> From: James Almer In-Reply-To: <20220425223719.432161-1-ccom@randomderp.com> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libsvtav1: pass pict_type to library X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/25/2022 7:37 PM, Christopher Degawa wrote: > match the behavior of SvtAv1EncApp to ensure pic_type is always set > before passing it to the library. > > The other options for pic_type aren't currently used inside the library, > so they aren't introduced in this patch. > > Signed-off-by: Christopher Degawa > --- > libavcodec/libsvtav1.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c > index 2e3d96ce37..eafb762a7d 100644 > --- a/libavcodec/libsvtav1.c > +++ b/libavcodec/libsvtav1.c > @@ -404,6 +404,11 @@ static int eb_send_frame(AVCodecContext *avctx, const AVFrame *frame) > headerPtr->p_app_private = NULL; > headerPtr->pts = frame->pts; > > + switch (frame->pict_type) { > + case AV_PICTURE_TYPE_I: headerPtr->pic_type = EB_AV1_KEY_PICTURE; break; > + default: headerPtr->pic_type = EB_AV1_INVALID_PICTURE; break; // Actually means auto, or default. > + } Please align these vertically if you're not using separate lines. > + > svt_av1_enc_send_picture(svt_enc->svt_handle, headerPtr); > > return 0; _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".