Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libsvtav1: pass pict_type to library
Date: Mon, 25 Apr 2022 19:45:47 -0300
Message-ID: <06bcde10-68a6-ce5d-c9c4-5fe02fd9d145@gmail.com> (raw)
In-Reply-To: <20220425223719.432161-1-ccom@randomderp.com>

On 4/25/2022 7:37 PM, Christopher Degawa wrote:
> match the behavior of SvtAv1EncApp to ensure pic_type is always set
> before passing it to the library.
> 
> The other options for pic_type aren't currently used inside the library,
> so they aren't introduced in this patch.
> 
> Signed-off-by: Christopher Degawa <ccom@randomderp.com>
> ---
>   libavcodec/libsvtav1.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
> index 2e3d96ce37..eafb762a7d 100644
> --- a/libavcodec/libsvtav1.c
> +++ b/libavcodec/libsvtav1.c
> @@ -404,6 +404,11 @@ static int eb_send_frame(AVCodecContext *avctx, const AVFrame *frame)
>       headerPtr->p_app_private = NULL;
>       headerPtr->pts           = frame->pts;
>   
> +    switch (frame->pict_type) {
> +    case AV_PICTURE_TYPE_I: headerPtr->pic_type = EB_AV1_KEY_PICTURE; break;
> +    default: headerPtr->pic_type = EB_AV1_INVALID_PICTURE; break; // Actually means auto, or default.
> +    }

Please align these vertically if you're not using separate lines.

> +
>       svt_av1_enc_send_picture(svt_enc->svt_handle, headerPtr);
>   
>       return 0;
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-04-25 22:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25 22:37 Christopher Degawa
2022-04-25 22:45 ` James Almer [this message]
2022-04-25 22:54 ` [FFmpeg-devel] [PATCH v2] " Christopher Degawa
2022-04-25 23:05   ` James Almer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06bcde10-68a6-ce5d-c9c4-5fe02fd9d145@gmail.com \
    --to=jamrial@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git