From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 310864C3A9 for ; Fri, 26 Jul 2024 08:33:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2508E68D681; Fri, 26 Jul 2024 11:33:32 +0300 (EEST) Received: from vidala.lynne.ee (vidala.pars.ee [116.203.72.101]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EFFC468D240 for ; Fri, 26 Jul 2024 11:33:24 +0300 (EEST) Message-ID: <0656152d-6c99-4d3e-ac0f-6dc28faaa953@lynne.ee> Date: Fri, 26 Jul 2024 10:33:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: FFmpeg development discussions and patches References: <20240726064216.893951-1-dev@lynne.ee> <172198003078.21344.2362190110390447941@lain.khirnov.net> Content-Language: en-US Autocrypt: addr=dev@lynne.ee; keydata= xjMEXnFG3BYJKwYBBAHaRw8BAQdA3FyJpqEdfQj4GA7OUWVrNheT9dUsIs+yUx6Hljr9mYvN FEx5bm5lIDxkZXZAbHlubmUuZWU+wpAEExYIADgWIQT+UBOcaAVyyv1SH42i/qXwPwNEZAUC XnFG3AIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRCi/qXwPwNEZOTWAQCSNEA+kZLI NZ2dsR5Qg988c0HXpOXThZEjg+h1TL7KGgEA3Gff0c28efI02S6iMxazrpdWGHqHk7JN7pCj nt397wzOOARecUbcEgorBgEEAZdVAQUBAQdAjDdFQ5H+AJ9vwXrOb7val460g45EsheIaL5S 7/zSaX8DAQgHwngEGBYIACAWIQT+UBOcaAVyyv1SH42i/qXwPwNEZAUCXnFG3AIbDAAKCRCi /qXwPwNEZKaxAQCHLV4gAk/B9JvRG27MYm22X3+5QRCLBtEILP29aDh+MQD/V8JFHATDXRY3 0LsmqR3sPQ0BJ1UFVZA5BUoIJPJZWwg= In-Reply-To: <172198003078.21344.2362190110390447941@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, ) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lynne via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Lynne Content-Type: multipart/mixed; boundary="===============8459828221138592336==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============8459828221138592336== Content-Language: en-US Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------TywZ0OYdZNsfOVaw0ky4w5Ce" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------TywZ0OYdZNsfOVaw0ky4w5Ce Content-Type: multipart/mixed; boundary="------------OAZXVfTiIhr03O0vTJJZAo4o"; protected-headers="v1" From: Lynne To: FFmpeg development discussions and patches Message-ID: <0656152d-6c99-4d3e-ac0f-6dc28faaa953@lynne.ee> Subject: Re: [FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, ) References: <20240726064216.893951-1-dev@lynne.ee> <172198003078.21344.2362190110390447941@lain.khirnov.net> In-Reply-To: <172198003078.21344.2362190110390447941@lain.khirnov.net> --------------OAZXVfTiIhr03O0vTJJZAo4o Content-Type: multipart/mixed; boundary="------------0EBSFnI005Zg4ktQBUSqhuRM" --------------0EBSFnI005Zg4ktQBUSqhuRM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 26/07/2024 09:47, Anton Khirnov wrote: > Quoting Lynne via ffmpeg-devel (2024-07-26 08:42:11) >> Its not feasible to add an AVClass in the main context, as >> it would waste space, as the main context is recursive, and >> every bit of assembly would need to be changed. >> >> While its true that on paper av_log has access to the main >> context, that functionality is not used as no options are >> available for setting. No options will be exposed either, >> and it makes no sense. >> >> mpv has recently started warning if a NULL AVClass is used >> as an FFmpeg bug. While I don't fully agree nor disagree with >> this, this is a simple patch which fixes the issue. > > No, it just hides the issue for the time being. If this means "it may get broken eventually, its not forbidden anywhere", then IMO we should just codify the current behavior such that it won't, unless there's some use-case you can think of. > I am against this patch, just add a proper AVClass. AVTXContext is > entirely opaque, so it should definitely be feasible. I'd like to avoid adding a pointer and allocating it if it can't be helped. And properly integrating each context into the AVClass system as a child of the parent context. If you think a NULL av_log is valid (you implied that a year ago), then I'm more than happy to drop this patch. --------------0EBSFnI005Zg4ktQBUSqhuRM Content-Type: application/pgp-keys; name="OpenPGP_0xA2FEA5F03F034464.asc" Content-Disposition: attachment; filename="OpenPGP_0xA2FEA5F03F034464.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: 7bit -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEXnFG3BYJKwYBBAHaRw8BAQdA3FyJpqEdfQj4GA7OUWVrNheT9dUsIs+yUx6H ljr9mYvNFEx5bm5lIDxkZXZAbHlubmUuZWU+wpAEExYIADgWIQT+UBOcaAVyyv1S H42i/qXwPwNEZAUCXnFG3AIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRCi /qXwPwNEZOTWAQCSNEA+kZLINZ2dsR5Qg988c0HXpOXThZEjg+h1TL7KGgEA3Gff 0c28efI02S6iMxazrpdWGHqHk7JN7pCjnt397wzOOARecUbcEgorBgEEAZdVAQUB AQdAjDdFQ5H+AJ9vwXrOb7val460g45EsheIaL5S7/zSaX8DAQgHwngEGBYIACAW IQT+UBOcaAVyyv1SH42i/qXwPwNEZAUCXnFG3AIbDAAKCRCi/qXwPwNEZKaxAQCH LV4gAk/B9JvRG27MYm22X3+5QRCLBtEILP29aDh+MQD/V8JFHATDXRY30LsmqR3s PQ0BJ1UFVZA5BUoIJPJZWwg= =ylY5 -----END PGP PUBLIC KEY BLOCK----- --------------0EBSFnI005Zg4ktQBUSqhuRM-- --------------OAZXVfTiIhr03O0vTJJZAo4o-- --------------TywZ0OYdZNsfOVaw0ky4w5Ce Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQT+UBOcaAVyyv1SH42i/qXwPwNEZAUCZqNfVAUDAAAAAAAKCRCi/qXwPwNEZOc4 AP9JRA8n8N0G8hy2n1NMcaTadHR9lLc6kXofzKmpfDShywD/ao1TDf+FMSE6NH13f1cW/X31GnSQ suS8jbdQilWI9gw= =qm/7 -----END PGP SIGNATURE----- --------------TywZ0OYdZNsfOVaw0ky4w5Ce-- --===============8459828221138592336== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8459828221138592336==--