Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: James Almer <jamrial-at-gmail.com@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/5] avformat/mov: Check that sample_count is allocated in mov_parse_heif_items()
Date: Mon, 23 Jun 2025 11:43:04 -0300
Message-ID: <05b7f838-3271-4646-a5f6-4cc92a28e799@gmail.com> (raw)
In-Reply-To: <20250621211521.895204-1-michael@niedermayer.cc>


[-- Attachment #1.1.1: Type: text/plain, Size: 956 bytes --]

On 6/21/2025 6:15 PM, Michael Niedermayer wrote:
> Fixes: NULL pointer dereference
> Fixes: 416811958/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5425269114732544
> 
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>   libavformat/mov.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 8a094b1ea0a..6e9e3498fb5 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -10336,7 +10336,7 @@ static int mov_parse_heif_items(AVFormatContext *s)
>           st->codecpar->height = item->height;
>   
>           err = sanity_checks(s, sc, item->item_id);
> -        if (err)
> +        if (err || !sc->sample_count)
>               return AVERROR_INVALIDDATA;
>   
>           sc->sample_sizes[0]  = item->extent_length;

LGTM

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2025-06-23 14:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-21 21:15 Michael Niedermayer
2025-06-21 21:15 ` [FFmpeg-devel] [PATCH 2/5] avformat/mov: Check edit_list_dts_entry_end Michael Niedermayer
2025-06-21 21:15 ` [FFmpeg-devel] [PATCH 3/5] avcodec/rv60dec: Check sum in read_slice_sizes() Michael Niedermayer
2025-06-22  4:38   ` Peter Ross
2025-06-28  0:27     ` Michael Niedermayer
2025-06-21 21:15 ` [FFmpeg-devel] [PATCH 4/5] avformat/iff: Check nb_channels == 0 in CHNL Michael Niedermayer
2025-06-22  4:40   ` Peter Ross
2025-06-23 14:33     ` Michael Niedermayer
2025-06-21 21:15 ` [FFmpeg-devel] [PATCH 5/5] avcodec/cbs_apv_syntax_template: Check tile_data_size Michael Niedermayer
2025-06-23 14:43 ` James Almer [this message]
2025-06-24 21:19   ` [FFmpeg-devel] [PATCH 1/5] avformat/mov: Check that sample_count is allocated in mov_parse_heif_items() Michael Niedermayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05b7f838-3271-4646-a5f6-4cc92a28e799@gmail.com \
    --to=jamrial-at-gmail.com@ffmpeg.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git