Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Leo Izen <leo.izen@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v4] avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL
Date: Wed, 22 Feb 2023 08:49:34 -0500
Message-ID: <05b25416-fbe8-9c30-df47-181496186dc6@gmail.com> (raw)
In-Reply-To: <CAEEMt2k078WbM9ChNe+VRXf0hVAO9L66DM7hcdsKDCMH5E=JYg@mail.gmail.com>

On 2/21/23 20:42, Ronald S. Bultje wrote:
> Hi,
> 
> On Tue, Feb 21, 2023 at 5:36 PM Leo Izen <leo.izen@gmail.com 
> <mailto:leo.izen@gmail.com>> wrote:
> 
>     These chunks are lightweight and it's useful information to have when
>     running ffmpeg -i or ffprobe, for example.
> 
> 
> I disagree conceptually with this. If we want to skip "all" decoding, we 
> should also skip metadata for said frames.
> 
> I think what we're looking for here is a partial decoding stage, e.g. 
> "header-only" or similar, instead of "including framedata", for some or 
> all frames. That's orthogonal to AVDISCARD_*.
> 
> Ronald

The issue is that libavformat and ffmpeg.c obtain metadata by calling 
the decoder with AVDISCARD_ALL. What you're proposing would require a 
structural change elsewhere, and I'm not sure it makes sense to block a 
patch like this one based on a hypothetical change elsewhere.

- Leo Izen (thebombzen)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-02-22 13:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 22:35 Leo Izen
2023-02-22  1:42 ` Ronald S. Bultje
2023-02-22 13:49   ` Leo Izen [this message]
2023-02-22 16:32     ` Ronald S. Bultje
2023-02-27 16:34 ` Leo Izen
2023-02-28 19:46   ` Leo Izen
2023-12-11  4:20     ` Kacper Michajlow
2023-12-11 11:54       ` Leo Izen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05b25416-fbe8-9c30-df47-181496186dc6@gmail.com \
    --to=leo.izen@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git