From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E0AE848E01 for ; Tue, 27 Feb 2024 23:20:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0452068C891; Wed, 28 Feb 2024 01:20:57 +0200 (EET) Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9FAF168A62B for ; Wed, 28 Feb 2024 01:20:49 +0200 (EET) Received: by mail-oi1-f174.google.com with SMTP id 5614622812f47-3bbbc6bcc78so3578890b6e.1 for ; Tue, 27 Feb 2024 15:20:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709076047; x=1709680847; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=A8BxpNAFnHZxWLsBI5grA4haHrGBgw+maWrCPPNJpYs=; b=N7o8VfSIlucL78PD29NxmIt58jL8Kit0GI+zbixq++I9Tf0PoofO7IkF5iYxaobJRI EiZil/rL5DkgUpk2iH3rY612ZUrZvLk41PTP9vhEC8LNNitjEIlptzsdl4s2bRdLrzad +ZrrVsZi8fhcdZXlZXYt0CQ8FEeW79tqXhqBMqn8XdXQWVHliyspIAHCIaBAAmdu8xPP LQ5QUnLxGpVMe4h5OlrjxnFDxPMLZPiWz8pWO1tBIs+xC141CUUaGv64rSpnHvXJjnxv WoAQ2GGxGPqUaLJXFXCkTOJ6uCOEoj8V8Ym+tPIOT45teLoDX3dgsV1jVRIehSvm53vs GULA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709076047; x=1709680847; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A8BxpNAFnHZxWLsBI5grA4haHrGBgw+maWrCPPNJpYs=; b=NPS7mgVZxEMfiPdbcbe/g+/ojmf8Izw9nCHnhe7xG/8S88B5eSN5OX7QrbXkzvq+gD AcE2d2/eoe6D6gPFbMf3+J4maDj3FeI8cEWfNaNS1DQEInX0Cp4sOAVsnzhfxP0+IfF9 ZQ8bauM8wkp6B5oqJic6LBXI+NsAynYWxCDdibDE5vUdheSYivEQEZUjeFE/JqeYlyX7 jxtRo9dLkz7Axk6d7L3bDQbqqnB0nNOSMY/nJZf8Kn1yL5ICmUHMzVV55hXqL0j4nbaQ N/XN56z0QMPuzQIARvLJP2omKNj34KDnE9l1hXWgfUk+m8Mae+I7NFFxb9iYbjyu9Y5k 1inw== X-Gm-Message-State: AOJu0YzEm7oCAAqZblJhBfAmRm0BPqtq5N8dOTI6/USHbkoaAgT+WOnq 3d2GjBoOxsMOP+SGUdwvS6t8t1VEorpPJ9dkOk2PMYC98YQLzioT0K6CyQJZ X-Google-Smtp-Source: AGHT+IGgrwEPfp6qMcc5JC9D4STtBT6VDb8MMtUxmBf80FK/hrKG4dkUPuLF9yTvkSnGkBDE3LLoIg== X-Received: by 2002:a05:6808:5c3:b0:3c1:9a76:b41f with SMTP id d3-20020a05680805c300b003c19a76b41fmr3068820oij.28.1709076047341; Tue, 27 Feb 2024 15:20:47 -0800 (PST) Received: from [192.168.0.11] ([190.194.169.124]) by smtp.gmail.com with ESMTPSA id e5-20020a056a0000c500b006e530aca55asm4055678pfj.123.2024.02.27.15.20.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Feb 2024 15:20:46 -0800 (PST) Message-ID: <05208d98-4cfa-4127-8216-9d2cf4838c61@gmail.com> Date: Tue, 27 Feb 2024 20:20:44 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240227221226.1377758-1-jeebjp@gmail.com> <20240227221226.1377758-7-jeebjp@gmail.com> From: James Almer In-Reply-To: <20240227221226.1377758-7-jeebjp@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH v6 06/13] avutil/frame: add helper for adding existing side data to set X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: T24gMi8yNy8yMDI0IDc6MTIgUE0sIEphbiBFa3N0csO2bSB3cm90ZToKPiAtLS0KPiAgIGxpYmF2 dXRpbC9mcmFtZS5jIHwgNDkgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysKPiAgIGxpYmF2dXRpbC9mcmFtZS5oIHwgMTkgKysrKysrKysrKysrKysrKysrCj4g ICAyIGZpbGVzIGNoYW5nZWQsIDY4IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvbGli YXZ1dGlsL2ZyYW1lLmMgYi9saWJhdnV0aWwvZnJhbWUuYwo+IGluZGV4IGQ5NzQxMjQwZTcuLjk5 YzljZTQxMTkgMTAwNjQ0Cj4gLS0tIGEvbGliYXZ1dGlsL2ZyYW1lLmMKPiArKysgYi9saWJhdnV0 aWwvZnJhbWUuYwo+IEBAIC0xMTAsNiArMTEwLDIzIEBAIHN0YXRpYyB2b2lkIHJlbW92ZV9zaWRl X2RhdGEoQVZGcmFtZVNpZGVEYXRhICoqKnNkLCBpbnQgKm5iX3NpZGVfZGF0YSwKPiAgICAgICB9 Cj4gICB9Cj4gICAKPiArc3RhdGljIHZvaWQgcmVtb3ZlX3NpZGVfZGF0YV9ieV9lbnRyeShBVkZy YW1lU2lkZURhdGEgKioqc2QsIGludCAqbmJfc2QsCj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgY29uc3QgQVZGcmFtZVNpZGVEYXRhICp0YXJnZXQpCj4gK3sKPiArICAg IGZvciAoaW50IGkgPSAqbmJfc2QgLSAxOyBpID49IDA7IGktLSkgewo+ICsgICAgICAgIEFWRnJh bWVTaWRlRGF0YSAqZW50cnkgPSAoKCpzZClbaV0pOwo+ICsgICAgICAgIGlmIChlbnRyeSAhPSB0 YXJnZXQpCj4gKyAgICAgICAgICAgIGNvbnRpbnVlOwo+ICsKPiArICAgICAgICBmcmVlX3NpZGVf ZGF0YSgmZW50cnkpOwo+ICsKPiArICAgICAgICAoKCpzZClbaV0pID0gKCgqc2QpWypuYl9zZCAt IDFdKTsKPiArICAgICAgICAoKm5iX3NkKS0tOwo+ICsKPiArICAgICAgICByZXR1cm47Cj4gKyAg ICB9Cj4gK30KPiArCj4gICBBVkZyYW1lICphdl9mcmFtZV9hbGxvYyh2b2lkKQo+ICAgewo+ICAg ICAgIEFWRnJhbWUgKmZyYW1lID0gYXZfbWFsbG9jKHNpemVvZigqZnJhbWUpKTsKPiBAQCAtODcy LDYgKzg4OSwzOCBAQCBBVkZyYW1lU2lkZURhdGEgKmF2X2ZyYW1lX3NpZGVfZGF0YV9uZXcoQVZG cmFtZVNpZGVEYXRhICoqKnNkLCBpbnQgKm5iX3NkLAo+ICAgICAgIHJldHVybiByZXQ7Cj4gICB9 Cj4gICAKPiAraW50IGF2X2ZyYW1lX3NpZGVfZGF0YV9mcm9tX3NkKEFWRnJhbWVTaWRlRGF0YSAq KipzZCwgaW50ICpuYl9zZCwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0 IEFWRnJhbWVTaWRlRGF0YSAqc3JjLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg dW5zaWduZWQgaW50IGZsYWdzKQo+ICt7Cj4gKyAgICBpZiAoIXNkIHx8ICFzcmMgfHwgIW5iX3Nk IHx8ICgqbmJfc2QgJiYgISpzZCkpCj4gKyAgICAgICAgcmV0dXJuIEFWRVJST1IoRUlOVkFMKTsK PiArCj4gKyAgICB7Cj4gKyAgICAgICAgQVZCdWZmZXJSZWYgICAgICAgICAgICpidWYgICAgPSBh dl9idWZmZXJfcmVmKHNyYy0+YnVmKTsKPiArICAgICAgICBBVkZyYW1lU2lkZURhdGEgICAgICAg KnNkX2RzdCA9IE5VTEw7Cj4gKwo+ICsgICAgICAgIGlmIChmbGFncyAmIEFWX0ZSQU1FX1NJREVf REFUQV9TRVRfRkxBR19OT19EVVBMSUNBVEVTKQo+ICsgICAgICAgICAgICByZW1vdmVfc2lkZV9k YXRhKHNkLCBuYl9zZCwgc3JjLT50eXBlKTsKPiArCj4gKyAgICAgICAgc2RfZHN0ID0gYWRkX3Np ZGVfZGF0YV90b19zZXRfZnJvbV9idWYoc2QsIG5iX3NkLCBzcmMtPnR5cGUsIGJ1Zik7Cj4gKyAg ICAgICAgaWYgKCFzZF9kc3QpIHsKPiArICAgICAgICAgICAgYXZfYnVmZmVyX3VucmVmKCZidWYp Owo+ICsgICAgICAgICAgICByZXR1cm4gQVZFUlJPUihFTk9NRU0pOwo+ICsgICAgICAgIH0KPiAr Cj4gKyAgICAgICAgewo+ICsgICAgICAgICAgICBpbnQgcmV0ID0gYXZfZGljdF9jb3B5KCZzZF9k c3QtPm1ldGFkYXRhLCBzcmMtPm1ldGFkYXRhLCAwKTsKPiArICAgICAgICAgICAgaWYgKHJldCA8 IDApIHsKPiArICAgICAgICAgICAgICAgIHJlbW92ZV9zaWRlX2RhdGFfYnlfZW50cnkoc2QsIG5i X3NkLCBzZF9kc3QpOwo+ICsgICAgICAgICAgICAgICAgcmV0dXJuIHJldDsKPiArICAgICAgICAg ICAgfQo+ICsgICAgICAgIH0KPiArCj4gKyAgICAgICAgcmV0dXJuIDA7Cj4gKyAgICB9Cj4gK30K PiArCj4gICBBVkZyYW1lU2lkZURhdGEgKmF2X2ZyYW1lX2dldF9zaWRlX2RhdGEoY29uc3QgQVZG cmFtZSAqZnJhbWUsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ZW51bSBBVkZyYW1lU2lkZURhdGFUeXBlIHR5cGUpCj4gICB7Cj4gZGlmZiAtLWdpdCBhL2xpYmF2 dXRpbC9mcmFtZS5oIGIvbGliYXZ1dGlsL2ZyYW1lLmgKPiBpbmRleCA3MjZjYTE5YTAzLi40N2Qw MDk2YmM0IDEwMDY0NAo+IC0tLSBhL2xpYmF2dXRpbC9mcmFtZS5oCj4gKysrIGIvbGliYXZ1dGls L2ZyYW1lLmgKPiBAQCAtMTA4MSw2ICsxMDgxLDI1IEBAIEFWRnJhbWVTaWRlRGF0YSAqYXZfZnJh bWVfc2lkZV9kYXRhX25ldyhBVkZyYW1lU2lkZURhdGEgKioqc2QsIGludCAqbmJfc2QsCj4gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZW51bSBBVkZyYW1lU2lkZURh dGFUeXBlIHR5cGUsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg c2l6ZV90IHNpemUsIHVuc2lnbmVkIGludCBmbGFncyk7Cj4gICAKPiArLyoqCj4gKyAqIEFkZCBh IG5ldyBzaWRlIGRhdGEgZW50cnkgdG8gYSBzZXQgYmFzZWQgb24gZXhpc3Rpbmcgc2lkZSBkYXRh LCB0YWtpbmcKPiArICogYSByZWZlcmVuY2UgdG93YXJkcyB0aGUgY29udGFpbmVkIEFWQnVmZmVy UmVmLgo+ICsgKgo+ICsgKiBAcGFyYW0gc2QgICAgcG9pbnRlciB0byBhcnJheSBvZiBzaWRlIGRh dGEgdG8gd2hpY2ggdG8gYWRkIGFub3RoZXIgZW50cnkuCj4gKyAqIEBwYXJhbSBuYl9zZCBwb2lu dGVyIHRvIGFuIGludGVnZXIgY29udGFpbmluZyB0aGUgbnVtYmVyIG9mIGVudHJpZXMgaW4KPiAr ICogICAgICAgICAgICAgIHRoZSBhcnJheS4KPiArICogQHBhcmFtIHNyYyAgIHNpZGUgZGF0YSB3 aGljaCBzaG91bGQgYmUgYWRkZWQgdG8gdGhlIHNldAo+ICsgKiBAcGFyYW0gZmxhZ3MgU29tZSBj b21iaW5hdGlvbiBvZiBBVl9GUkFNRV9TSURFX0RBVEFfU0VUX0ZMQUdfKiBmbGFncywgb3IgMC4K PiArICoKPiArICogQHJldHVybiBuZWdhdGl2ZSBlcnJvciBjb2RlIG9uIGZhaWx1cmUsID49MCBv biBzdWNjZXNzLiBJbiBjYXNlIG9mCj4gKyAqICAgICAgICAgQVZfRlJBTUVfU0lERV9EQVRBX1NF VF9GTEFHX05PX0RVUExJQ0FURVMgYmVpbmcgc2V0LCBlbnRyaWVzCj4gKyAqICAgICAgICAgb2Yg bWF0Y2hpbmcgQVZGcmFtZVNpZGVEYXRhVHlwZSB3aWxsIGJlIHJlbW92ZWQgYmVmb3JlIHRoZQo+ ICsgKiAgICAgICAgIGFkZGl0aW9uIGlzIGF0dGVtcHRlZC4KPiArICovCj4gK2ludCBhdl9mcmFt ZV9zaWRlX2RhdGFfZnJvbV9zZChBVkZyYW1lU2lkZURhdGEgKioqc2QsIGludCAqbmJfc2QsCj4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBBVkZyYW1lU2lkZURhdGEgKnNy YywKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBmbGFncyk7 CgpUaGlzIGlzIHByZXR0eSBsaW1pdGluZyBhcyBpdCB3b3JrcyBvbmx5IHdpdGggYWxyZWFkeSBl eGlzdGluZyAKQVZGcmFtZVNpZGVEYXRhIGVudHJpZXMuIElmIHlvdSBoYXZlIGEgYnVmZmVyIHRo YXQgeW91IHdhbnQgdG8gaW5zZXJ0IHRvIAphbiBhcnJheSBhcyBhIG5ldyBBVkZyYW1lU2lkZURh dGEgZW50cnksIHRoZW4gdGhpcyB3aWxsIG5vdCBkby4KSSB0aGluayBpdCB3b3VsZCBiZSBiZXR0 ZXIgdG8gbWFrZSBpdCB0YWtlIGFuIEFWQnVmZmVyUmVmIGFzIGlucHV0LCBsaWtlIAp0aGUgZXhp c3RpbmcgYXZfZnJhbWVfbmV3X3NpZGVfZGF0YV9mcm9tX2J1ZigpIGRvZXMsIHdoaWNoIGNhbiB0 aGVuIHdvcmsgCmluIGFueSBjYXNlLgoKaW50IGF2X2ZyYW1lX3NpZGVfZGF0YV9hZGQoQVZGcmFt ZVNpZGVEYXRhICoqKnNkLCBpbnQgKm5iX3NkLAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ZW51bSBBVkZyYW1lU2lkZURhdGFUeXBlIHR5cGUsCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICBBVkJ1ZmZlclJlZiAqYnVmLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQg aW50IGZsYWdzKTsKCkFuZCBzdWNoIGEgZnVuY3Rpb24gc2hvdWxkIGNyZWF0ZSBhIG5ldyByZWYg dG8gYnVmIHJhdGhlciB0aGFuIHRha2luZyAKb3duZXJzaGlwIG9mIGl0IGxpa2UgYXZfZnJhbWVf bmV3X3NpZGVfZGF0YV9mcm9tX2J1ZigpIGRvZXMsIHdoaWNoIGlzIGEgCmJpdCBhd2t3YXJkLgoK PiArCj4gICAvKioKPiAgICAqIEB9Cj4gICAgKi8KX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZmZtcGVnLWRldmVsIG1haWxpbmcgbGlzdApmZm1wZWctZGV2 ZWxAZmZtcGVnLm9yZwpodHRwczovL2ZmbXBlZy5vcmcvbWFpbG1hbi9saXN0aW5mby9mZm1wZWct ZGV2ZWwKClRvIHVuc3Vic2NyaWJlLCB2aXNpdCBsaW5rIGFib3ZlLCBvciBlbWFpbApmZm1wZWct ZGV2ZWwtcmVxdWVzdEBmZm1wZWcub3JnIHdpdGggc3ViamVjdCAidW5zdWJzY3JpYmUiLgo=