From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9AC504119E for ; Tue, 4 Jan 2022 02:37:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 47BE768B20B; Tue, 4 Jan 2022 04:37:21 +0200 (EET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0137368B195 for ; Tue, 4 Jan 2022 04:37:14 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641263840; x=1672799840; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=/qbU2T6UdWLA1sI+W46nxeESOHA2q+vcR/6xp429dUY=; b=mEX79TDGBrAFWvtUndVN+cQ7wlUCrmyt36j0bmBcNBhUVH1cFLB1EBmN M3LLaWNm1PJU/SXHmd0M3+eNyVECRarFAABFZRl7GBLBUYUDz3nAR8PVr LpCWleJZTjil5ni0ygLGmCL6IPiRU7Tv3h8crZX0jnJEXaKiD1vt4k/DE o8NgSo0C8ZXyYZcHif0yR5hFPQCqmYrKFbvBiX9jBv+OOREzmaWgdALn1 4AeCTCwJIhebClGEBdmYELWT1yi2t2847wC/yKyQov/lyonOwg0Ev1qHI QgUHVan1F9petiw7nzlbK+oXsw+v60hS8K92sV6X7lOexAywJlGgpnLuP w==; X-IronPort-AV: E=McAfee;i="6200,9189,10216"; a="242100073" X-IronPort-AV: E=Sophos;i="5.88,258,1635231600"; d="scan'208";a="242100073" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jan 2022 18:37:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,258,1635231600"; d="scan'208";a="556025945" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga001.jf.intel.com with ESMTP; 03 Jan 2022 18:37:09 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 3 Jan 2022 18:37:08 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 3 Jan 2022 18:37:08 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 3 Jan 2022 18:37:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MU07KkXZyPPXi7ifW1NDG3SYhbAP00HXRkprQcAgb8FnvLYlOlirc9n+G0Ljl9oRV8nohQUwO2LCMoP/PJ8ACN3b/F2/u+oZE2Fa4OxGFBGgxu18TxizRbnRDxysNR81nXyUeMxdrq99ZHLFRr7fJFmbYkpL0ko/7eOxtpDqIq6hJnulRIWG4awlED3BulW514DgA6EvQpjaS7c5uJ6AdPaLk9nf/Mc0gzI82qbC6zaB/npECUb6k7zYy4laA+iINWLpWR5L+BC8U95dW41WnBxkjH767zW94SN53OxE2ZtYB96byXaL1wcZSMUQHoMA/Kva/11ZtSLM2KUkSclfeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/qbU2T6UdWLA1sI+W46nxeESOHA2q+vcR/6xp429dUY=; b=C/K5wwKfHtyKVSyZ2OdI2mIWCL1gE9qqe/TV5jNIzRP73/INjGbqnE4FrWjiJCTBelE55KwdtBy+WzjocrgZOw87Beuh1zSgE+rVLcU/zaxfRF6tITOwSsudhN0xBqdG/LSDHSdD4blf+rZY4i2I44f7xqGDEuD4XDQ3/xp0Snqpog/KVUu63TcP/Xs19qzbFPQAi5NwobgF7Qb64M+C5WTvrDg4Sa5svfGyUzkvzLRP1813RpwPo/ClolfE+/p0T+oZk5fZMV80DxgyVCAxrHt362jmTwboLhxUOz0KPYPLNx5oNEoRJMguvST/6ZzMOdy+EHO8aIWDeZT+zbVMBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BN9PR11MB5291.namprd11.prod.outlook.com (2603:10b6:408:118::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.13; Tue, 4 Jan 2022 02:37:06 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843%4]) with mapi id 15.20.4844.016; Tue, 4 Jan 2022 02:37:06 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" , "softworkz@hotmail.com" Thread-Topic: [FFmpeg-devel] [PATCH v2] avfilter/vpp_qsv: fix regression on older api versions (e.g. 1.11) Thread-Index: AQHX/4q8dtdgWGYF0U24GWemf7V/l6xSIvaAgAACuwCAAAMkAA== Date: Tue, 4 Jan 2022 02:37:06 +0000 Message-ID: <0502a94957a712f4a4e79f1e85423fe962653f24.camel@intel.com> References: <56d6ca16679da102a94bd5d330777324cc0a200a.camel@intel.com> In-Reply-To: Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2a401485-e3d3-4947-1b6e-08d9cf2b1920 x-ms-traffictypediagnostic: BN9PR11MB5291:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:580; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WMilflQs4Cvfccz6oYiPxtAzpmwAkuv7RDJJVTdSNOnOb3QWXf4IwgqwpRAYRsz/UjvVSjLoB62y0FWBNl9T/5CaX6F9R/kPldp1F6B+b7DIbQzewMWw/eIuC9rq6Xw0goK1jGsJHwpSgb+QhWtr/cQ68ASeT0EzjImahe9rUMEP4kt1hvAh+GeCShTFqsjA6HaDF8zQ8/Y7ihgVz6m5NUEIDr1Ih5jDZYPWcnHBo5FFJ0wd5uPbJ73OThNqcU9/BwNxv94Sto9ZhqmyhnkvfxLPHtjbPNmflMvu20CdqSMnqB1vHdAbKLJr/rc1ahv2KI9VGUXOqnrqb/o+YIcdO9aKMtPK9VjDJQwlNxP6AZCYNlzpM5BGS9gmYwaTuuGUoDUMyP8m9/BGkqINN+bwnZmQxkNb4hxmFKkhTsV5HsOWuFA0UZEv5SJCwhhf1MFRvglHEmzmDVrEroW62wJfHew9aK0xFM6RPI93TArV9dHgvxQ5GQZLbKoBfCKNCmtLzJdClt5aZ9A4bxatN3cziR2f0TdTaFedeDrcEtgKcbVB6enk1hQ8ngDLOjlEuWyBEgoPrJtM51LuPMCu/K1Bl1uuwBEWQzDmvGcuM4yRZOkSNSoEdTjEuqyQxXpG7jzksIN4HLsoqz3HEaT8dQLSH+FG4N78N3SMQ5YQBh2wCH6/Fq+H79G84KkUanN/xd3n1n11/Bei8gp4ulMFgrNTtQMVRKkxCa9ZyrSWHjD4BELk7OkEfdDzAQKhlISalLXN+f4E7VDWpF1Xo0vovA6spYAyiZ+/befUzP0w0mHCv7zRU0WY7Dmhwe/6BBIWeJlHb/DzJNElNb2VmlukdVWvPEGQZCD4kf+/FXjmgNexka0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2906002)(110136005)(76116006)(82960400001)(122000001)(38100700002)(2616005)(45080400002)(6512007)(316002)(86362001)(8676002)(6486002)(83380400001)(66946007)(966005)(53546011)(26005)(66476007)(66556008)(5660300002)(186003)(8936002)(38070700005)(36756003)(66446008)(91956017)(6506007)(71200400001)(64756008)(508600001)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cEdqQ0IrMzJFZW9hMXZhYW95OVJ1azd2cFF4b0QwQkFnRHR3MTAxdHFBZGJo?= =?utf-8?B?dHFjT0ZaOUhHYTNlaUtLK21SZDEyOVA0UDBmaEgrUFdWbGVZL3p5UVFJU0Na?= =?utf-8?B?Yjl6RE5HQWJSWk5mZnY0dEFST3lDQ0svRGFveU0vTWkxSTA2dzdxVGpYekht?= =?utf-8?B?SlFtclZCY1J3TDBmWnkxRm5MWS9ySTJJdWd3c3ZvaUcwUjVyVDMrVFp3UlhY?= =?utf-8?B?VjYyY0p6SVdaZFlvaVVTOGNNRFJPM0p3ZVk1RTVMcTJhRXp1Q3pldnpxcGFq?= =?utf-8?B?VGY1UW04WDdYaE5zM0RSa1MyZkNYaEVxVmdhdDZ6d1RhZmZMaFp0VUt0Q2Jx?= =?utf-8?B?RDc5bDBrb2x2YzNqUEk3bHBhNXlqOUc0WDl5SCtSc3V6Y2txbVlRc2ptV3ll?= =?utf-8?B?eEhEYXljeHV1RVM3SjZHS0N4NktPMGJpbVBsTEZQRzVLbnV3dW11V1JPZ0lz?= =?utf-8?B?R09JWEQxaVo1RXExajBqY1ZnYnlJaVVkMXBCU2JJZ2pLTUNPSHB2K3VHZ2Va?= =?utf-8?B?cTFQYnFpSkhsY0x5M3lTZDQzSEhaT1pUS0orRDhqZVIzbWhMOFJhYnloeE9v?= =?utf-8?B?MUt0bnVHY3VLdU50S3JXVFhCQ1A1WC9OZXl0c2dGVDJQTEJYbEowNExORnI1?= =?utf-8?B?dVM3RWhuTHhyQWd5ZWZKK1ZwdFMwT20wdGl0OW5Zby9oOTlVOU1lVGdzRFVk?= =?utf-8?B?TllqaDhQTXJOZnFuSWdzZE44RkZyai9BdzRLTVF4bkNoVXZsQVc0d3BINHEv?= =?utf-8?B?VXRSK0RKY1VvVkNlV2hiQWpmMllMVDl1alp3ZUlGY0F0RGJqU2VVM3poaFpv?= =?utf-8?B?enkvVnhYelRkOG4vNGFTSHNHNGFpMllxUlI5Q2JrK2ZjSHBVNGtONUNDR3BC?= =?utf-8?B?NDRtU25DbmgwMnRNZWh3VDFOb20zUk8xV2tJMCtPTkF2UDc4L1lBSDUrc0J1?= =?utf-8?B?Vkh4MndkNEE2ejhHUFN0VzlpcVFMK0pTMFJOYUhHdmRERlViSzhyOFZhVHBj?= =?utf-8?B?WUlxMmZXK1VIbGxTV0lkVEpuaENLZGRLZkZpU3JLc0hPMUhQOGFEV2owMkRp?= =?utf-8?B?aFRDSDRxQlZacmJLY3VIWXpudng3V0I1c3BNdlpPTWl1SlgydDNjU3lwdzVN?= =?utf-8?B?UU5pUng1VTRROFY2NndNQjI2bXpCMW9QbncyY0VUQXZhenRCcm41ZmtSWFZN?= =?utf-8?B?ZmRUa1ZGQ3VLaDM1aVhyN054M1R2ek5rdm5iRkwzWUh6UmxYVjRrVTQrQ3Yv?= =?utf-8?B?R1U0bGdheWlyMnNQWExNa0E5VncrZDNmUTdUVU00eVFBUXpMMEtoYTlzQ2Jt?= =?utf-8?B?YWRHQkF0NEc5OU5qSzVlQW1YYjMxeGR6VE1INTFiZ054Y0FpU1FXUzlNTndI?= =?utf-8?B?VVVxRktlY2MrYVhhOHVUR3QxMkZvdkROS0prOHNET3EyOHhyK2RqRnpmalNs?= =?utf-8?B?bW8zRlI0SnpibC9JOXVRSzkvOHVSc1M4aHc3Q3AvMEswdE5UTVRtbWtXeG1W?= =?utf-8?B?VWU3R2J4bmg4bWFEanJHaCtHdytmVko4bERzbEFxbzU5MGhxQzZ0aTJDWW5o?= =?utf-8?B?UHFsV0Y2L0p3TndLRnQvQklpZy9BUi9LVi9YNWptUUxMWjlVVng0T3dBbDVO?= =?utf-8?B?cVMrK3VESkFFYlhkNlZJWUdGN21jZUxRTmVIcWpIaFU3QnplUUtGUmdyYm1V?= =?utf-8?B?TnJSVWE0MGlZSjNwOCtpRDNFRndBcnllMitJc1U5dGxhRm9MczlYUDVaUEFS?= =?utf-8?B?d0MxY2o4aEFpb2ZRdW1uNDRtbWJKNm1yVUNPTlVlWlJoMUxsQmpNemRrK2JU?= =?utf-8?B?bWJFSndJT2MyNGxrL1NhNHZGREFKUEJyK05ZY282cHZRb1BhWkE4TGRyZFlB?= =?utf-8?B?RjZNV2pUVnJ6NEpSUG9ZNVNJY2liNm9SRVkzOEZHeEk2Qzg3aG14Um9UM2JM?= =?utf-8?B?OEx4anVFZGhTRi9IcEIveHBPUkpUSFo5ai9TRzdDcDFPbUdvZzJkQkxZRS82?= =?utf-8?B?anVURUhuZTlSS04rdk5pV08ranQwWVdZQkpXWjFHa0J6S3pxSExTRGxHR2lr?= =?utf-8?B?NzBkQzd5TzUrZ1gxWHY0VXZodGV1Ykd0UHdFYUkveWorQUJISE1MNlhHNnFO?= =?utf-8?B?R0MwVzUxeUduNzZrMmltdFd3NHR2R3owMGVpR3VCYkEyZTZ6b0pzdFBRL25k?= =?utf-8?Q?ypsV4xEccPDTJbJ7VbBpkec=3D?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a401485-e3d3-4947-1b6e-08d9cf2b1920 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2022 02:37:06.1400 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BO/JDTDL36fl/1o6qFo3vYhYYvwBmHoVNlVsJKUJIrQROTeCcOpedSZvmjRugZVJh8CiETt3mnNr9s+jLhttEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5291 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2] avfilter/vpp_qsv: fix regression on older api versions (e.g. 1.11) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 2022-01-04 at 02:25 +0000, Soft Works wrote: > > -----Original Message----- > > From: Xiang, Haihao > > Sent: Tuesday, January 4, 2022 3:16 AM > > To: ffmpeg-devel@ffmpeg.org > > Cc: softworkz@hotmail.com > > Subject: Re: [FFmpeg-devel] [PATCH v2] avfilter/vpp_qsv: fix regression on > > older api versions (e.g. 1.11) > > > > On Sun, 2022-01-02 at 03:41 +0000, ffmpegagent wrote: > > > From: softworkz > > > > > > Commit 8b83dad82512a6948b63408f964463b063ad24c9 introduced a > > > regression in a way that scaling via vpp_qsv doesn't work any longer > > > for devices with an MSDK runtime version lower than 1.19. This is true > > > for older CPUs which are stuck at 1.11. > > > The commit added checks for the compile-sdk version but it didn't test > > > for the runtime version. > > > > > > Signed-off-by: softworkz > > > --- > > > avfilter/vpp_qsv: fix regression on older api versions (e.g. 1.11) > > > > > > Fix a recently introduced regression when using QSV VPP. > > > > > > v2: Fixed commit message wrapping > > > > > > Published-As: > > > https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging- > > > > 15%2Fsoftworkz%2Fqsv_vpp_regression-v2 > > > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging- > > > 15/softworkz/qsv_vpp_regression-v2 > > > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/15 > > > > > > Range-diff vs v1: > > > > > > 1: eea966f702 ! 1: ccede9d840 avfilter/vpp_qsv: fix regression on older > > > > api > > > versions (e.g. 1.11) > > > @@ Metadata > > > ## Commit message ## > > > avfilter/vpp_qsv: fix regression on older api versions (e.g. > > > > 1.11) > > > > > > - Commit 8b83dad82512a6948b63408f964463b063ad24c9 introduced a > > > regression in a way > > > - that scaling via vpp_qsv didn't work any longer for devices with > > > > an > > > MSDK runtime > > > - version lower than 1.19. This is true for older CPUs which are > > > > stuck > > > at 1.11. > > > - The commit added checks for the compile-sdk version but it > > > didn't > > > test for the > > > - runtime version. > > > + Commit 8b83dad82512a6948b63408f964463b063ad24c9 introduced a > > > + regression in a way that scaling via vpp_qsv doesn't work any > > > > longer > > > + for devices with an MSDK runtime version lower than 1.19. This > > > is > > > true > > > + for older CPUs which are stuck at 1.11. > > > + The commit added checks for the compile-sdk version but it > > > didn't > > > test > > > + for the runtime version. > > > > > > Signed-off-by: softworkz > > > > > > > > > > > > libavfilter/vf_vpp_qsv.c | 32 ++++++++++++++++++++------------ > > > 1 file changed, 20 insertions(+), 12 deletions(-) > > > > > > diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c > > > index ab58a5777e..09590157e3 100644 > > > --- a/libavfilter/vf_vpp_qsv.c > > > +++ b/libavfilter/vf_vpp_qsv.c > > > @@ -139,8 +139,9 @@ static const AVOption options[] = { > > > { "height", "Output video height", OFFSET(oh), AV_OPT_TYPE_STRING, { > > > .str="w*ch/cw" }, 0, 255, .flags = FLAGS }, > > > { "format", "Output pixel format", OFFSET(output_format_str), > > > AV_OPT_TYPE_STRING, { .str = "same" }, .flags = FLAGS }, > > > { "async_depth", "Internal parallelization depth, the higher the > > > value > > > the higher the latency.", OFFSET(async_depth), AV_OPT_TYPE_INT, { .i64 = 0 > > > > }, > > > 0, INT_MAX, .flags = FLAGS }, > > > +#ifdef QSV_HAVE_SCALING_CONFIG > > > { "scale_mode", "scale mode: 0=auto, 1=low power, 2=high quality", > > > OFFSET(scale_mode), AV_OPT_TYPE_INT, { .i64 = MFX_SCALING_MODE_DEFAULT }, > > > MFX_SCALING_MODE_DEFAULT, MFX_SCALING_MODE_QUALITY, .flags = FLAGS, "scale > > > mode" }, > > > - > > > +#endif > > > { NULL } > > > }; > > > > > > @@ -304,6 +305,7 @@ static int config_output(AVFilterLink *outlink) > > > QSVVPPParam param = { NULL }; > > > QSVVPPCrop crop = { 0 }; > > > mfxExtBuffer *ext_buf[ENH_FILTERS_COUNT]; > > > + mfxVersion mfx_version; > > > AVFilterLink *inlink = ctx->inputs[0]; > > > enum AVPixelFormat in_format; > > > > > > @@ -317,6 +319,11 @@ static int config_output(AVFilterLink *outlink) > > > param.ext_buf = ext_buf; > > > param.async_depth = vpp->async_depth; > > > > > > + if (MFXQueryVersion(vpp->qsv->session, &mfx_version) < 0) { > > > + av_log(ctx, AV_LOG_ERROR, "Failed to query mfx version.\n"); > > > + return AVERROR(EINVAL); > > > + } > > > + > > > if (inlink->format == AV_PIX_FMT_QSV) { > > > if (!inlink->hw_frames_ctx || !inlink->hw_frames_ctx->data) > > > return AVERROR(EINVAL); > > > @@ -467,19 +474,20 @@ static int config_output(AVFilterLink *outlink) > > > #endif > > > } > > > > > > - if (inlink->w != outlink->w || inlink->h != outlink->h) { > > > #ifdef QSV_HAVE_SCALING_CONFIG > > > - memset(&vpp->scale_conf, 0, sizeof(mfxExtVPPScaling)); > > > - vpp->scale_conf.Header.BufferId = MFX_EXTBUFF_VPP_SCALING; > > > - vpp->scale_conf.Header.BufferSz = sizeof(mfxExtVPPScaling); > > > - vpp->scale_conf.ScalingMode = vpp->scale_mode; > > > - > > > - param.ext_buf[param.num_ext_buf++] = (mfxExtBuffer*)&vpp- > > > scale_conf; > > > -#else > > > - av_log(ctx, AV_LOG_WARNING, "The QSV VPP Scale option is " > > > - "not supported with this MSDK version.\n"); > > > -#endif > > > + if (inlink->w != outlink->w || inlink->h != outlink->h) { > > > + if (QSV_RUNTIME_VERSION_ATLEAST(mfx_version, 1, 19)) { > > > + memset(&vpp->scale_conf, 0, sizeof(mfxExtVPPScaling)); > > > + vpp->scale_conf.Header.BufferId = MFX_EXTBUFF_VPP_SCALING; > > > + vpp->scale_conf.Header.BufferSz = > > > sizeof(mfxExtVPPScaling); > > > + vpp->scale_conf.ScalingMode = vpp->scale_mode; > > > + > > > + param.ext_buf[param.num_ext_buf++] = (mfxExtBuffer*)&vpp- > > > > scale_conf; > > > > > > + } else > > > + av_log(ctx, AV_LOG_WARNING, "The QSV VPP Scale option is " > > > + "not supported with this MSDK version.\n"); > > > } > > > +#endif > > > > > > if (vpp->use_frc || vpp->use_crop || vpp->deinterlace || vpp->denoise > > > > > > > > > > vpp->detail || vpp->procamp || vpp->rotate || vpp->hflip || > > > > LGTM. I wonder whether you installed libmfx and msdk runtime from > > different packages, so the mfx version is higher than the runtime version? > > It's about a user with a Broadwell CPU on Windows. The latest drivers' MSDK > version is 1.11 and our ffmpeg is compiled against MSDK 1.35. > (a setup that is basically working fine, just the runtime checks are missing > at several places) Thanks for answer, I will apply your patch soon. BRs Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".