From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A626B45AF2 for ; Mon, 17 Apr 2023 02:38:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3419D68BE45; Mon, 17 Apr 2023 05:38:37 +0300 (EEST) Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3BB3168A23A for ; Mon, 17 Apr 2023 05:38:31 +0300 (EEST) Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-18779252f7fso16802563fac.12 for ; Sun, 16 Apr 2023 19:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681699109; x=1684291109; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=d70fKvRHzIkaPjKM29ZRqjAHvMrZYuFYogH0pnj3iXU=; b=oauDGKJO3/MDvybA4ZXLS+adppSQxkojTpZmnB/WZru5RPAYQ4gXEmes13VsA4FVcK LzfoO4F0Ac2LLLfxCi9zcMuB7EgdgnKFUsX59DyOtD3MHmLJZQ4EvYFoXp3p1H269IIh M2pEqPf7qKaUN9oAq4nXUFD0MojEiluCYJHs25Q3KTSQ4cmyryw6gK/q5rN+pDxK/G/Q zXlyOpSwuYuwMRFq7tsdB7hL8N3I0RrudITVNhVZlFrAmT2nky+ypalRveRvVwvLUKLr 2VIqMfXHjHCeraI6xFtIunNZ6gCUy2aiiEwu0p7jMAccRVDHvJr/fQ1nEQst2jmdix7r U1NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681699109; x=1684291109; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d70fKvRHzIkaPjKM29ZRqjAHvMrZYuFYogH0pnj3iXU=; b=K0nh4hPziHL1c9taE9/POEAebBcHzSysPLPlSELa6uIxAGztZ4ZmwVdcR2ncZ70xY5 1HvaQZ/Qnbl63z0RcZj3RqIl+DWrCUjSSAHt9fUbDxcJt5lqcedCN4pAnlmjHUQENbbG ekcPkJGnVz/Jxk7ECoPn7f3LdQHfoEMnuVednHOl/jP8l/Al4q40Q7/If+B9x9XfJHzd ccOmNtkAGK8JW1k7dbOOR8s/zPbV9ncKx+xmnos9EBpvIfWUAOtd4Z0ylwSRGPXlwr5n 9BANaDVIKHeufUo5954FQj33zrKAqkygOxelrdMkEissoLzMG8atOMZoUWzda4zBDxkX +wpQ== X-Gm-Message-State: AAQBX9c5k2JOFmBG/8MNthSs7q8ZfDUiHX1eYM5/A3nlKZJvlOMKfoFk lLsv/9mr5v9DQe5EFP9Ss5ni33kSAY0= X-Google-Smtp-Source: AKy350ZdWzYRrQrRszpCJqU2LutF1y/GlG/5Whjb7ukxEYo1kW3LmkHLcNeB5+7L+i9l8jq8y1Iszg== X-Received: by 2002:a05:6870:58d:b0:187:f6f4:f97d with SMTP id m13-20020a056870058d00b00187f6f4f97dmr218457oap.9.1681699109367; Sun, 16 Apr 2023 19:38:29 -0700 (PDT) Received: from [192.168.0.15] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id s66-20020a4a5145000000b005252e5b6604sm4241283ooa.36.2023.04.16.19.38.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Apr 2023 19:38:29 -0700 (PDT) Message-ID: <04c67a90-f7a4-eec4-dd08-2ee73a5298ed@gmail.com> Date: Sun, 16 Apr 2023 23:38:32 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230417023251.46560-1-jiasheng@iscas.ac.cn> From: James Almer In-Reply-To: <20230417023251.46560-1-jiasheng@iscas.ac.cn> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/msvideo1enc: Add check for av_malloc X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/16/2023 11:32 PM, Jiasheng Jiang wrote: > Add the check for the return value of the av_malloc in order to avoid > NULL pointer deference. > > Fixes: e4be3485af ("MS Video 1 encoder") > Signed-off-by: Jiasheng Jiang > --- > libavcodec/msvideo1enc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/msvideo1enc.c b/libavcodec/msvideo1enc.c > index 36cfd39a85..1fb8be8883 100644 > --- a/libavcodec/msvideo1enc.c > +++ b/libavcodec/msvideo1enc.c > @@ -84,6 +84,8 @@ static int encode_frame(AVCodecContext *avctx, AVPacket *pkt, > > if(!c->prev) > c->prev = av_malloc(avctx->width * 3 * (avctx->height + 3)); > + if (!c->prev) > + return AVERROR(ENOMEM); > prevptr = c->prev + avctx->width * 3 * (FFALIGN(avctx->height, 4) - 1); > src = (const uint16_t*)(p->data[0] + p->linesize[0]*(FFALIGN(avctx->height, 4) - 1)); > if(c->keyint >= avctx->keyint_min) Applied, thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".