From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 526A240799 for ; Tue, 1 Mar 2022 17:51:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EB3BB68B27D; Tue, 1 Mar 2022 19:51:28 +0200 (EET) Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A851968AFCD for ; Tue, 1 Mar 2022 19:51:22 +0200 (EET) Received: from smtp102.mailbox.org (smtp102.mailbox.org [80.241.60.233]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4K7Ptx5ZqJz9sQH for ; Tue, 1 Mar 2022 18:51:21 +0100 (CET) Message-ID: <04c39041-9eec-9bca-9f14-6fb302763467@gyani.pro> Date: Tue, 1 Mar 2022 23:21:06 +0530 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220228072844.5542-1-ffmpeg@gyani.pro> From: Gyan Doshi In-Reply-To: <20220228072844.5542-1-ffmpeg@gyani.pro> Subject: Re: [FFmpeg-devel] [PATCH] avfilter/drawtext: make reload value an interval X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Plan to push tomorrow. On 2022-02-28 12:58 pm, Gyan Doshi wrote: > Allows user to specify a frame interval at which textfile is reloaded. > --- > doc/filters.texi | 6 ++++-- > libavfilter/vf_drawtext.c | 6 +++--- > 2 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/doc/filters.texi b/doc/filters.texi > index b3ae139613..1ecc03eeae 100644 > --- a/doc/filters.texi > +++ b/doc/filters.texi > @@ -11271,8 +11271,10 @@ text data in detection bboxes of side data. So please do not use this parameter > if you are not sure about the text source. > > @item reload > -If set to 1, the @var{textfile} will be reloaded before each frame. > -Be sure to update it atomically, or it may be read partially, or even fail. > +The @var{textfile} will be reloaded at specified frame interval. > +Be sure to update @var{textfile} atomically, or it may be read partially, > +or even fail. > +Range is 0 to INT_MAX. Default is 0. > > @item x > @item y > diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c > index 2a88692cbd..6ba3f6622a 100644 > --- a/libavfilter/vf_drawtext.c > +++ b/libavfilter/vf_drawtext.c > @@ -198,7 +198,7 @@ typedef struct DrawTextContext { > AVRational tc_rate; ///< frame rate for timecode > AVTimecode tc; ///< timecode context > int tc24hmax; ///< 1 if timecode is wrapped to 24 hours, 0 otherwise > - int reload; ///< reload text file for each frame > + int reload; ///< reload text file at specified frame interval > int start_number; ///< starting frame number for n/frame_num var > char *text_source_string; ///< the string to specify text data source > enum AVFrameSideDataType text_source; > @@ -245,7 +245,7 @@ static const AVOption drawtext_options[]= { > {"timecode_rate", "set rate (timecode only)", OFFSET(tc_rate), AV_OPT_TYPE_RATIONAL, {.dbl=0}, 0, INT_MAX, FLAGS}, > {"r", "set rate (timecode only)", OFFSET(tc_rate), AV_OPT_TYPE_RATIONAL, {.dbl=0}, 0, INT_MAX, FLAGS}, > {"rate", "set rate (timecode only)", OFFSET(tc_rate), AV_OPT_TYPE_RATIONAL, {.dbl=0}, 0, INT_MAX, FLAGS}, > - {"reload", "reload text file for each frame", OFFSET(reload), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS}, > + {"reload", "reload text file at specified frame interval", OFFSET(reload), AV_OPT_TYPE_INT, {.i64=0}, 0, INT_MAX, FLAGS}, > { "alpha", "apply alpha while rendering", OFFSET(a_expr), AV_OPT_TYPE_STRING, { .str = "1" }, .flags = FLAGS }, > {"fix_bounds", "check and fix text coords to avoid clipping", OFFSET(fix_bounds), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS}, > {"start_number", "start frame number for n/frame_num variable", OFFSET(start_number), AV_OPT_TYPE_INT, {.i64=0}, 0, INT_MAX, FLAGS}, > @@ -1565,7 +1565,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) > } > } > > - if (s->reload) { > + if (s->reload && !(inlink->frame_count_out % s->reload)) { > if ((ret = load_textfile(ctx)) < 0) { > av_frame_free(&frame); > return ret; _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".